Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread Mark Volkmann
+1 for running all the code under src/jvm through some code formatter that uses something at least similar to the Sun Java conventions. On Mon, Mar 23, 2009 at 11:59 PM, BerlinBrown berlin.br...@gmail.com wrote: I was curious about how some of the clojure code worked and observed that the

Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread David Nolen
Javadoc would be nice, but I do note that Rich's Java code is pretty darn clear ;) I also note the indentation style is similar to Whitesmith's according to Wikipedia http://en.wikipedia.org/wiki/Indent_style. I've always preferred the BSD curly brace level matching convention over the KR

Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread Joshua
Even though I don't really care for the indentation style used, it is (unlike most projects) consistent and clear. Joshua On Mar 24, 8:40 am, David Nolen dnolen.li...@gmail.com wrote: Javadoc would be nice, but I do note that Rich's Java code is pretty darn clear ;) I also note the

Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread dysinger
You mean by Sun Norvig conventions right ? ;) http://code.google.com/p/clojure/issues/detail?id=16q=prettycolspec=ID%20Type%20Status%20Priority%20Reporter%20Owner%20Summary On Mar 24, 1:46 am, Mark Volkmann r.mark.volkm...@gmail.com wrote: +1 for running all the code under src/jvm through some

Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread wlr
On Mar 24, 7:46 am, Mark Volkmann r.mark.volkm...@gmail.com wrote: +1 for running all the code under src/jvm through some code formatter that uses something at least similar to the Sun Java conventions. On Mon, Mar 23, 2009 at 11:59 PM, BerlinBrown berlin.br...@gmail.com wrote: I was

Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread Howard Lewis Ship
+1 Using regular and proper formatting assists in submitting patches. A little Javadoc would be nice as well. On Tue, Mar 24, 2009 at 4:46 AM, Mark Volkmann r.mark.volkm...@gmail.com wrote: +1 for running all the code under src/jvm through some code formatter that uses something at least

Re: Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-24 Thread Meikel Brandmeyer
Hi, Am 24.03.2009 um 20:08 schrieb Howard Lewis Ship: Using regular and proper formatting assists in submitting patches. hahaha! If someone submitting a patch ever adhered to a coding convention of any sort. A little Javadoc would be nice as well. Yes. That would definitively be a good a

Suggestion for Java Clojure code, use of checkstyle or code formatter

2009-03-23 Thread BerlinBrown
I was curious about how some of the clojure code worked and observed that the coding style is a little bit non idiomatic from typical Java coding conventions. E.g. there aren't any javadoc comments on methods or classes, non standard indents. Something like checkstyle might prove useful.