ttomecek added a new comment to an issue you are following:
``
The PR is merged: new release of atomic will be able to handle the workflow
defined in this thread.
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/issue/256
_
ttomecek added a new comment to an issue you are following:
``
I just updated the atomic PR: https://github.com/projectatomic/atomic/pull/941
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/issue/256
___
cloud m
ttomecek added a new comment to an issue you are following:
``
I am still working on the PR for atomic.
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/issue/256
___
cloud mailing list -- cloud@lists.fedoraproje
The status of the issue: `atomic command changes: prefer file over label` of
project: `atomic-wg` has been updated to: Closed as Wontfix by jberkus.
https://pagure.io/atomic-wg/issue/256
___
cloud mailing list -- cloud@lists.fedoraproject.org
To unsubs
jberkus added a new comment to an issue you are following:
``
Closing, all changes have been made per discussion.
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/issue/256
___
cloud mailing list -- cloud@lists.f
ttomecek added a new comment to an issue you are following:
``
We should also update
https://fedoraproject.org/wiki/Container:Guidelines#LABELS with info that
`help` label is meant to be command, not text.
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg
ttomecek added a new comment to an issue you are following:
``
@jberkus it depends what configuration OSBS in Fedora is using. @maxamillion
can you clarify?
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/issue/256
___
jberkus added a new comment to an issue you are following:
``
So, for 3, we'll say that the maintainer needs to supply a help file, but they
don't need to COPY it into the image, because OSBS will do that?
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/
hhorak added a new comment to an issue you are following:
``
> ad 3: I expect that OSBS in Fedora uses atomic-reactor that is able to
> convert and add the README.md from dist-git to help.1 and add the COPY
> command into the Dockerfile. Why not use this feature? It would limit the
> maintainer
dustymabe added a new comment to an issue you are following:
``
> Example of multi-line description is here:
> https://hhorak.fedorapeople.org/httpd-docker/Dockerfile
> I think it works still quite well and looks better in the Dockerfile than one
> long line IMO.
Yes, but what you are doing is
ttomecek added a new comment to an issue you are following:
``
I like the new requirements: it should be clear to finish the implementation.
Is `atomic` meant to interact with description label in any way?
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/
hhorak added a new comment to an issue you are following:
``
Example of multi-line description is here:
https://hhorak.fedorapeople.org/httpd-docker/Dockerfile
I think it works still quite well and looks better in the Dockerfile than one
long line IMO.
Anyway, the New requirements seem fine to
dustymabe added a new comment to an issue you are following:
``
seems reasonable. one small change I would make is that the description be only
1 line. I would prefer to only have one line even if it is a long line, I
think.
``
To reply, visit the link below or just reply to this email
https:/
jberkus added a new comment to an issue you are following:
``
Ref issues #243 #267
New requirements:
1. Every image is required to have a "description" label, which will be 1-3
lines of human-readable text on what the image is for. This description is
meant to be searchable by skopeo.
2. Ima
jberkus added a new comment to an issue you are following:
``
So:
* The reason for using HELP instead of "description" is the atomic CLI.
Otherwise, I'd have used "description". So I'm fine with that switch ...
except that atomic CLI has no interaction with "description", does it?
* "help1.tx
ttomecek added a new comment to an issue you are following:
``
I personally don't feel competent enough to decide this. @jberkus what do you
think about @dustymabe's proposal, would that be okay?
``
To reply, visit the link below or just reply to this email
https://pagure.io/atomic-wg/issue/256
baude added a new comment to an issue you are following:
``
Unless we want to offend the spec that defines the label or change it, I think
@dustymabe is on the right track. Use something like a echo. Again, happy to
make changes to the atomic cli to have a secondary help label that we could
j
dustymabe added a new comment to an issue you are following:
``
@ttomecek i actually was thinking something more like this:
```
LABEL
HELP='http://pkgs.fedoraproject.org/cgit/docker/cockpit.git/plain/README.md?h=f25'
```
The user can then choose to open that in the browser or use curl. I think
ttomecek added a new comment to an issue you are following:
``
@baude thanks for feedback!
From the blog post:
This file will be submitted with the image proposal, and will be included
bout inside the container image and available online from
fedoraproject.org. The Help label will li
baude added a new comment to an issue you are following:
``
The https://github.com/projectatomic/ContainerApplicationGenericLabels
definition of the HELP label for images is defined as "Command to run the help
command of the image". The way Atomic CLI help was designed was as follows:
* If a H
ttomecek added a new comment to an issue you are following:
``
@jberkus Josh, after reading your [blog
post](http://www.projectatomic.io/blog/2017/03/fedora-vfad-container-policy/) I
don't feel like I'm comfortable with `help1.txt`. Right now `atomic` expects
man-formatted file named `help.1`,
The issue: `atomic command changes: prefer file over label` of project:
`atomic-wg` has been assigned to `ttomecek` by dustymabe.
https://pagure.io/atomic-wg/issue/256
___
cloud mailing list -- cloud@lists.fedoraproject.org
To unsubscribe send an email
22 matches
Mail list logo
