Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos3 into
cloud-init:master.
Commit message:
FIXME: Templatize systemd service files
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1704872 in cloud-init: "sysconfig use subnet prefix an
this is from Ryan's commit
Use prefix for ipv6 and set v4 and v6 gateway keys, use DEFROUTE
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327739
Your team cloud-init commiters is requested t
i took your commit
Use prefix for ipv6 and set v4 and v6 gateway keys, use DEFROUTE
and put up
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327739
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
Your team cloud-init commiters is reque
The proposal to merge ~smoser/cloud-init:feature/curtin-centos2 into
cloud-init:master has been updated.
Commit Message changed to:
sysconfig: ipv6 and default gateway fixes.
With this change, entries in IPV6ADDR and IPV6ADDR_SECONDARIES will now
always be in format addr/prefix. When a subnet
Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos2 into
cloud-init:master.
Commit message:
sysconfig: ipv6 and default gateway fixes.
With this change, entries in IPV6ADDR and IPV6ADDR_SECONDARIES will now
always be in format addr/prefix. When a subnet has a gateway
The proposal to merge
~smoser/cloud-init:bug/1705147-rename-support-mixed-case-macs into
cloud-init:master has been updated.
Commit Message changed to:
net: fix renaming of nics to support mac addresses written in upper case.
The network device renaming code previously required the case of
the
I pulled:
Your-commit trunk-comt summary
8da074f831c d1e8eb73ac sysconfig: include GATEWAY value if set in subnet
changes:
i shorted lines in commit messages and made tox tests pass (had to add the
newly rendered GATEWAY values) to more than the one test you did it to.
$ git diff 8da074f831c..
The proposal to merge ~smoser/cloud-init:bug/1683038-ec2-no-warn-on-explicit
into cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324274
--
Your team cloud-init commiters
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
tests: fixes for issues uncovered when moving to python3.6
This includes a few fixes found when testing with python 3.6.
- fix eni renderer when target is N
The proposal to merge ~smoser/cloud-init:feature/pregen-locale into
cloud-init:master has been updated.
Commit Message changed to:
locale: Do not re-run locale-gen if provided locale is system default.
If the system configure default in /etc/default/locale is set to the same
value that is provi
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
tests: fixes for issues uncovered when moving to python3.6
This includes 2 different fixes both found when testing with python 3.6.
- fix eni renderer when
i cleaned up that register_helper a bit, thanks for the review, Ryan.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327534
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master.
_
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
tests: fixes for issues uncovered when moving to python3.6
This includes 2 different fixes both found when testing with python 3.6.
- fix eni renderer when
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
tests: fixes for issues uncovered when moving to python3.6
This includes 2 different fixes both found when testing with python 3.6.
- fix eni renderer when
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..a5485ff
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,201 @@
> +# This file is part of cloud-init.
I grabbed the initial test portions of this merge proposal and put them into
another
at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327534
note, those do not have the tests for WarnIfNecessary
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324274
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/ec2-initial-tests
into cloud-init:master.
Commit message:
tests: Add initial tests for EC2 and improve a docstring.
EC2 was the original, but this adds some initial tests for that datasource.
Also updates a docstring for an internal
The proposal to merge ~smoser/cloud-init:cleanup/ec2-initial-tests into
cloud-init:master has been updated.
Commit Message changed to:
tests: Add initial tests for EC2 and improve a docstring.
EC2 was the original, but this adds some initial tests for that datasource.
Also updates a docstring f
This is a update to
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325406
with the suggestions I had to that MP fixed
(added unit tests)
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532
Your team cloud-init commiters is requested to review the
The proposal to merge ~smoser/cloud-init:feature/pregen-locale into
cloud-init:master has been updated.
Commit Message changed to:
locale: Do not re-run locale-gen if provided locale is system default.
If the system configure default in /etc/default/locale is set to the same
value that is provi
Scott Moser has proposed merging ~smoser/cloud-init:feature/pregen-locale into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532
--
Your team cloud-init commiters is
Scott Moser has proposed merging
~smoser/cloud-init:feature/load_shell_content-comments into cloud-init:master.
Commit message:
Support comments in content read by load_shell_content.
load_shell_content previously would not allow shell comment characters
in the content being parsed. If
The proposal to merge ~smoser/cloud-init:feature/load_shell_content-comments
into cloud-init:master has been updated.
Commit Message changed to:
Support comments in content read by load_shell_content.
load_shell_content previously would not allow shell comment characters
in the content being pa
The proposal to merge ~szeestraten/cloud-init:doc-fix-disk-setup-examples into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~szeestraten/cloud-init/+git/cloud-init/+merge/327274
--
Your team cloud-init commiters is requ
The proposal to merge ~j.kylmala/cloud-init:exceptions into cloud-init:master
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~j.kylmala/cloud-init/+git/cloud-init/+merge/327284
--
Your team cloud-init commiters is requested to review the p
We still need one more fix in cloud-init.
test_simple_run.py has some side effects, and makes test_create_users.py (and
possibly others) succeed when they should not.
This was found when looking at bug 1704024. It seems that python 3.6 ends
up iterating through tests in a different order than 3.5
Scott Moser has proposed merging ~smoser/cloud-init:bug/fix-gce-test into
cloud-init:master.
Commit message:
tests: fix usage of mock in GCE test.
The usage of mock in this test was simply invalid and only worked by
happenstance.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For
Balint,
I had a thoguht that might improve this a bit.
cloud-init could (i think) make sure that fscks are delayed for each of the
filesystems it "owns" (the ones it would write 'comment=cloud-config' on in
/etc/fstab).
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
fix eni renderer when target is None
This just uses the util.target_path() in the event that target is None.
LP: #1703697
For more details, see:
https://co
Scott Moser has proposed merging
~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1703697 in cloud-init: "tox fails under python 3.6"
https://bugs.launchpad.net/cloud-init/+bug/17
Balint,
thanks for your review!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/before-fsck into cloud-init:master.
___
M
The proposal to merge ~powersj/cloud-init:update-pylxd-version into
cloud-init:master has been updated.
Commit Message changed to:
tests: Update version of pylxd
lxd 2.15 broke pylxd version 2.2.3.
Upgrading to version 2.2.4 fixes issues with missing attributes.
For more details, see:
https://
The proposal to merge ~mb-methot/cloud-init:bug/1699282 into cloud-init:master
has been updated.
Commit Message changed to:
fix puppet module when run under python 2.
six.StringIO in python2 cannot be used in a context guard.
The solution here is to
For more details, see:
https://code
The proposal to merge ~powersj/cloud-init:update-pylxd-version into
cloud-init:master has been updated.
Commit Message changed to:
tests: Update version of pylxd
lxd 2.15 broke pylxd version 2.2.3 broke.
Upgrading to version 2.2.4 fixes issues with missing attributes.
For more details, see:
ht
David,
Balint's work flow here is completely valid.
He was reviewing
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191 and
wanted to suggest a different path for fixes so he proposed a merge into that
branch (~smoser/cloud-init:bug/before-fsck).
I often do the same wh
Bob,
This mostly looks good, but I have some comments.
First, a small suggestion. Lets use __invalid_cloud_init__ to address your
comment in the bug
| For anyone who's looking at DNS logs for security purposes, that "random,
| unqualified 32-character alphanumeric hostname" is going to cause sign
Balint,
How would that work?
I think you're essentially saying to run:
systemctl stop systemd-fsck@.service
But to do that, I have to figure out which are the appropriate values for
'something'. That could be 'dev-disk-by-uuid=', 'dev-disk-by-label='
for any filesystem on the block de
The proposal to merge ~b-candler/cloud-init:nocloud-doc into cloud-init:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~b-candler/cloud-init/+git/cloud-init/+merge/327059
--
Your team cloud-init commiters is requested to review the prop
The proposal to merge ~b-candler/cloud-init:nocloud-doc into cloud-init:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~b-candler/cloud-init/+git/cloud-init/+merge/327059
--
Your team cloud-init commiters is requested to review th
Scott Moser has proposed merging
~smoser/cloud-init:bug/1701325-no-dmi-data-in-container into cloud-init:master.
Commit message:
read_dmi_data: always return None when inside a container.
This fixes stacktrace and warning message that would be printed
to the log if running inside a container
The proposal to merge ~smoser/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial has been updated.
Description changed to:
This just cherry picks the following back to xenial for sru upload
5fb49bac: azure: identify platform by well known value in chassis asset (LP:
#1693939)
https://git
The proposal to merge ~smoser/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial has been updated.
Description changed to:
This just cherry picks the following back to xenial for sru upload
5fb49bac: azure: identify platform by well known value in chassis asset (LP:
#1693939)
https://git
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial.
Commit message:
place holder
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1693939 in cloud-init: "Switch Azure detection to use chassis_asset_tag&quo
The proposal to merge ~smoser/cloud-init:ubuntu/xenial into
cloud-init:ubuntu/xenial has been updated.
Commit Message changed to:
place holder
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/326452
--
Your team cloud-init commiters is requested to re
The proposal to merge ~smoser/cloud-init:azure_run_local into cloud-init:master
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/326373
--
Your team cloud-init commiters is requested to review the pr
The proposal to merge ~smoser/cloud-init:azure_run_local into cloud-init:master
has been updated.
Commit Message changed to:
Azure: Add network-config, Refactor net layer to handle duplicate macs.
On systems with network devices with duplicate mac addresses, cloud-init
will fail to rename the d
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index ce3c10d..35d9a55 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -372,6 +372,7 @@ def main_init(name, args):
> LOG.debug("[%s] %s is in local mode, will apply init modules
>
Scott Moser has proposed merging ~smoser/cloud-init:azure_run_local into
cloud-init:master.
Commit message:
place holder
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/326373
building on
I kind of see this as something that should be fixed in another way.
a. The user gave cloud-init bad data.
b. cloud-init probably did a bad job of telling them that.
I don't think, though, that a + b =
c. cloud-init should make a guess as to what they meant to do.
It feels like you're trying to
I'm marking this merged as the intent of it is merged.
the merge proposal above is in, and I think you should be good for building on
freebsd now.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
Your team cloud-init commiters is requested to review the proposed
The proposal to merge ~redriver/cloud-init:fail_to_install_on_frbsd into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
--
Your team cloud-init commiters is requested to
The proposal to merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713
--
Your team cloud-init commiters is requested to
The proposal to merge ~smoser/cloud-init:fix/freebsd-test-failure into
cloud-init:master has been updated.
Commit Message changed to:
FreeBSD: fix test failure
The previous commit caused test failure.
This separates out _check_freebsd_cdrom and mocks it in a test
rather than patching open.
For
Scott Moser has proposed merging ~smoser/cloud-init:fix/freebsd-test-failure
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325771
--
Your team cloud-init commiters
actually, on further thought, lets leve suse out right now.
there is a 'sles' distro (cloudinit/distros/sles.py) but per
https://github.com/hpcugent/easybuild/wiki/OS_flavor_name_version
we would see 'suse' as the dist.
not sure what the right change is.
i didn't *change* any behavior here i do
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index 415ca37..817d347 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -598,37 +598,29 @@ def get_cfg_option_int(yobj, key, default=0):
> def system_info():
> info = {
> 'platform': platform.plat
The proposal to merge ~b1sandmann/cloud-init:fix-debian-template into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325478
--
Your team cloud-init commiters is requested to revie
The proposal to merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713
--
Your team cloud-init commiters is reques
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Commit Message changed to:
freebsd: Make freebsd a variant, fix unittests and tools/build-on-freebsd.
- Simplify the logic of 'variant' in util.system_info
much of the data from
http
this replaces some of the changes from
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feat
i've put up
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
that covers most of these.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
Your team cloud-init commiters is requested to review the proposed merge of
~redriver/cloud-init:f
Scott Moser has proposed merging ~smoser/cloud-init:feature/freebsd-variant
into cloud-init:master.
Commit message:
fixes for freebsd
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
over all nice.
some comments.
thank you, Julien.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceScaleway.py
> b/cloudinit/sources/DataSourceScaleway.py
> new file mode 100644
> index 000..ed3fef2
> --- /dev/null
> +++ b/cloudinit/sources/DataSourceScaleway.py
> @@ -0,0 +1,235 @@
Diff comments:
> diff --git a/tools/build-on-freebsd b/tools/build-on-freebsd
> index ccc10b4..f16d62e 100755
> --- a/tools/build-on-freebsd
> +++ b/tools/build-on-freebsd
> @@ -17,6 +17,7 @@ pkgs="
> py27-jsonpatch
> py27-jsonpointer
> py27-oauth
we can drop py27-oauth now. its rep
Some things, and some content inline:
* We'll need some unit tests for this. Otherwise it is at increased risk of
being inadvertently broken.
* We will need to add knowledge of the datasource to tools/ds-identify
(without that your datasource will only ever be considered if it is a single
en
this seems sane just looking at the diff, i'll look further today.
i think you'd opened a bug though... need to link to it.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713
Your team cloud-init commiters is requested to review the proposed merge of
~redriver/clou
I'll look at this later, but i'm not sure we can just
- 'platform': platform.platform(),
+ 'platform': platform.uname()[0],
without breaking other things. I'll try this out today though and will find a
freebsd to test on.
--
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+me
Andrew,
thanks. I think the code looks good
But a few things
a.) maybe 'detach_tty' as the name? 'no_tty=False' seems to imply that there
would be a tty, when we are not actually creating one.
b.) need some sort of test, at least to push it through here. it might be
tricky to do, but i'd like t
I would like to update util.load_shell_content to support the comment char.
and then perhaps to just skip blank lines (or only white space lines) entirely
then i think this looks good.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325406
Your team cloud-init commiters
The proposal to merge ~chad.smith/cloud-init:schema-autodoc into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325507
--
Your team cloud-init commiters is requested to revi
With this changeset applied i can:
for ver in 6 7; do
./tools/run-centos -vv $ver --unittest --rpm --srpm --artifact 2>&1 |
tee out${ver}.log; done
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325679
Your team cloud-init commiters is requested to review the
The proposal to merge ~smoser/cloud-init:bug/fix-ci-redhat into
cloud-init:master has been updated.
Commit Message changed to:
tools/run-centos: cleanups and move to using read-dependencies
These changes are all in an effort to get tools/run-centos using
read-dependencies rather than the 'setup
The proposal to merge ~smoser/cloud-init:bug/fix-ci-redhat into
cloud-init:master has been updated.
Commit Message changed to:
place holder
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325679
--
Your team cloud-init commiters is requested to revie
Scott Moser has proposed merging ~smoser/cloud-init:bug/fix-ci-redhat into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325679
--
Your team cloud-init commiters is
The proposal to merge
~wesley-wiedenmeier/cloud-init:integration-testing-distro-features into
cloud-init:master has been updated.
Status: Work in progress => Merged
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/321029
--
Your team c
Hi.
I've marked this 'merged' as I think it is now in trunk under
76d58265e34851b78e952a7f275340863c90a9f5.
If you disagree, please feel free to re-open.
--
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/314496
Your team cloud-init commiters is requested to revie
Hi.
I've marked this 'merged' as I think it is now in trunk under
76d58265e34851b78e952a7f275340863c90a9f5.
If you disagree, please feel free to re-open.
--
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/320401
Your team cloud-init commiters is requested to revie
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing-tmpdir
into cloud-init:master has been updated.
Status: Work in progress => Merged
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/320401
--
Your team cloud-init
Hi.
I've marked this 'merged' as I think it is now in trunk under
76d58265e34851b78e952a7f275340863c90a9f5.
If you disagree, please feel free to re-open.
--
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/321029
Your team cloud-init commiters is requested to revie
The proposal to merge
~wesley-wiedenmeier/cloud-init:integration-testing-invocation-cleanup into
cloud-init:master has been updated.
Status: Work in progress => Merged
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/314496
--
Your tea
Hi.
I've marked this 'merged' as I think it is now in trunk under
76d58265e34851b78e952a7f275340863c90a9f5.
If you disagree, please feel free to re-open.
--
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218
Your team cloud-init commiters is requested to revie
The proposal to merge ~wesley-wiedenmeier/cloud-init:integration-testing into
cloud-init:master has been updated.
Status: Work in progress => Merged
For more details, see:
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218
--
Your team cloud-init commite
Well, we re-worked the spec and brpm recently, but really to do more, not less.
I'm going to mark this 'rejected' due to that.
I think the 'brpm' is nicer at this point in trunk.
--
https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307991
Your team cloud-init commiters is req
The proposal to merge ~harlowja/cloud-init:kill-brpm into cloud-init:master has
been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307991
--
Your team cloud-init commiters is requested to review th
The proposal to merge ~xnox/cloud-init:nplan-ipv6-int-mask2cidr into
cloud-init:master has been updated.
Status: Work in progress => Rejected
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324106
--
Your team cloud-init commiters is requested to re
I believe this is fixed under bug 1689346.
Please feel free to re-submit if not.
I'm going to reject this as it is just to get it out of the list.
Thanks
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324106
Your team cloud-init commiters is requested to review the propose
Romanos,
Any progress ?
I realize that often times things fall off the immediate radar. Feel free to
ping me if you have any questions.
Thanks,
Scott
--
https://code.launchpad.net/~rski/cloud-init/+git/cloud-init/+merge/312284
Your team cloud-init commiters is requested to review the proposed m
It seems like there is probably a better (or at very least less expensive) way
to do this than to incur the cost of a subprocess.
I suspect
a.) change 'yum' to be invoked with '--quiet' or the like
b.) close and re-open stdout or something like that. yum is probably using
'isatty' to change its
The proposal to merge ~b1sandmann/cloud-init:fix-debian-template into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325478
--
Your team cloud-init commiters is requested to
Thank you Jens,
I'll pull this shortly.
--
https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325478
Your team cloud-init commiters is requested to review the proposed merge of
~b1sandmann/cloud-init:fix-debian-template into cloud-init:master.
_
The proposal to merge ~b1sandmann/cloud-init:fix-debian-template into
cloud-init:master has been updated.
Description changed to:
debian: fix path comment in /etc/hosts template.
The comments in the debian template file of /etc/hosts still pointed to a
general template file instead of the debia
I think that the signature change is fine.
the other fixme I think is best fixed by just having ds-identify write an entry
in the config that says that it wrote a datasource_list, and how it did that.
Ie, it could declare that it essentially copied the datasource list like this:
di_datasource_
'null' seems to have a different meaning for pyyaml and pyserial.
that needs to be cleaned up, but i dont have anything other comments.
(i realize that we're not going to be buildling rhel python34 at the moment, so
this is reasonably lower priority).
Diff comments:
> diff --git a/packages/pkg
The proposal to merge ~smoser/cloud-init:bug/1693361-apt-get-locks into
cloud-init:master has been updated.
Commit Message changed to:
systemd: make cloud-final.service run before apt daily services.
This changes all cloud-init systemd units to run 'Before' the apt processes
that run daily and
The proposal to merge ~smoser/cloud-init:bug/1693361-apt-get-locks into
cloud-init:master has been updated.
Commit Message changed to:
systemd: make cloud-final.service run before apt daily services.
This is really just a work around for apt. The solution here is to cause
cloud-init-final.serv
Scott Moser has proposed merging ~smoser/cloud-init:bug/1693361-apt-get-locks
into cloud-init:master.
Commit message:
systemd: make cloud-final.service run before apt daily services.
This is really just a work around for apt. The solution here is to cause
cloud-init-final.service to run Before
Hi,
So I think the basic idea here is to attempt to mount the cdrom to verify that
there is in fact a cdrom.
Thats not an entirely bad idea, but it seems like it might be sufficient to
either:
a.) always add 'dev/cd0' on freebsd and let the code in get_data just attempt
to mount, which means we
I have some questions inline below. I think most would fall or in actually
trying to build an tomorrow in each distro/release
Diff comments:
> diff --git a/packages/pkg-deps.json b/packages/pkg-deps.json
> new file mode 100644
> index 000..2100ec7
> --- /dev/null
> +++ b/packages/pkg-deps.js
nits!
Diff comments:
> diff --git a/Makefile b/Makefile
> index a3bfaf7..faa391c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,6 +86,7 @@ clean_pyc:
> clean: clean_pyc
> rm -rf /var/log/cloud-init.log /var/lib/cloud/
>
> +
drop white space change i think... unless you had some reaso
The proposal to merge ~smoser/cloud-init:feature/redhat-spec-improvements into
cloud-init:master has been updated.
Commit Message changed to:
rhel/centos spec cleanups.
Many changes here to get us able to build rpms on CentOS 5 or 6 and RHEL.
* add 'Requires' as 'BuildRequires' also.
This
801 - 900 of 1711 matches
Mail list logo
