Re: where features are developed was: Review Request: Merge Kelven's VPC code for Vmware into asf vpc branch

2012-08-10 Thread Chiradeep Vittal
On 8/7/12 7:26 PM, "Chip Childers" wrote: >On Aug 7, 2012, at 8:12 PM, Ewan Mellor wrote: > >>> -Original Message- >>> From: David Nalley [mailto:da...@gnsa.us] >>> Sent: Tuesday, August 07, 2012 3:42 PM >>> To: cloudstack-dev@incubator.apache.org >>> Subject: Re: where features are de

Re: [RFC] CloudStack Architectural Refactor

2012-08-10 Thread Kelven Yang
CloudStack conceptually manages how virtual resource is virtualized(or call it realized) into the physical infrastructure. These management works include 1) Tenant based configuration management for compute(VMs), network (user logic networks), storage 2) Fabric(physical resource like hypervisor ho

RE: Release Management Process

2012-08-10 Thread Will Chan
From: David Nalley [da...@gnsa.us] Sent: Friday, August 10, 2012 8:40 PM To: cloudstack-dev@incubator.apache.org Subject: Re: Release Management Process > As for upgrade, I didn't honestly think that was a question. We have > thousands of CloudStack deploy

Review Request: Adding Apache license to query.xml and r-named files under docs directory

2012-08-10 Thread Joe Brockmeier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6543/ --- Review request for cloudstack. Description --- Adding Apache license to que

Re: Release Management Process

2012-08-10 Thread David Nalley
On Fri, Aug 10, 2012 at 9:27 PM, Will Chan wrote: >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+4.0+Release+Checklist > > Ewan, thanks the release plan. A couple of questions since I wasn't sure if > the goal is to include them in the release: > > 1. I don't see the Netsca

Re: Review Request: Adding Apache license to p-named files under docs directory

2012-08-10 Thread Joe Brockmeier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6542/ --- (Updated Aug. 11, 2012, 3:41 a.m.) Review request for cloudstack. Changes

Review Request: Adding Apache license to o-named files under docs directory

2012-08-10 Thread Joe Brockmeier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6542/ --- Review request for cloudstack. Description --- Added Apache license, fixed

Re: Review Request: Adding Apache license to additional files under docs directory

2012-08-10 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6540/#review10167 --- Ship it! worksforme - David Nalley On Aug. 11, 2012, 2:41 a.m., J

Re: Review Request: Adding Apache license to o-named files under docs directory

2012-08-10 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6541/#review10166 --- Ship it! Looks good to me. - David Nalley On Aug. 11, 2012, 2:55

Re: Release Management Process

2012-08-10 Thread David Nalley
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+4.0+Release+Checklist > > Ewan. > So there are a few timeline problems here. The project has to vote - that stays open for 72 hours. (e.g. annointing a release candidate) Once that vote concludes we then move to getting IPMC appr

Review Request: Adding Apache license to o-named files under docs directory

2012-08-10 Thread Joe Brockmeier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6541/ --- Review request for cloudstack. Description --- Added Apache license, fixed

Review Request: Adding Apache license to additional files under docs directory

2012-08-10 Thread Joe Brockmeier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6540/ --- Review request for cloudstack. Description --- Adding Apache license to sev

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

2012-08-10 Thread Chip Childers
You probably need to do an interactive git rebase, and squash your local commits into one. Then generate a patch from that clean commit. - chip Sent from my iPhone. On Aug 10, 2012, at 10:03 PM, Krishna Sadasivam wrote: > I changed the BrocadePluginTest.java to use > org.apache.commons.codec.

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

2012-08-10 Thread Krishna Sadasivam
I changed the BrocadePluginTest.java to use org.apache.commons.codec.binary.Base64. When I create a patch and try to upload to review board I get the following error: " The file 'plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java' (r0b8fd2c) could not be fou

RE: Release Management Process

2012-08-10 Thread Will Chan
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+4.0+Release+Checklist Ewan, thanks the release plan. A couple of questions since I wasn't sure if the goal is to include them in the release: 1. I don't see the Netscaler AutoScaling feature merge into master. Has that been d

Re: Review Request: CS-15823 Failed snapshot should be marked as Error and cleanup asynchronously

2012-08-10 Thread mice xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6325/ --- (Updated Aug. 11, 2012, 1:13 a.m.) Review request for cloudstack, Nitin Mehta an

Re: FW: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread David Nalley
On Fri, Aug 10, 2012 at 8:49 PM, Jessica Tomechak wrote: >> >> >> -Original Message- >> From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com] >> Sent: Friday, August 10, 2012 1:01 PM >> To: David Nalley; cloudstack-dev@incubator.apache.org >> Subject: RE: [ASFCS40] CloudStack 4.0 release pl

Re: FW: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread Jessica Tomechak
> > > -Original Message- > From: Ewan Mellor [mailto:ewan.mel...@eu.citrix.com] > Sent: Friday, August 10, 2012 1:01 PM > To: David Nalley; cloudstack-dev@incubator.apache.org > Subject: RE: [ASFCS40] CloudStack 4.0 release plan > > > -Original Message- > > From: David Nalley [mailt

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Jamshid Afshar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/ --- (Updated Aug. 10, 2012, 11:47 p.m.) Review request for cloudstack. Description

Re: asf/vpc branch merge

2012-08-10 Thread Alena Prokharchyk
On 8/10/12 1:56 PM, "David Nalley" wrote: >You mention the main part is done, what is left for this feature for >it to be completely done? > >--David > Bug fixes mostly. There are also some feature limitations for the current release - VPC is supported for Xen/VmWare hypervisors only; we are pl

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Jamshid Afshar
> On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote: > > Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I presume > > CAStorSDK is one that you own -- what about the other one? The license on > > dependent libraries affects whether we can build the code as part of the > > def

Re: Unresolved review requests

2012-08-10 Thread John Kinsella
I bugged a few folks directly earlier this week - got the list down by about 10-15 requests. I didn't bug people where the request looked like it wasn't resolved... On Aug 10, 2012, at 4:31 PM, Ewan Mellor wrote: > We have lots of old unresolved review requests. If you are the original > auth

Merge branches in asf repo

2012-08-10 Thread Alena Prokharchyk
As I'm not a git expert, I would appreciate any help from the community in figuring out what is the best way to merge asf/vpc branch into asf/master. Couple of ways I can think of: 1) git checkout master; git merge -s recursive -Xignore-space-change vpc Puts all commits from the vpc that are di

Re: asf/vpc branch merge

2012-08-10 Thread Alena Prokharchyk
As I'm not a git expert, I would appreciate any help from the community in figuring out what is the best way to merge vpc branch into master. Couple of ways I can think of: 1) git checkout master; git merge -s recursive -Xignore-space-change vpc Puts all commits from the vpc that are differnt f

RE: Unit tests

2012-08-10 Thread Ewan Mellor
http://jenkins.cloudstack.org/job/test-junit, by the way. Ewan. From: Ewan Mellor Sent: 10 August 2012 16:36 To: cloudstack-dev@incubator.apache.org Subject: Unit tests We are down to the last two unit test failures (thanks to Mice for his recent patch which dealt with two others). The failure

Unit tests

2012-08-10 Thread Ewan Mellor
We are down to the last two unit test failures (thanks to Mice for his recent patch which dealt with two others). The failures are: com.cloud.agent.manager.ResourceManagerTest.testDeploy100Hosts (reliable) and com.cloud.utils.net.NetUtilsTest.testGetRandomIpFromCidr (50% intermittent) Full error

Unresolved review requests

2012-08-10 Thread Ewan Mellor
We have lots of old unresolved review requests. If you are the original author, you are the one who has to close the request (mark it as submitted) once it has been committed. (Yes, this is daft, but it's the way that the tool works right now.) Please close your requests (either as submitted

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Ewan Mellor
> On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote: > > Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I presume > > CAStorSDK is one that you own -- what about the other one? The license on > > dependent libraries affects whether we can build the code as part of the > > def

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Eric Dey
> On Aug. 10, 2012, 10:52 p.m., Ewan Mellor wrote: > > Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I presume > > CAStorSDK is one that you own -- what about the other one? The license on > > dependent libraries affects whether we can build the code as part of the > > def

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread Ewan Mellor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10157 --- Jamshid, what is the license on CAStorSDK.jar and jmdns-2.1.jar? I p

RE: Release Management Process

2012-08-10 Thread Ewan Mellor
> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: 10 August 2012 14:06 > To: > Subject: Re: Release Management Process > > On Aug 10, 2012, at 4:52 PM, Ewan Mellor > wrote: > > >> -Original Message- > >> From: Ewan Mellor > >> Sent: 07 August

Re: Release Management Process

2012-08-10 Thread Chip Childers
On Aug 10, 2012, at 4:52 PM, Ewan Mellor wrote: >> -Original Message- >> From: Ewan Mellor >> Sent: 07 August 2012 13:49 >> To: cloudstack-dev@incubator.apache.org >> Subject: RE: Release Management Process >> >>> -Original Message- >>> From: Chip Childers [mailto:chip.child...@su

Re: asf/vpc branch merge

2012-08-10 Thread David Nalley
You mention the main part is done, what is left for this feature for it to be completely done? --David

RE: Release Management Process

2012-08-10 Thread Ewan Mellor
> -Original Message- > From: Ewan Mellor > Sent: 07 August 2012 13:49 > To: cloudstack-dev@incubator.apache.org > Subject: RE: Release Management Process > > > -Original Message- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Monday, August 06, 2012 12:59 PM >

Re: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread David Nalley
On Fri, Aug 10, 2012 at 4:00 PM, Ewan Mellor wrote: >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> Sent: 10 August 2012 12:56 >> To: cloudstack-dev@incubator.apache.org >> Cc: Ewan Mellor >> Subject: Re: [ASFCS40] CloudStack 4.0 release plan >> >> > >> > The only exc

Re: Review Request: Fix for VR private network interface problem after HA switchover on VMware.

2012-08-10 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6502/#review10154 --- Ship it! Ship It! - Kelven Yang On Aug. 9, 2012, 11:26 p.m., Fang

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6470/#review10153 --- Ship it! Ship It! - Marcus Sorensen On Aug. 10, 2012, 8:35 p.m.,

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6470/#review10152 --- Ship it! Ship It! - edison su On Aug. 10, 2012, 8:35 p.m., Marcus

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6470/ --- (Updated Aug. 10, 2012, 8:35 p.m.) Review request for cloudstack. Changes

Re: Review Request: Merge Kelven's VPC code for Vmware into asf vpc branch

2012-08-10 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6300/#review10151 --- Ship it! Ship It! - Kelven Yang On Aug. 1, 2012, 9:14 p.m., Venka

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6470/ --- (Updated Aug. 10, 2012, 8:29 p.m.) Review request for cloudstack. Changes

Re: Build systems [was RE: [DISCUSS] Binaries (jars) in our source tree/source releases.]

2012-08-10 Thread Robert Schweikert
On 08/10/2012 03:52 PM, Ewan Mellor wrote: -Original Message- From: Robert Schweikert [mailto:rjsch...@suse.com] Sent: 10 August 2012 05:35 To: cloudstack-dev@incubator.apache.org Subject: Re: Build systems [was RE: [DISCUSS] Binaries (jars) in our source tree/source releases.] On 08/09/

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread edison su
> On Aug. 10, 2012, 5:13 p.m., edison su wrote: > > raw2qcow2 is missing? Please resend the patch ASAP, the 4.0 will be > > branched. > > Marcus Sorensen wrote: > It's not necessary at this point. it's basically a hook that will allow > us to do something smarter than a qemu-img convert (s

RE: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread Ewan Mellor
> -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: 10 August 2012 12:56 > To: cloudstack-dev@incubator.apache.org > Cc: Ewan Mellor > Subject: Re: [ASFCS40] CloudStack 4.0 release plan > > > > > The only exception I would make to the "everything in 4.0" rule is for >

Re: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread David Nalley
> > The only exception I would make to the "everything in 4.0" rule is for > documentation. I don't see any value in branching the docs, and I want to > make sure that we can keep updating the docs at a fast pace even as we're > deliberately slowing down the rate of change on the code. For thi

RE: Build systems [was RE: [DISCUSS] Binaries (jars) in our source tree/source releases.]

2012-08-10 Thread Ewan Mellor
> -Original Message- > From: Robert Schweikert [mailto:rjsch...@suse.com] > Sent: 10 August 2012 05:35 > To: cloudstack-dev@incubator.apache.org > Subject: Re: Build systems [was RE: [DISCUSS] Binaries (jars) in our source > tree/source releases.] > > On 08/09/2012 09:06 PM, David Nalley w

RE: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread Ewan Mellor
> -Original Message- > > [Snip] > > +1, from monday on we'll have a 4.0 branch. > > That means however that you have to submit bugs fixes into master and > 4.0.x, right? Yes, that's right. All changes should go into master, and anything that we want for 4.0 should go into the release b

Re: iptonetworklist, networkids

2012-08-10 Thread Marcus Sorensen
I should mention that if I remove 'ipaddress' from the networkids version, then it works. That's the only thing that works, though. On Fri, Aug 10, 2012 at 1:24 PM, Marcus Sorensen wrote: > Hi all, > I'm testing the ability to specify an IP address to use, and have > run into a few issues. I'm

RE: [ASF40] License header update for Friday August 10

2012-08-10 Thread Ewan Mellor
> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > > [Snip] > > > > > At present it isn't, (Xenserverjava is copyleft) and no one from > > upstream XenServer is answering my emails regarding the status of > > their proposed relicensing. > > > > --David > > > >

Re: License header update for Wednesday August 8

2012-08-10 Thread Chip Childers
Can you write up the instructions and put it on the wiki? We can add it to the other "optional" feature instructions, once we have a place for it. - chip Sent from my iPhone. On Aug 10, 2012, at 1:34 PM, Frank Zhang wrote: > Hi Chip: >I have confirmed that we could not include these three

Re: [ASF40] License header update for Friday August 10

2012-08-10 Thread Chip Childers
On Aug 10, 2012, at 3:04 PM, David Nalley wrote: > On Fri, Aug 10, 2012 at 12:01 PM, Alex Huang wrote: >> >> >>> -Original Message- >>> From: David Nalley [mailto:da...@gnsa.us] >>> Sent: Friday, August 10, 2012 7:12 AM >>> To: cloudstack-dev@incubator.apache.org >>> Cc: Chip Childers (c

iptonetworklist, networkids

2012-08-10 Thread Marcus Sorensen
Hi all, I'm testing the ability to specify an IP address to use, and have run into a few issues. I'm running 3.0.2 off of the website. If I use iptonetworklist, I never even get the network I want. It creates a new private source nat network or uses the default one currently existing for the ac

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread Marcus Sorensen
> On Aug. 10, 2012, 5:13 p.m., edison su wrote: > > raw2qcow2 is missing? Please resend the patch ASAP, the 4.0 will be > > branched. It's not necessary at this point. it's basically a hook that will allow us to do something smarter than a qemu-img convert (say fill the source raw image empty

Re: Review Request: Introduce Vif Driver in KVM

2012-08-10 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review10141 --- Ship it! Ship It! - edison su On Aug. 6, 2012, 1:39 a.m., Tomoe S

Re: [ASF40] License header update for Friday August 10

2012-08-10 Thread David Nalley
On Fri, Aug 10, 2012 at 12:01 PM, Alex Huang wrote: > > >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> Sent: Friday, August 10, 2012 7:12 AM >> To: cloudstack-dev@incubator.apache.org >> Cc: Chip Childers (chip.child...@sungard.com); Ewan Mellor; Alex Huang >> Subjec

RE: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

2012-08-10 Thread Krishna Sadasivam
I will try using org.apache.commons.codec.binary.Base64 and submit a patch. Thanks, Krishna -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Friday, August 10, 2012 7:29 AM To: cloudstack-dev@incubator.apache.org Cc: Krishna Sadasivam Subject: Re: Review Re

Re: Review Request: Add initial support for Caringo's CAStor object storage as the S3 backend.

2012-08-10 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6473/#review10136 --- CAStorSDK.jar and jmdns-2.1.jar are missing, seems the patch send to

RE: Networking question

2012-08-10 Thread Will Chan
> -Original Message- > From: mpat...@inforelay.com [mailto:mpat...@inforelay.com] > Sent: Thursday, August 09, 2012 6:05 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Networking question > > > In basic mode, security groups are used for segregation but VMs are > > only allowe

asf/vpc branch merge

2012-08-10 Thread Alena Prokharchyk
Considering that there is a code freeze happening soon, and as the main part for VPC feature development is complete + the VPC code has been well tested by cloudStack QA engineers, it's time to discuss merging the asf/vpc branch into asf/master. At this point its too hard to break it to several co

RE: License header update for Wednesday August 8

2012-08-10 Thread Frank Zhang
Hi Chip: I have confirmed that we could not include these three patches in ASF CloudStack as they are for OVM agent code which is under GPL. I would remove them from ASF repo and add some notice in README or whatever to notice user to download them on demand. Thank you >

Re: Review Request: Fix the path for the API server endpoint.

2012-08-10 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6513/#review10133 --- Ship it! Ship It! - edison su On Aug. 10, 2012, 9:04 a.m., Tomoe

Re: Review Request: Adds CLVM as an option for primary storage

2012-08-10 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6470/#review10131 --- raw2qcow2 is missing? Please resend the patch ASAP, the 4.0 will be b

RE: [ASF40] License header update for Friday August 10

2012-08-10 Thread Alex Huang
> -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Friday, August 10, 2012 7:12 AM > To: cloudstack-dev@incubator.apache.org > Cc: Chip Childers (chip.child...@sungard.com); Ewan Mellor; Alex Huang > Subject: Re: [ASF40] License header update for Friday August 10 >

Re: [DISCUSS] cloudstack.org emails

2012-08-10 Thread Joe Brockmeier
On Thu, Aug 09, 2012 at 06:59:57PM -0400, David Nalley wrote: > The options I see are: > > 1. Discontinue all cloudstack.org email service. > 2. Provide only official - project specific emails aliases (think > webmaster@, security@, etc.) > 3. Provide both official project emails as well as commit

Re: Review Request: Add license headers to n-named files, fix DTDs, etc.

2012-08-10 Thread Joe Brockmeier
On Fri, Aug 10, 2012 at 09:12:03AM -0400, Chip Childers wrote: > Applied to master. Thanks! > > Can you please close the review Joe? Yep, done. Thanks! Should have all the remaining files done by the end of the weekend. -- Joe Brockmeier http://dissociatedpress.net/ Twitter: @jzb

Re: [ASFCS40] CloudStack 4.0 release plan

2012-08-10 Thread John Kinsella
On Aug 10, 2012, at 1:19 AM, Wido den Hollander wrote: > That means however that you have to submit bugs fixes into master and 4.0.x, > right? yes

Re: Wiki Migration to cwiki.a.o (was Re: the difference of 2 wikies)

2012-08-10 Thread Daniel Kulp
On Aug 9, 2012, at 7:53 PM, Brett Porter wrote: > > On 10/08/2012, at 12:53 AM, Prasanna Santhanam > wrote: > >> >> There are no issues with the apache confluence. Probably better than >> wiki.cloudstack because it still does wiki markup rather than just >> rich text edits. Pages might look

Re: [RFC] CloudStack Architectural Refactor

2012-08-10 Thread Tomoe Sugihara
Hi, Sorry for commenting to this thread during the busiest time right before the release, But I'd like to add my thoughts especially on networking part while my memory is fresh since I started working on integration our networking technology from Midokura to CS a couple of weeks ago. I'm still new

Re: [DISCUSS] cloudstack.org emails

2012-08-10 Thread Daniel Kulp
On Aug 10, 2012, at 8:08 AM, Brett Porter wrote: > > On 10/08/2012, at 6:33 PM, Wido den Hollander wrote: > >> I can think of a legitimate reason for having webmaster@ and security@, but >> where do we forward them? What do we do with them if the people who it gets >> forwarded to are on va

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

2012-08-10 Thread Chip Childers
Yes, Krishna, can you please use the Base64 class that's available in deps/cloud-commons-codec-1.5.jar ? org.apache.commons.codec.binary.Base64 -chip On Fri, Aug 10, 2012 at 10:18 AM, Murali Reddy wrote: > On 09/08/12 5:01 AM, "Krishna Sadasivam" wrote: > >> >>plugins/network-elements/brocade

Re: [DOCS] Indentation

2012-08-10 Thread Joe Brockmeier
On Fri, Aug 10, 2012 at 11:59:32AM +0200, Wido den Hollander wrote: > Hi, > > Most of the documentation (/docs) currently uses tabs instead of 4 spaces. > > Do we want to use tabs or 4 spaces here? 4 spaces, preferably. -- Joe Brockmeier http://dissociatedpress.net/ Twitter: @jzb

Re: Review Request: Plugin for enabling Brocade as external load balancing service provider in CloudStack

2012-08-10 Thread Murali Reddy
On 09/08/12 5:01 AM, "Krishna Sadasivam" wrote: > >plugins/network-elements/brocade/test/com/cloud/network/element/Base64.jav >a PRE-CREATION Should Base64.java be of concern from ASF license perspective? I think Alex removed it [1] from the repo and this patch will re-introduce if it goes to

Re: [Discuss] Unit test style

2012-08-10 Thread Mice Xia
Alex, The reasons as far as I can tell: ConfigurationManagerImpl is the class under test. Unfortunately it depends on a dozon of DAOs/managers, which are not added as Mocks but real impls and they have further cascading dependencies. Currently not all of required dependencies are added to mock

Re: [ASF40] License header update for Friday August 10

2012-08-10 Thread David Nalley
> For XenServerJava, my suggestion is this. The reason why we modify it is to > put in client timeouts so that CloudStack is decoupled from Xapi when Xapi > behaves badly. For normal operations, it's not necessary. We should just > remove the directory and use the one from XenServer and force

Re: [ASF40] License header update for Friday August 10

2012-08-10 Thread Chip Childers
On Fri, Aug 10, 2012 at 9:52 AM, Alex Huang wrote: >> >> So question on that. If someone edits the project's classpath in Eclipse, >> does >> that file get re-generated? Or does it simply modify the file as-is? If it >> gets >> re-generated, then I think we should simply consider those files

RE: [DISCUSS] Binaries (jars) in our source tree/source releases.

2012-08-10 Thread Hugo Trippaers
Heya, I've been toying a bit with gradle. I've created a new branch "gradle", with just two extra file build.gradle and settings.gradle. So far I've been able to configure gradle to load some of the dependencies from mavenCentral and most of the java code now compiles using the gradle build. P

Review Request: Bugfix for CS-14926

2012-08-10 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6523/ --- Review request for cloudstack and Nitin Mehta. Description --- Bugfix:

RE: [ASF40] License header update for Friday August 10

2012-08-10 Thread Alex Huang
> > So question on that. If someone edits the project's classpath in Eclipse, > does > that file get re-generated? Or does it simply modify the file as-is? If it > gets > re-generated, then I think we should simply consider those files to be > "accepted exceptions". If it modifies the file a

Re: [ASF40] License header update for Friday August 10

2012-08-10 Thread Chip Childers
On Fri, Aug 10, 2012 at 9:25 AM, Alex Huang wrote: > Chip, > > I checked in my two changes. > > 1. Removed Base64.java from test directory. > 2. Added the license back in the two classpath files. Thanks! > I do have one concern about license in the .classpath. It's not urgent but > maybe we ca

RE: About @author tags

2012-08-10 Thread Alex Huang
+1 I always remove it anyways so no one can blame me for bad code. :P --Alex > -Original Message- > From: Mice Xia [mailto:mice_...@tcloudcomputing.com] > Sent: Friday, August 10, 2012 6:24 AM > To: cloudstack-dev@incubator.apache.org > Subject: About @author tags > > Hi, All > > I w

RE: [Discuss] Unit test style

2012-08-10 Thread Alex Huang
Mice, Will try to get back to you in depth on this email this weekend. Can you provide more detail about why ResourceManagerTest failed? As for Mockito, I'm the one who suggested to remove it for the 4.0 release because no one was using it. It's MIT licensed. Maybe others can comment on whe

RE: [ASF40] License header update for Friday August 10

2012-08-10 Thread Alex Huang
Chip, I checked in my two changes. 1. Removed Base64.java from test directory. 2. Added the license back in the two classpath files. I do have one concern about license in the .classpath. It's not urgent but maybe we can address it post 4.0. These .classpath files are eclipse files and they

About @author tags

2012-08-10 Thread Mice Xia
Hi, All I want to remind that many source files (hundreds) in the repo containing @author tags, while a certain ASF projects explicitly recommended against this tag and asked committers/contributors to remove them. For CloudStack, no matter what the policy is, we need to add it in document 'cod

Re: [PROPOSAL] Event notification framework

2012-08-10 Thread Chip Childers
On Thu, Aug 9, 2012 at 10:45 AM, Murali Reddy wrote: > > In continuation to the disucssion [1] to have publisher/subscriber event > notification mechanism in CloudStack I am proposing a framework for > delivering events to the in-process subscribers. This is slightly > in-contrast to the earlier d

Re: [DISCUSS] VMware support was: Re: vijava - some additional thoughts

2012-08-10 Thread David Nalley
On Fri, Aug 10, 2012 at 6:51 AM, Tamas Monos wrote: > Hi, > > Do vmware libraries really need to be removed and re-added manually? > Could ASF not acquire permission from Vmware to redistribute their freely > available sdk for this project? > This 4.0 would be the first big ASF release and you wa

Re: Review Request: Add license headers to n-named files, fix DTDs, etc.

2012-08-10 Thread Chip Childers
Applied to master. Thanks! Can you please close the review Joe? -chip On Thu, Aug 9, 2012 at 5:21 PM, Joe Brockmeier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6500/ >

Re: Review Request: Add license headers to n-named files, fix DTDs, etc.

2012-08-10 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6500/#review10115 --- Ship it! Ship It! - Chip Childers On Aug. 9, 2012, 9:21 p.m., Joe

[ASF40] License header update for Friday August 10

2012-08-10 Thread Chip Childers
Specific individuals that have open questions to them below: Prachi, Frank, Ewan Updated RAT report: https://github.com/chipchilders/asf_cloudstack_RAT_results/blob/master/_all.txt?raw=true Outstanding Issues: EC2 WSDL files: Prachi, can you remove these 2 as well? incubator-cloudstac

Re: [DOCS] Indentation

2012-08-10 Thread David Nalley
On Fri, Aug 10, 2012 at 5:59 AM, Wido den Hollander wrote: > Hi, > > Most of the documentation (/docs) currently uses tabs instead of 4 spaces. > > Do we want to use tabs or 4 spaces here? > > Wido I personally like spaces, and have been trying to clean things up as I go, particularly in stuff I

Re: Build systems [was RE: [DISCUSS] Binaries (jars) in our source tree/source releases.]

2012-08-10 Thread Robert Schweikert
On 08/09/2012 09:06 PM, David Nalley wrote: On Thu, Aug 9, 2012 at 8:47 PM, Ewan Mellor wrote: -Original Message- From: Robert Schweikert [mailto:rjsch...@suse.com] [Snip] * We want to be able to package CloudStack in RPMs and .debs that correctly depend on packages available on the

Re: [DISCUSS] cloudstack.org emails

2012-08-10 Thread Brett Porter
On 10/08/2012, at 6:33 PM, Wido den Hollander wrote: > I can think of a legitimate reason for having webmaster@ and security@, but > where do we forward them? What do we do with them if the people who it gets > forwarded to are on vacation? > I don't know if webmaster would be useful any mor

RE: log rotation policy on VR

2012-08-10 Thread Saksham Srivastava
Virtual Router does not have CloudStack agent running on it, the logs on VR are not handled the way they are on other system VMs (i.e. using log4j) Currently running: logrotate -f -v /etc/logrotate.conf on the VR shows it does not handle /var/log/cloud.log To enable a sample logrotation add t

Re: [DOCS] Indentation

2012-08-10 Thread Rohit Yadav
Hi, On 10-Aug-2012, at 3:29 PM, Wido den Hollander wrote: > Hi, > > Most of the documentation (/docs) currently uses tabs instead of 4 spaces. > > Do we want to use tabs or 4 spaces here? Good point Wido! I was going to email about this earlier but thought no would care. So, we should follo

RE: [DISCUSS] VMware support was: Re: vijava - some additional thoughts

2012-08-10 Thread Tamas Monos
Hi, Do vmware libraries really need to be removed and re-added manually? Could ASF not acquire permission from Vmware to redistribute their freely available sdk for this project? This 4.0 would be the first big ASF release and you want to cripple vmware support? +1 to keep vmware support for 4.

Review Request: Fix CS-15603

2012-08-10 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6515/ --- Review request for cloudstack and Abhinandan Prateek. Description --- When

log rotation policy on VR

2012-08-10 Thread Sanjeev Neelarapu
Hi, It has been seen that logs on VR are not preserved. However /etc/logrotate.conf says it is daily. Please let me know the log rotation policy for /var/logs on VR. Thanks, Sanjeev

[DOCS] Indentation

2012-08-10 Thread Wido den Hollander
Hi, Most of the documentation (/docs) currently uses tabs instead of 4 spaces. Do we want to use tabs or 4 spaces here? Wido

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-10 Thread Koushik Das
> On Aug. 10, 2012, 8:58 a.m., Wido den Hollander wrote: > > It doesn't seem that complicated, but isn't this something we should > > develop in a feature branch? > > > > Currently there is also local storage support for KVM and it would be nice > > if this could be done for KVM as well. > >

[Discuss] Unit test style

2012-08-10 Thread Mice Xia
Hi, Folks I'm about to write some unit tests for what I have committed. However it seems a little bit heavy weight if I follow the guide http://wiki.cloudstack.org/display/COMM/Unit+Testing+101 1) About IoC, I had to inject all dependent DAOs/Managers for the class under test, even if I want t

Review Request: Fix the path for the API server endpoint.

2012-08-10 Thread Tomoe Sugihara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6513/ --- Review request for cloudstack. Description --- Fix the path for the API ser

  1   2   >