Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-25 Thread Wei ZHOU
I changed the patch to make it apply on cloudstack 4.0.1. It works well. Thanks for your good job. Wei 2013/1/30 Harikrishna Patnala > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9158

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-21 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/ --- (Updated Feb. 21, 2013, 9:21 a.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-20 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review16836 --- Ship it! Ship It! - Koushik Das On Feb. 18, 2013, 6:44 p.m., Hari

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-18 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/ --- (Updated Feb. 18, 2013, 6:44 p.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-15 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review16638 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-15 Thread Harikrishna Patnala
> On Feb. 15, 2013, 8:44 a.m., Koushik Das wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 4799 > > > > > > What if template is null? The null check that's happening in the 'else' > > case should be ma

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-15 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review16635 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-07 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/ --- (Updated Feb. 7, 2013, 11:32 a.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-06 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review16261 --- Your test file is giving an error on the review board. Can you please

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-05 Thread Harikrishna Patnala
> On Jan. 30, 2013, 1:22 p.m., Nitin Mehta wrote: > > Not able to upload diff cleanly because of some merge conflicts with the latest master. I will upload the new patch soon after resolving the conflicts. - Harikrishna --- This is an

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-02-01 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/ --- (Updated Feb. 1, 2013, 2:20 p.m.) Review request for cloudstack, Abhinandan Prat

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-01-31 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review15939 --- api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-01-31 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/ --- (Updated Jan. 31, 2013, 4:17 p.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-01-30 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review15853 --- api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java

Re: Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-01-30 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/#review15838 --- api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java

Review Request: CLOUDSTACK-667: VM's base image updation facility

2013-01-30 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9158/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description -