Re: [Cluster-devel] [PATCH] fs: gfs2: Adding new return type vm_fault_t

2018-04-16 Thread Dave Chinner
On Mon, Apr 16, 2018 at 11:20:59PM +0530, Souptick Joarder wrote: > > Hi, > > > > This patch is straightforward enough, but there are a lot of other > > file systems that need similar patches. Shouldn't you do one big > > patch set that fixes several file systems at once and run it through > >

Re: [Cluster-devel] [PATCH] fs: gfs2: Adding new return type vm_fault_t

2018-04-16 Thread Souptick Joarder
> Hi, > > This patch is straightforward enough, but there are a lot of other > file systems that need similar patches. Shouldn't you do one big > patch set that fixes several file systems at once and run it through > Viro's kernel or Linus's kernel or something? > Adding Viro and linux-fsdevel for

Re: [Cluster-devel] [PATCH] fs: gfs2: Adding new return type vm_fault_t

2018-04-16 Thread Bob Peterson
- Original Message - > Use new return type vm_fault_t for page_mkwrite > handler. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > fs/gfs2/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Cluster-devel] [PATCH] gfs2: Remove sdp->sd_jheightsize

2018-04-16 Thread Bob Peterson
- Original Message - > GFS2 keeps two arrarys in the superblock that define the maximum size of > an inode depending on the inode's height: sdp->sd_heightsize defines the > heights in units of sb->s_blocksize; sdp->sd_jheightsize defines them in > units of sb->s_blocksize - sizeof(struct

[Cluster-devel] [PATCH] mkfs.gfs2: Zero blocks in alignment gaps

2018-04-16 Thread Andrew Price
Stripe and bitmap alignment can leave small gaps between resource group spans, and between the superblock and the first resource group. Zero out those blocks so that we don't leave stale data in unused space. Signed-off-by: Andrew Price --- gfs2/libgfs2/libgfs2.h | 1 +