On 19/10/2023 06:27, Julia Lawall wrote:
-- Forwarded message --
Date: Thu, 19 Oct 2023 05:56:44 +0800
From: kernel test robot
To: oe-kbu...@lists.linux.dev
Cc: l...@intel.com, Julia Lawall
Subject: [gfs2:extents 14/14] fs/gfs2/extents.c:123:23-27: WARNING use
Hi all,
Following on from the previous notices about the new list replacing
cluster-devel, this list will shortly be discontinued.
The list archives have been preserved at
https://lore.kernel.org/cluster-devel/
If you haven't already done so, please subscribe to the new list for
gfs2 and
Hi all,
For those of you still reading cluster-devel, please be aware that gfs2
and dlm development have now moved to g...@lists.linux.dev
Please subscribe to the new list to avoid missing new developments, by
sending a message to:
gfs2+subscr...@lists.linux.dev
The new list is hosted
On 29/08/2023 18:07, Andrew Price wrote:
Hi all,
As cluster-devel is now only used for gfs2 and dlm development, we will
be moving them to a new list hosted by kernel.org alongside other Linux
subsystems' lists. The new list is g...@lists.linux.dev and it will be
used for both gfs2 and dlm
Signed-off-by: Andrew Price
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4b8d634f3a4e..caae31fb9741 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8725,7 +8725,7 @@ F:scripts/get_maintainer.pl
GFS2 FILE SYSTEM
M
The new gfs2@ list will also be used for dlm development.
Signed-off-by: Andrew Price
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index caae31fb9741..946fcf6c8d77 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6093,7 +6093,7 @@ F
Hi all,
As cluster-devel is now only used for gfs2 and dlm development, we will
be moving them to a new list hosted by kernel.org alongside other Linux
subsystems' lists. The new list is g...@lists.linux.dev and it will be
used for both gfs2 and dlm development.
The Linux MAINTAINERS file
On 12/06/2023 17:33, Andreas Gruenbacher wrote:
So far, at mount time, gfs2 would take the freeze glock in shared mode
and then immediately drop it again, turning it into a cached glock that
can be reclaimed at any time. To freeze the filesystem cluster-wide,
the node initiating the freeze
-off-by: Andrew Price
---
gfs2/fsck/Makefile.am | 5 -
gfs2/fsck/initialize.c | 30 ++
tests/Makefile.am | 3 ++-
tests/atlocal.in | 1 +
tests/fsck.at | 7 +++
tests/pv_sig.xxd | 12
6 files changed, 56 insertions
Hi Bob,
On 04/05/2023 18:43, Bob Peterson wrote:
Before this patch function gfs2_dinode_dealloc would abort if it got a
bad return code from gfs2_rindex_update. The problem is that it left the
dinode in the unlinked (not free) state, which meant subsequent fsck
would clean it up and flag an
changes since 3.5.0:
Andrew Price (9):
Update version for development
gfs2_edit: Fix savemeta test failures in 32-bit environments
gfs2_jadd: Fix format string warnings on 32-bit
libgfs2: Fix strict-aliasing warning in lgfs2_rgrp_bitbuf_alloc
gfs2_convert: Clean up strict
Replace the 3-item array with three variables for readability.
Signed-off-by: Andrew Price
---
fs/gfs2/inode.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9850267b9951..17c994a0c0d0 100644
--- a/fs/gfs2
error code for
attempts to link a deleted inode (ref: link(2)).
If we support O_TMPFILE in future the check will need to be updated with
an exception for inodes flagged I_LINKABLE so sorting out this
duplication now will make it a slightly cleaner change.
Signed-off-by: Andrew Price
---
fs/gfs2/i
Replace the 2-item array with two variables for readability.
Signed-off-by: Andrew Price
---
fs/gfs2/inode.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 79eef9a0ebfc..9850267b9951 100644
--- a/fs/gfs2/inode.c
Some trivial cleanups from my O_TMPFILE branch. That work isn't ready
yet but there was no reason not to send these patches.
Andy
Andrew Price (3):
gfs2: Remove duplicate i_nlink check from gfs2_link()
gfs2: Remove ghs[] from gfs2_link
gfs2: Remove ghs[] from gfs2_unlink
fs/gfs2/inode.c
On 13/02/2023 09:58, Andrew Price wrote:
On 11/02/2023 17:16, Valentin Vidić wrote:
On Thu, Feb 09, 2023 at 01:12:58PM +, Andrew Price wrote:
gfs2-utils contains the tools needed to create, check, modify and
inspect
gfs2 filesystems along with support scripts needed on every gfs2 cluster
On 11/02/2023 17:16, Valentin Vidić wrote:
On Thu, Feb 09, 2023 at 01:12:58PM +, Andrew Price wrote:
gfs2-utils contains the tools needed to create, check, modify and inspect
gfs2 filesystems along with support scripts needed on every gfs2 cluster
node.
Hi,
Some tests seem to be failing
some endianness annotations
fsck.gfs2: Factor out error handling in metawalk_check_data
fsck.gfs2: Convert enum values to upper-case
Andrew Price (255):
Update version string for dev
gfs2_jadd: Use fallocate to preallocate journals
gfs2_jadd: Don't fsync after each
This set is mainly cleanups but patches 5 and 6 are small fixes for
fsck.gfs2 which I would like to draw attention to.
PR is https://pagure.io/gfs2-utils/pull-request/14 awaiting CI testing
should you prefer to comment there.
Andy
Andrew Price (6):
libgfs2: Return the inode from lgfs2_lookupi
It always points to 'dentry' so it can be replaced in all uses.
Signed-off-by: Andrew Price
---
gfs2/fsck/pass2.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/gfs2/fsck/pass2.c b/gfs2/fsck/pass2.c
index 0c2e0146..002bf2cb 100644
--- a/gfs2/fsck/pass2.c
+++ b
fsck.gfs2 can leave i_blocks too large when it removes empty leaf
blocks, so decrease the count when freeing them.
Signed-off-by: Andrew Price
---
gfs2/fsck/pass2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gfs2/fsck/pass2.c b/gfs2/fsck/pass2.c
index 5327ee43..71459978 100644
'dent' points to the on-disk data that 'dentry' was converted from, so
this comparison always evaluates to true. Compare to 'entry' instead.
Signed-off-by: Andrew Price
---
gfs2/fsck/pass2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gfs2/fsck/pass2.c b/gfs2/fsck/pass2
Instead of returning a -errno with the inode set via a passed in
pointer, return the inode and use errno. This is more consistent and
simplifies some calling code.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 7 +++
gfs2/edit/hexedit.c | 2 +-
gfs2/fsck
Move the lookup for an existing inode to lgfs2_createi itself and then
create the inode in __createi (renamed to do_createi) unconditionally.
Signed-off-by: Andrew Price
---
gfs2/libgfs2/fs_ops.c | 80 ---
1 file changed, 45 insertions(+), 35 deletions
The one caller sets sdp->gfs1 and modifies the mode itself so we can use
sdp->gfs1 in __createi() and update the caller to use lgfs2_createi()
instead.
Signed-off-by: Andrew Price
---
gfs2/fsck/lost_n_found.c | 6 +-
gfs2/libgfs2/fs_ops.c| 19 ++-
gfs2/libgfs2/lib
Add an extended option to allow the GFS2_DIF_INHERIT_JDATA flag to be
set on the root dinode at mkfs time.
This option is only to be used for testing so it is not documented.
Signed-off-by: Andrew Price
---
gfs2/mkfs/main_mkfs.c | 27 +++
tests/mkfs.at | 16
On 22/10/2022 12:11, syzbot wrote:
syzbot has found a reproducer for the following issue on:
HEAD commit:440b7895c990 Merge tag 'mm-hotfixes-stable-2022-10-20' of ..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=128087a488
kernel config:
On 13/10/2022 14:31, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:493ffd6605b2 Merge tag 'ucount-rlimits-cleanups-for-v5.19'..
$ git describe --contains 493ffd6605b2
next-20221011~172
git tree: upstream
It would be useful to know the precise git tree.
I've pushed this patch to my git repo:
git fetch https://gitlab.com/andyprice/linux.git bsize_shift_check
git show FETCH_HEAD
Andy
On 17/08/2022 13:22, Andrew Price wrote:
Fuzzers like to scribble over sb_bsize_shift but in reality it's very
unlikely that this field would be corrupted
On 24/08/2022 21:08, Wolfram Sang wrote:
Hi Andy.
- strlcpy(sdp->sd_proto_name, proto, GFS2_FSNAME_LEN);
- strlcpy(sdp->sd_table_name, table, GFS2_FSNAME_LEN);
+ strscpy(sdp->sd_proto_name, proto, GFS2_FSNAME_LEN);
+ strscpy(sdp->sd_table_name, table, GFS2_FSNAME_LEN);
On 18/08/2022 22:01, Wolfram Sang wrote:
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.
Link:
gned-off-by: Andrew Price
---
fs/gfs2/ops_fstype.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 549879929c84..692e27f8f563 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -178,7 +178,10 @@ static int gfs2_check_s
Allow the user to specify the filesystem UUID, similar to mkfs.ext4's -U
option.
Signed-off-by: Andrew Price
---
gfs2/man/mkfs.gfs2.8 | 6 ++
gfs2/mkfs/main_mkfs.c | 19 +--
tests/mkfs.at | 10 ++
3 files changed, 33 insertions(+), 2 deletions(-)
diff
On 21/06/2022 10:14, Christoph Hellwig wrote:
I'm felling a little stupid, but in the past after a
mkfs.gfs2 -O -p lock_nolock
I could just mount the created file system locally.
On current mainline that does not seem to work any more, what am I
missing?
I can't reproduce the problem on
On 29/04/2022 15:08, Andrew Price wrote:
On 19/04/2022 16:49, Andrew Price wrote:
On 05/04/2022 13:08, Andrew Price wrote:
The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to
fs block size") fixes was a little confusing as the user saw
"Input/output erro
On 19/04/2022 16:49, Andrew Price wrote:
On 05/04/2022 13:08, Andrew Price wrote:
The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to
fs block size") fixes was a little confusing as the user saw
"Input/output error" which masked the -EINVAL that sb_issu
On 05/04/2022 13:08, Andrew Price wrote:
The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to
fs block size") fixes was a little confusing as the user saw
"Input/output error" which masked the -EINVAL that sb_issue_discard()
returned.
sb_issue_discard()
option
switches off). Presumably that's why it was ok to just return -EIO in
the past, before FITRIM was implemented.
Tested with xfstests.
Signed-off-by: Andrew Price
---
I don't see this in for-next yet so I've updated the commit log to include more
details.
fs/gfs2/rgrp.c | 4 ++--
1 file changed
sb_issue_discard() can fail for various reasons, so we should return its
return value from gfs2_rgrp_send_discards() to avoid reporting them all
as IO errors.
Signed-off-by: Andrew Price
---
(As far as I can tell there are no limitations on which errno's can be set by
ioctl(FITRIM) )
fs
On 22/03/2022 19:05, Andrew Price wrote:
Per fstrim(8) we must round up the minlen argument to the fs block size.
The current calculation doesn't take into account devices that have a
discard granularity and requested minlen less than 1 fs block, so the
value can get shifted away to zero
ing to the device's
discard granularity and shifting to fs blocks.
Fixes: 076f0faa764ab ("GFS2: Fix FITRIM argument handling")
Signed-off-by: Andrew Price
---
fs/gfs2/rgrp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index
Rename to struct lgfs2_rgrp_tree.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 22 +--
gfs2/edit/extended.c| 2 +-
gfs2/edit/hexedit.c | 24 ++---
gfs2/edit/journal.c | 8 +++
gfs2/edit/savemeta.c| 8
These functions are actually defined in fsck.gfs2 code and can be made
static.
Signed-off-by: Andrew Price
---
gfs2/fsck/fs_recovery.c | 14 +++---
gfs2/libgfs2/libgfs2.h | 4
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/gfs2/fsck/fs_recovery.c b/gfs2/fsck
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/edit/hexedit.c| 2 +-
gfs2/fsck/rgrepair.c | 2 +-
gfs2/libgfs2/device_geometry.c | 2 +-
gfs2/libgfs2/gfs2l.c | 2 +-
gfs2/libgfs2/libgfs2.h | 2 +-
gfs2/mkfs
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 2 +-
gfs2/edit/hexedit.c | 2 +-
gfs2/edit/savemeta.c| 2 +-
gfs2/fsck/initialize.c | 6 +++---
gfs2/fsck/rgrepair.c| 2 +-
gfs2/libgfs2/gfs2l.c
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 28 ++--
gfs2/edit/hexedit.c | 6 ++---
gfs2/edit/savemeta.c| 2 +-
gfs2/fsck/fs_recovery.c | 10 +++
gfs2/fsck/initialize.c | 24
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 76 +++
gfs2/edit/extended.c | 26 ++---
gfs2/edit/gfs2hex.c | 4 +-
gfs2/edit/hexedit.c | 48 +-
gfs2/edit/journal.c
Use the LGFS2_ prefix for preprocessor #defines.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 12 ++--
gfs2/edit/hexedit.c | 12 ++--
gfs2/fsck/fs_recovery.c | 4 ++--
gfs2/fsck/initialize.c | 20 ++--
gfs2/fsck/rgrepair.c
Rename to struct lgfs2_sbd.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c| 76 +++---
gfs2/edit/gfs2hex.c| 2 +-
gfs2/edit/hexedit.c| 2 +-
gfs2/edit/hexedit.h| 2 +-
gfs2/edit/journal.c| 2 +-
gfs2
Rename to struct lgfs2_device.
Signed-off-by: Andrew Price
---
gfs2/fsck/rgrepair.c | 4 ++--
gfs2/libgfs2/device_geometry.c | 2 +-
gfs2/libgfs2/libgfs2.h | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gfs2/fsck/rgrepair.c b/gfs2/fsck/rgrepair.c
Rename to struct lgfs2_bitmap.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 6 +++---
gfs2/edit/hexedit.c | 2 +-
gfs2/fsck/pass5.c | 2 +-
gfs2/libgfs2/fs_bits.c | 4 ++--
gfs2/libgfs2/fs_ops.c | 2 +-
gfs2/libgfs2/libgfs2.h | 4
Rename to struct lgfs2_meta_dir.
Signed-off-by: Andrew Price
---
gfs2/fsck/initialize.c | 2 +-
gfs2/libgfs2/libgfs2.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gfs2/fsck/initialize.c b/gfs2/fsck/initialize.c
index 2bde52ab..ec9a8eef 100644
--- a/gfs2/fsck
Rename to struct lgfs2_metapath.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 14 +++---
gfs2/edit/extended.c| 4 ++--
gfs2/edit/hexedit.c | 4 ++--
gfs2/edit/hexedit.h | 4 ++--
gfs2/libgfs2/fs_ops.c | 12 ++--
gfs2/libgfs2/gfs1
Rename to struct lgfs2_inode.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 46 ++--
gfs2/edit/extended.c | 14 ++--
gfs2/edit/hexedit.c | 4 +-
gfs2/edit/journal.c | 8 +--
gfs2/edit/savemeta.c | 4 +-
gfs2/fsck
Rename to struct lgfs2_buffer_head.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 30 +++---
gfs2/edit/extended.c | 2 +-
gfs2/edit/gfs2hex.c | 2 +-
gfs2/edit/hexedit.c | 20 +-
gfs2/edit/journal.c | 14 +++
gfs2
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/fsck/fs_recovery.c | 22 +++---
gfs2/libgfs2/libgfs2.h | 4 ++--
gfs2/libgfs2/recovery.c | 8
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/gfs2/fsck
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 10 +++---
gfs2/edit/hexedit.c | 60 +-
gfs2/edit/journal.c | 2 +-
gfs2/edit/savemeta.c| 2 +-
gfs2/fsck/fs_recovery.c
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/fsck/pass2.c | 2 +-
gfs2/libgfs2/fs_ops.c | 12 ++--
gfs2/libgfs2/gfs2_disk_hash.c | 5 ++---
gfs2/libgfs2/libgfs2.h| 7 +++
gfs2/libgfs2/rgrp.c | 4
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/fsck/pass1.c | 2 +-
gfs2/fsck/pass2.c | 2 +-
gfs2/fsck/util.h | 2 +-
gfs2/libgfs2/fs_ops.c | 12 ++--
gfs2/libgfs2/gfs1.c| 16
gfs2/libgfs2/libgfs2.h | 8
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 12 ++--
gfs2/edit/hexedit.c | 2 +-
gfs2/fsck/initialize.c | 2 +-
gfs2/libgfs2/check_rgrp.c | 2 +-
gfs2/libgfs2/gfs2l.c| 2 +-
gfs2/libgfs2
Use the lgfs2_ prefix in libgfs2 interface names.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 2 +-
gfs2/edit/hexedit.c | 2 +-
gfs2/edit/savemeta.c| 4 ++--
gfs2/fsck/metawalk.c| 2 +-
gfs2/fsck/pass5.c | 4 ++--
gfs2/fsck/rgrepair.c
but it pays off a lot of technical
debt and I think it's worth getting it out of the way in one go. Many of the
changes were scripted but each patch was reviewed by eye and tested with 'make
check'.
Andrew Price (21):
libgfs2: Namespace improvements - structures.c
libgfs2: Namespace improvements
or made static.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 13 ---
gfs2/edit/extended.c | 7 --
gfs2/edit/gfs2hex.c | 135 ---
gfs2/edit/hexedit.c | 33 --
gfs2/edit/hexedit.h | 4 +-
gfs2/edit/struct_print.c | 200
h
requires but that can be removed next.
Signed-off-by: Andrew Price
---
gfs2/edit/Makefile.am| 2 +
gfs2/edit/extended.c | 11 ++-
gfs2/edit/gfs2hex.c | 33 ---
gfs2/edit/hexedit.c | 9 +-
gfs2/edit/struct_print.c | 206 +++
The cfg_debug bits are no longer used.
Signed-off-by: Andrew Price
---
gfs2/libgfs2/Makefile.am | 2 --
gfs2/libgfs2/checks.am | 1 -
gfs2/libgfs2/config.c | 9 -
gfs2/libgfs2/config.h | 6 --
gfs2/libgfs2/device_geometry.c | 1 -
gfs2/libgfs2/libgfs2
Signed-off-by: Andrew Price
---
gfs2/libgfs2/structures.c | 3 ---
gfs2/mkfs/main_mkfs.c | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gfs2/libgfs2/structures.c b/gfs2/libgfs2/structures.c
index d4a08c43..9b78ed51 100644
--- a/gfs2/libgfs2/structures.c
+++ b/gfs2
This block never gets executed as the only utils that enable cfg_debug
don't call the function.
Signed-off-by: Andrew Price
---
gfs2/libgfs2/device_geometry.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/gfs2/libgfs2/device_geometry.c b/gfs2/libgfs2/device_geometry.c
index 4a0aeab2
Allow the caller to provide a pointer to a statfs change structure so
that it can do its own debug message printing. This is only used by
mkfs.gfs2.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 2 +-
gfs2/fsck/initialize.c | 2 +-
gfs2/fsck/main.c| 2 +-
gfs2
mkfs.gfs2 is the only place it could ever get printed so move it there
instead.
Signed-off-by: Andrew Price
---
gfs2/libgfs2/structures.c | 4
gfs2/mkfs/main_mkfs.c | 4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gfs2/libgfs2/structures.c b/gfs2/libgfs2
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
the inodes in all utilities. Move
build_per_node() down into the utils and add error reporting to match.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c | 36 +++
gfs2/fsck/fsck.h| 1 +
gfs2/fsck/pass1.c | 36
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
fsck.gfs2 is the only remaining util that builds journals this way so
move it out of libgfs2. The debug printfs can be removed because
fsck.gfs2 doesn't enable libgfs2's cfg_debug.
Signed-off-by: Andrew Price
---
gfs2/fsck/fs_recovery.c | 21 +
gfs2/fsck/fs_recovery.h
This allows the caller to call inode_put() when it's convenient and also
allows the debug message printing to be moved out of the function.
fsck.gfs2 passes the function by reference so it needs a shim until the
other builder functions can be given the same signature.
Signed-off-by: Andrew Price
Return the inode instead of freeing it and move the debug printfs out of
libgfs2.
Signed-off-by: Andrew Price
---
gfs2/libgfs2/libgfs2.h| 2 +-
gfs2/libgfs2/structures.c | 23 ---
gfs2/mkfs/main_mkfs.c | 27 ++-
3 files changed, 31 insertions
in
structures.c.
The overall result is more flexibility and control over the way the utils print
on-disk structures and improved error/debug messages. Test code is also tidied
up as we no longer have to define a print_it() in each of the tests.
Andrew Price (18):
libgfs2: Move debugging printf
mkfs.gfs2 is the only place it could ever get printed so move it there
instead.
Signed-off-by: Andrew Price
---
gfs2/libgfs2/structures.c | 4
gfs2/mkfs/main_mkfs.c | 4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gfs2/libgfs2/structures.c b/gfs2/libgfs2
On 04/01/2022 15:35, Andrew Price wrote:
Happy new year, all!
Just a heads-up that the main branch in gfs2-utils.git will be renamed
from master to main tomorrow (January 5). I will follow the procedure here:
https://wiki.clusterlabs.org/wiki/How_to_rename_git_default_branch
The wiki
Happy new year, all!
Just a heads-up that the main branch in gfs2-utils.git will be renamed
from master to main tomorrow (January 5). I will follow the procedure here:
https://wiki.clusterlabs.org/wiki/How_to_rename_git_default_branch
The wiki page also has a section on how to update your
Hi Bernd,
On 08/12/2021 16:50, Lentes, Bernd wrote:
Hi,
i hope this is the right place for asking about GFS2.
Yesterday one of my two nodes HA-cluster got slower and slower, until it was
fenced.
In /var/log/messages i found this message repeated often before the system got
slower:
- Restructure sentences to make gfs2_grow the subject instead of "you"
- Use more consistent formatting
- Remove some unnecessary technical details
- Move a sentence relating to the -T option to the options section
- List the lack of shrink support as a note instead of a bug
Signed-off-
Bump the size of the 'testvol' sparse file that the tests use to 20G.
The actual disk space used is more like 200M which should be fine for
build environments. The increased size allows more resource groups to be
created in tests that use a larger resource group size.
Signed-off-by: Andrew Price
Hi,
I've enabled the pull requests feature for gfs2-utils.git on
https://pagure.io/gfs2-utils after a contributor enquired about it. I
don't expect to receive many of them but the option is now there for
those who prefer it to emailing patches.
Cheers,
Andy
Use O_RDONLY when listing and O_RDWR|O_EXCL when modifying.
Also don't print the tunegfs2 version with -l output, improve open()
error reporting and add some more basic tunegfs2 tests.
Signed-off-by: Andrew Price
---
gfs2/tune/main.c | 12 ++--
tests/tune.at| 30
On 28/07/2021 21:32, Bob Peterson wrote:
On 7/28/21 1:28 PM, Andreas Gruenbacher wrote:
On Tue, Jul 27, 2021 at 7:37 PM Bob Peterson wrote:
Before this patch, gfs2 rejected mounts attempted with the usrquota,
grpquota, or prjquota mount options. That caused numerous xfstests tests
to fail.
,
from hexedit.c:16:
/usr/include/asm/elf.h:160:9: error: unknown type name ‘__vector128’
typedef __vector128 elf_vrreg_t;
asm/types.h is included in the original linux/types.h so this reduces
the difference (at the expense of portability).
Signed-off-by: Andrew Price
---
gfs2/include/linux
__force annotations to the conversion macros.
This clears up a handful of sparse warnings but the anti-pattern of
storing cpu-endian values in the on-disk structs is still common (see
libgfs2/ondisk.c), so there are still some to be resolved.
Signed-off-by: Andrew Price
---
gfs2/convert/gfs2_convert.c
On 20/04/2021 10:07, Andreas Gruenbacher wrote:
On Tue, Apr 20, 2021 at 10:34 AM Andrew Price wrote:
On 20/04/2021 07:00, Andreas Gruenbacher wrote:
On Mon, Apr 19, 2021 at 10:47 PM Andrew Price wrote:
On 19/04/2021 20:35, Andreas Gruenbacher wrote:
Andy,
On Mon, Apr 19, 2021 at 9:11 PM
On 20/04/2021 07:00, Andreas Gruenbacher wrote:
On Mon, Apr 19, 2021 at 10:47 PM Andrew Price wrote:
On 19/04/2021 20:35, Andreas Gruenbacher wrote:
Andy,
On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote:
diff --git a/gfs2/include/gfs2_ondisk.h b/gfs2/include/gfs2_ondisk.h
new file mode
On 19/04/2021 20:35, Andreas Gruenbacher wrote:
Andy,
On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote:
diff --git a/gfs2/include/gfs2_ondisk.h b/gfs2/include/gfs2_ondisk.h
new file mode 100644
index ..fc948f89
--- /dev/null
+++ b/gfs2/include/gfs2_ondisk.h
any reason why
Now that we have gfs2 structs defined in terms of standard userspace
types instead of kernel types we can use these defines from inttypes.h
to print their fields in a consistent way across architectures.
Fixes a number of -Wformat warnings on x86_64.
Signed-off-by: Andrew Price
---
gfs2/edit
Our own gfs2_ondisk.h has de_rahead and de_cookie so there's no need for
these conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 4
gfs2/edit/extended.c | 8 ++--
gfs2/libgfs2/meta.c | 8
gfs2/libgfs2/ondisk.c | 16
4 files changed, 2
Our own gfs2_ondisk.h has v2 log headers so there's no need for these
conditionals. There aren't any users of gfs2_log_header_v1_*() functions
so fold those into gfs2_log_header*().
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/libgfs2/libgfs2.h| 3 ---
gfs2
Our own gfs2_ondisk.h has the new rgrp fields so there's no need for
these conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/libgfs2/meta.c | 2 --
gfs2/libgfs2/ondisk.c | 8
gfs2/libgfs2/rgrp.c | 6 --
4 files changed, 18 deletions(-)
diff --git
types but keeps the bitwise
attribute tags that sparse uses.
Remove a bunch of unnecessary #include statements in the utils so that
linux/gfs2_ondisk.h is never included and (our) linux/types.h is only
ever included in libgfs2.h.
Signed-off-by: Andrew Price
---
configure.ac | 2
Our own gfs2_ondisk.h has leaf hints so there's no need for these
conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/edit/extended.c | 9 ++---
gfs2/libgfs2/fs_ops.c | 6 --
gfs2/libgfs2/ondisk.c | 10 --
4 files changed, 2 insertions(+), 25
1 - 100 of 771 matches
Mail list logo
