[Cluster-devel] [GFS2 PATCH] gfs2: Don't support fallocate on jdata files

2015-06-03 Thread Abhi Das
We cannot provide an efficient implementation due to the headers on the data blocks, so there doesn't seem much point in having it. Resolves: rhbz#1221331 Signed-off-by: Abhi Das --- fs/gfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Don't support fallocate on jdata files

2015-06-04 Thread Steven Whitehouse
Hi, Will glibc do the fallback path, or just return this as an error? I think thats worth checking as it would be nice it it would transparently fall back in this case, Steve. On 03/06/15 22:30, Abhi Das wrote: We cannot provide an efficient implementation due to the headers on the data blo

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Don't support fallocate on jdata files

2015-06-04 Thread Andrew Price
On 04/06/15 09:42, Steven Whitehouse wrote: Hi, Will glibc do the fallback path, or just return this as an error? I think thats worth checking as it would be nice it it would transparently fall back in this case, You only get the fallback with posix_fallocate() but many applications will use

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Don't support fallocate on jdata files

2015-06-04 Thread Steven Whitehouse
Hi, On 04/06/15 11:27, Andrew Price wrote: On 04/06/15 09:42, Steven Whitehouse wrote: Hi, Will glibc do the fallback path, or just return this as an error? I think thats worth checking as it would be nice it it would transparently fall back in this case, You only get the fallback with posi

Re: [Cluster-devel] [GFS2 PATCH] gfs2: Don't support fallocate on jdata files

2015-06-09 Thread Bob Peterson
- Original Message - > We cannot provide an efficient implementation due to the headers > on the data blocks, so there doesn't seem much point in having it. > > Resolves: rhbz#1221331 > Signed-off-by: Abhi Das > --- > fs/gfs2/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)