Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-31 Thread Andreas Gruenbacher
On Tue, Jul 21, 2020 at 8:55 PM Christoph Hellwig wrote: > Failing to invalid the page cache means data in incoherent, which is > a very bad state for the system. Always fall back to buffered I/O > through the page cache if we can't invalidate mappings. > > Signed-off-by: Christoph Hellwig > Ack

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-31 Thread Ritesh Harjani
On 7/22/20 12:01 AM, Christoph Hellwig wrote: Failing to invalid the page cache means data in incoherent, which is a very bad state for the system. Always fall back to buffered I/O through the page cache if we can't invalidate mappings. Signed-off-by: Christoph Hellwig Acked-by: Dave Chinne

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-29 Thread tytso
On Wed, Jul 22, 2020 at 04:13:52PM -0700, Darrick J. Wong wrote: > Hey Ted, > > Could you please review the fs/ext4/ part of this patch (it's the > follow-on to the directio discussion I had with you last week) so that I > can get this moving for 5.9? Thx, Reviewed-by: Theodore Ts'o # for ext4

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-22 Thread Darrick J. Wong
Hey Ted, Could you please review the fs/ext4/ part of this patch (it's the follow-on to the directio discussion I had with you last week) so that I can get this moving for 5.9? Thx, --D On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote: > Failing to invalid the page cache means d

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-22 Thread Darrick J. Wong
On Wed, Jul 22, 2020 at 08:18:50AM +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 01:37:49PM -0700, Darrick J. Wong wrote: > > On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote: > > > Failing to invalid the page cache means data in incoherent, which is > > > a very bad st

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-22 Thread Bob Peterson
- Original Message - > On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote: > > Failing to invalid the page cache means data in incoherent, which is > > a very bad state for the system. Always fall back to buffered I/O > > through the page cache if we can't invalidate mapping

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-21 Thread Christoph Hellwig
On Tue, Jul 21, 2020 at 01:37:49PM -0700, Darrick J. Wong wrote: > On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote: > > Failing to invalid the page cache means data in incoherent, which is > > a very bad state for the system. Always fall back to buffered I/O > > through the page

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-21 Thread Damien Le Moal
On 2020/07/22 3:32, Christoph Hellwig wrote: > Failing to invalid the page cache means data in incoherent, which is > a very bad state for the system. Always fall back to buffered I/O > through the page cache if we can't invalidate mappings. > > Signed-off-by: Christoph Hellwig > Acked-by: Dave

Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-21 Thread Darrick J. Wong
On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote: > Failing to invalid the page cache means data in incoherent, which is > a very bad state for the system. Always fall back to buffered I/O > through the page cache if we can't invalidate mappings. > > Signed-off-by: Christoph Hell

[Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

2020-07-21 Thread Christoph Hellwig
Failing to invalid the page cache means data in incoherent, which is a very bad state for the system. Always fall back to buffered I/O through the page cache if we can't invalidate mappings. Signed-off-by: Christoph Hellwig Acked-by: Dave Chinner Reviewed-by: Goldwyn Rodrigues --- fs/ext4/fil