Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-25 Thread Alexander Neundorf
On Sunday 24 February 2013, Chris Stankevitz wrote: > On Sun, Feb 24, 2013 at 12:37 PM, Alexander Neundorf > > wrote: > >> github links: > >> https://github.com/chrisstankevitz/hello > >> https://github.com/chrisstankevitz/hello-client > > > > Maybe we'll start with the old way and get to the ne

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread Chris Stankevitz
On Sun, Feb 24, 2013 at 12:37 PM, Alexander Neundorf wrote: >> github links: >> https://github.com/chrisstankevitz/hello >> https://github.com/chrisstankevitz/hello-client > > Maybe we'll start with the old way and get to the new way. Alex, Thank you again. I updated the projects per your teach

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread Alexander Neundorf
Hi Chris, On Sunday 24 February 2013, Chris Stankevitz wrote: > On Sun, Feb 24, 2013 at 2:20 AM, Alexander Neundorf wrote: > > * "export" the target (use the EXPORT option in install(TARGETS)) > > * the install this "export", using install(EXPORT ...), this will install > > a cmake script file >

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread Chris Stankevitz
On Sun, Feb 24, 2013 at 2:20 AM, Alexander Neundorf wrote: > * "export" the target (use the EXPORT option in install(TARGETS)) > * the install this "export", using install(EXPORT ...), this will install a > cmake script file > * include() this export-file in the Config.cmake file > * use configure

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread Alexander Neundorf
On Sunday 24 February 2013, J Decker wrote: > On Sun, Feb 24, 2013 at 2:23 AM, Ansis Māliņš wrote: > > # You don't need the .in file. > > > > CMAKE_MINIMUM_REQUIRED(VERSION 2.8) > > > > PROJECT(hello) > > > > set (hello_VERSION_MAJOR 1) > > set (hello_VERSION_MINOR 1) > > > > ENABLE_TESTING() >

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread J Decker
On Sun, Feb 24, 2013 at 2:23 AM, Ansis Māliņš wrote: > # You don't need the .in file. > > CMAKE_MINIMUM_REQUIRED(VERSION 2.8) > > PROJECT(hello) > > set (hello_VERSION_MAJOR 1) > set (hello_VERSION_MINOR 1) > > ENABLE_TESTING() > > ADD_LIBRARY(hello hello.cpp) > > # This works just the same. Unles

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread Ansis Māliņš
# You don't need the .in file. CMAKE_MINIMUM_REQUIRED(VERSION 2.8) PROJECT(hello) set (hello_VERSION_MAJOR 1) set (hello_VERSION_MINOR 1) ENABLE_TESTING() ADD_LIBRARY(hello hello.cpp) # This works just the same. Unless I'm missing something. SET(hello_INCLUDE_DIRS ${CMAKE_INSTALL_PREFIX}/inc

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-24 Thread Alexander Neundorf
Hi Chris, On Sunday 24 February 2013, Chris Stankevitz wrote: > Hello, > > Would you please critique my CMakeLists.txt and helloConfig.cmake.in > files? I am particularly interested in comments that will help me fix > these problems: > > - In helloConfig.cmake.in, I assume static libraries will

Re: [CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-23 Thread Jean-Christophe Fillion-Robin
Hi Chris, To make the process easier, could you create a small project on Gtihub. We would then be able to comment on a line-by-line basis. Hth Jc On Sat, Feb 23, 2013 at 11:37 PM, Chris Stankevitz < chrisstankev...@gmail.com> wrote: > Hello, > > Would you please critique my CMakeLists.txt and

[CMake] Please critique my "hello world" CMakeLists.txt and Config.cmake

2013-02-23 Thread Chris Stankevitz
Hello, Would you please critique my CMakeLists.txt and helloConfig.cmake.in files? I am particularly interested in comments that will help me fix these problems: - In helloConfig.cmake.in, I assume static libraries will be built (".a"). I imaging a better approach would make no assumptions abou