Re: [cmake-developers] -GNinja on Windows

2012-06-11 Thread Amine Khaldi
Hi, I just tested this with ReactOS and the results are really promising ! Thank you Peter for working on this. One thing I noticed is the lack of dependency tracking for the resource files (*.rc, they are compiled with rc and not cl). If you #include a file in an .rc and then alter that

Re: [cmake-developers] -GNinja on Windows

2012-06-11 Thread Amine Khaldi
Another thing I noticed while testing ReactOS is that we end up with entries like e:\reactos\ntoskrnl\include/../mm/ARM3/miarm.h (for example) in the .d files, and this triggers recompiles. If this /../ construct is eliminated (not that it's practically possible, I did it just for testing) the

[cmake-developers] [CMake 0013291]: find_path(WIN32_INCLUDE_DIR windows.h) does not work with Visual Studio 10 generator

2012-06-11 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://cmake.org/Bug/view.php?id=13291 == Reported By:Dimitri Merejkowsky Assigned To:

Re: [cmake-developers] libarchive and SCHILY.fflags

2012-06-11 Thread Kornel Benko
Am Mittwoch, 6. Juni 2012 um 07:38:44, schrieb Brad King brad.k...@kitware.com On Tue, Jun 5, 2012 at 5:46 PM, Kornel Benko kor...@lyx.org wrote: Try the patch below when building CMake against Ubuntu's libarchive. This one works. But wait ... checking again without the patch ... ERROR

Re: [cmake-developers] libarchive and SCHILY.fflags

2012-06-11 Thread Brad King
On 06/11/2012 10:08 AM, Kornel Benko wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a34015d3 Hmm, may I ask, when it should (have been) be committed? I regularly check out the sources, but the change is still missing. The topic is in the 'next' branch of the Git repo. We have

Re: [cmake-developers] libarchive and SCHILY.fflags

2012-06-11 Thread Kornel Benko
Am Montag, 11. Juni 2012 um 10:10:16, schrieb Brad King brad.k...@kitware.com On 06/11/2012 10:08 AM, Kornel Benko wrote: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a34015d3 Hmm, may I ask, when it should (have been) be committed? I regularly check out the sources, but the

Re: [cmake-developers] conditionals in generator expressions

2012-06-11 Thread Brad King
On 06/07/2012 05:47 PM, Stephen Kelly wrote: Brad King wrote: cmGeneratorExpression::Evaluate can be taught to handle everything pretty easily. Then more places need to be taught to pass values through instances of cmGeneratorExpression, such as the INCLUDE_DIRECTORIES property just before

[cmake-developers] KWStyle line length test failure

2012-06-11 Thread David Cole
In 'next' we are seeing dashboard test failures (and I am seeing it on my local build too, of course) that are related to recent edits in Source/cmNinjaTargetGenerator.cxx. 193: Processing /Users/davidcole/Dashboards/My Tests/CMake/Source/cmNinjaTargetGenerator.cxx 193: Error #0 (341) Line

[cmake-developers] [CMake 0013292]: Windows : CMake Does Not Define _CONSOLE When Not Building A Win32 Target

2012-06-11 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13292 == Reported By:Ryan H. Kawicki Assigned To:

[cmake-developers] [CMake 0013293]: INTERNAL: Cache value overwritten without a FORCE option set.

2012-06-11 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13293 == Reported By:Michael.jeulinl Assigned To:

Re: [cmake-developers] KWStyle line length test failure

2012-06-11 Thread Peter Kümmel
On 11.06.2012 18:02, David Cole wrote: In 'next' we are seeing dashboard test failures (and I am seeing it on my local build too, of course) that are related to recent edits in Source/cmNinjaTargetGenerator.cxx. 193: Processing /Users/davidcole/Dashboards/My

Re: [cmake-developers] -GNinja on Windows

2012-06-11 Thread Peter Kümmel
On 11.06.2012 13:23, Amine Khaldi wrote: Another thing I noticed while testing ReactOS is that we end up with entries like e:\reactos\ntoskrnl\include/../mm/ARM3/miarm.h (for example) in the .d files, and this triggers recompiles. If this /../ construct is eliminated (not that it's practically

Re: [cmake-developers] -GNinja on Windows

2012-06-11 Thread Peter Kümmel
All tests pass now for MSVC and MinGW! With some small patches for ninja: https://github.com/syntheticpp/ninja/commits/ninja-for-cmake The changes are only needed for msvc when the build dir path contains spaces, and for mingw because of slashes in path names. Cheers, Peter -- Powered by

Re: [cmake-developers] -GNinja on Windows

2012-06-11 Thread Bill Hoffman
On 6/11/2012 10:21 PM, Peter Kümmel wrote: All tests pass now for MSVC and MinGW! With some small patches for ninja: https://github.com/syntheticpp/ninja/commits/ninja-for-cmake The changes are only needed for msvc when the build dir path contains spaces, and for mingw because of slashes in

Re: [cmake-developers] -GNinja on Windows

2012-06-11 Thread Peter Kümmel
On 12.06.2012 04:33, Bill Hoffman wrote: On 6/11/2012 10:21 PM, Peter Kümmel wrote: All tests pass now for MSVC and MinGW! With some small patches for ninja: https://github.com/syntheticpp/ninja/commits/ninja-for-cmake The changes are only needed for msvc when the build dir path contains