Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
Sorry about the indentation ... I've still got a bit of trouble switching between coding conventions. On that note, are there documented coding conventions, coding guidelines or similar somewhere? Nils On 09/27/2012 11:01 PM, Rolf Eike Beer wrote: Am Donnerstag, 27. September 2012, 17:10:20

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
Why is TIMESTAMP misleading? Per default it currently outputs year, month, day, hour, minute and second. This includes both a date (a day on a calendar) as well as time (time of day). "Timestamp" I'd define as both date and time bound to an event (here the call or the (sub-)command). "Date"

[cmake-developers] [CMake 0013561]: CHECK_CXX_COMPILER_FLAGS is totally broken under newer version of Visual Studio

2012-09-27 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13561 == Reported By:icando Assigned To: =

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Rolf Eike Beer
Am Donnerstag, 27. September 2012, 17:10:20 schrieb Nils Gladitz: > I've tried to reimplement this as a sting sub-command (patch attached). Looks good, but the indentation looks wrong at some places. signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.co

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Rolf Eike Beer
Eric Noulard wrote: > 2012/9/27 David Cole : > > H. Good idea. > > > > Should we add a new command for this? Or should it be a sub-command of > > "string(" like RANDOM is? > > > > And... while we're at it, I've always thought we should add the > > ability to get the creation/modified/access t

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Eric Noulard
2012/9/27 David Cole : > H. Good idea. > > Should we add a new command for this? Or should it be a sub-command of > "string(" like RANDOM is? > > And... while we're at it, I've always thought we should add the > ability to get the creation/modified/access times from a file via the > CMake file

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
I've tried to reimplement this as a sting sub-command (patch attached). Nils -- Nils Gladitz, B.Sc. DICOM, Konnektivität und Entwicklung Scivis wissenschaftliche Bildverarbeitung GmbH Bertha-von-Suttner-Str. 5 D-37085 Göttingen GERMANY Handelsregister Nr. / Trade Register No. B3100 Göttingen Ge

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Brad King
On 09/27/2012 08:59 AM, Brad King wrote: > On 09/27/2012 08:37 AM, David Cole wrote: >> Should we add a new command for this? Or should it be a sub-command of >> "string(" like RANDOM is? > > It should be a string(TIMESTAMP) subcommand. We haven't added any top-level commands since 2008. At this

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
I wouldn't mind if this were a string subcommand. Initially I wanted something like this to tag package filenames. What gave me another push is this CMake test: http://open.cdash.org/testDetails.php?test=160586053&build=2583145 It seems to fail on my system because it relies on the US locale f

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Brad King
On 09/27/2012 08:37 AM, David Cole wrote: > Should we add a new command for this? Or should it be a sub-command of > "string(" like RANDOM is? It should be a string(TIMESTAMP) subcommand. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/ope

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread David Cole
H. Good idea. Should we add a new command for this? Or should it be a sub-command of "string(" like RANDOM is? And... while we're at it, I've always thought we should add the ability to get the creation/modified/access times from a file via the CMake file command. If we allow getting the "cur

[cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
I've tried creating a patch (attached; should apply to master) that adds a timestamp creation command. It builds on strftime but only allows a limited number of conversion specifiers. I tried to only allow those which are portable (C89), locale independent and of fixed range and length (with the