On 2013-07-25 15:31-0400 Brad King wrote:
On 07/24/2013 03:27 PM, Alan W. Irwin wrote:
The first priority is to verify on Microsoft Windows that this is
actually an issue using the the simple test I outlined in my previous
post.
At a MSYS prompt under MS Windows this works:
$ cat a.tar.xz |
Matthew Woehlke wrote:
> On 2013-07-25 13:25, Stephen Kelly wrote:
>> Brad King wrote:
>>
>>> On 07/25/2013 12:22 PM, Stephen Kelly wrote:
library A should have a unit test which attempts to compile all
of its headers with all warnings enabled. In Qt every module has a
'headersclean
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14316
==
Reported By:Brennon Brimhall
Assigned To:
On 07/24/2013 03:27 PM, Alan W. Irwin wrote:
> The first priority is to verify on Microsoft Windows that this is
> actually an issue using the the simple test I outlined in my previous
> post.
At a MSYS prompt under MS Windows this works:
$ cat a.tar.xz | unxz | tar x
but this hangs:
$ cmake
On 2013-07-25 13:25, Stephen Kelly wrote:
Brad King wrote:
On 07/25/2013 12:22 PM, Stephen Kelly wrote:
library A should have a unit test which attempts to compile all
of its headers with all warnings enabled. In Qt every module has a
'headersclean' unit test which does exactly that.
While t
On 07/25/2013 01:25 PM, Stephen Kelly wrote:
> I still think IMPORTED=SYSTEM by *default* is a good idea,
> and let the edge case switch it back.
What interface do you propose to switch it back?
There is also the common use case of having ExternalProject
create a custom target to drive a third-p
Brad King wrote:
> On 07/25/2013 12:22 PM, Stephen Kelly wrote:
>> library A should have a unit test which attempts to compile all
>> of its headers with all warnings enabled. In Qt every module has a
>> 'headersclean' unit test which does exactly that.
>
> While this is a good idea we're not goi
On 07/25/2013 01:18 PM, Daniele E. Domenichelli wrote:
> Now that SelectLibraryConfigurations is good enough for me, I updated
> FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic,
> does anyone want to review them before I merge the changes to next?
I just glanced through and
Hello,
Now that SelectLibraryConfigurations is good enough for me, I updated
FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic,
does anyone want to review them before I merge the changes to next?
Thanks,
Cheers,
Daniele
--
Powered by www.kitware.com
Visit other Kitware op
On 07/25/2013 12:22 PM, Stephen Kelly wrote:
> library A should have a unit test which attempts to compile all
> of its headers with all warnings enabled. In Qt every module has a
> 'headersclean' unit test which does exactly that.
While this is a good idea we're not going to assume every projec
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14315
==
Reported By:Petr Machata
Assigned To:
Matthew Woehlke wrote:
> On 2013-07-25 11:25, Stephen Kelly wrote:
>> Brad King wrote:
>>> On 07/25/2013 09:16 AM, Stephen Kelly wrote:
Should we treat the INTERFACE_INCLUDE_DIRECTORIES of all IMPORTED
targets as SYSTEM includes automatically?
>>>
>>> I don't think so because one could b
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14314
==
Reported By:Petr Machata
Assigned To:
On 2013-07-25 11:25, Stephen Kelly wrote:
Brad King wrote:
On 07/25/2013 09:16 AM, Stephen Kelly wrote:
Should we treat the INTERFACE_INCLUDE_DIRECTORIES of all IMPORTED targets
as SYSTEM includes automatically?
I don't think so because one could be importing targets from a dependency
that wa
Brad King wrote:
> On 07/25/2013 09:16 AM, Stephen Kelly wrote:
>> target_link_libraries(foo SYSTEM Qt5::Core)
>
> That looks okay to me so long as SYSTEM must always be the first keyword.
Yes, that's how I've implemented it currently.
> We could also consider adding it only to the modern (new
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14313
==
Reported By:Marc Plano-Lesay
Assigned To:
>> using cmake --graphviz=filename .
>> you can generate graphs showing the dependencies between the targets.
>> If present, cmake will read a CMakeGraphVizOptions.cmake file, and use
>> options
>> from it, e.g. GRAPHVIZ_GRAPH_TYPE and GRAPHVIZ_EXTERNAL_LIBS.
>> AFAIK this is not documented anywhe
On 07/25/2013 09:31 AM, Stephen Kelly wrote:
> In a more-recent review, I thought that if there is an extension in the exts
> list which already has a numerical extension, then the extra check for a
> numerical extension shouldn't be added for that entry.
>
> else if(type == LinkShared)
>
On 07/25/2013 09:16 AM, Stephen Kelly wrote:
> target_link_libraries(foo SYSTEM Qt5::Core)
That looks okay to me so long as SYSTEM must always be the first keyword.
We could also consider adding it only to the modern (newest) keyword
signature to encourage conversion to it.
> Should we treat the
Hi,
Commit 342fc0401005 (Recognize shared library files with a numerical suffix,
2013-04-11) resulted from
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6613/focus=6616
In a more-recent review, I thought that if there is an extension in the exts
list which already has a
Hi,
In response to
https://bugreports.qt-project.org/browse/QTBUG-32599
I first considered adding something like
if(NOT QT_INCLUDE_DIRS_NO_SYSTEM)
set_property(TARGET Qt5::Core
SYSTEM_INTERFACE_INCLUDE_DIRECTORIES
${Qt5Core_INCLUDE_DIRS}
)
endif()
for each imported target
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14312
==
Reported By:Wojciech Knapik
Assigned To:
On 07/24/2013 05:38 PM, Rolf Eike Beer wrote:
> So for the beginning I would go and just simply reject every test name that
> has spaces or quotes, because that has never worked.
That sounds good.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://w
Hi there,
I've pushed a cpack-bar-package topic to my clone
https://gitorious.org/~steveire/cmake/steveires-cmake
It is the start of a CPack generator for BlackBerry BAR packages, required
for deployment to those devices. I haven't worked much with CPack before, so
I'd appreciate some feedba
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14311
==
Reported By:Nikita Krupenko
Assigned To:
2013/7/24 Alexander Neundorf :
> Hi,
>
> using cmake --graphviz=filename .
> you can generate graphs showing the dependencies between the targets.
> If present, cmake will read a CMakeGraphVizOptions.cmake file, and use options
> from it, e.g. GRAPHVIZ_GRAPH_TYPE and GRAPHVIZ_EXTERNAL_LIBS.
> AFAIK
26 matches
Mail list logo
