On 07/25/2013 01:18 PM, Daniele E. Domenichelli wrote:
> Now that SelectLibraryConfigurations is good enough for me, I updated
> FindGTK2.cmake to use it. I pushed my changes in a FindGTK2Debug topic,
> does anyone want to review them before I merge the changes to next?
I just glanced through and the changes all look good to me except one
minor detail. In this hunk:
+ include(${CMAKE_CURRENT_LIST_DIR}/SelectLibraryConfigurations.cmake)
it is not safe to include a standard module inside a function due to
variable scoping. Please revise the commit to include the file ahead
of time. Then go ahead and merge.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
