Re: [cmake-developers] Patches for Visual Studio multi-CPU architecture project generation and a Windows-Phone-8 generator

2013-10-17 Thread Patrick Gansterer
On 16.10.2013, at 15:06, Brad King wrote: > On 10/16/2013 03:57 AM, Paul Annetts wrote: >> Brad King asked me to refactor out the multi-CPU architecture >> (platform) part > [snip] >> https://github.com/paulannetts/CMake/tree/vs11MultiPlatform >> https://github.com/paulannetts/CMake/tree/windows-

[cmake-developers] [CMake 0014490]: Wrong Windows SDK location detected

2013-10-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14490 == Reported By:Domagoj Saric Assigned To:

Re: [cmake-developers] Patches for Visual Studio multi-CPU architecture project generation and a Windows-Phone-8 generator

2013-10-17 Thread Brad King
On 10/17/2013 03:42 AM, Patrick Gansterer wrote: > ...project link against a 3rd party library with find_package() > which are different on x86/x64/ARM/... platform. > I'm against adding this feature until this problem is solved Ugh, you're right. That completely slipped my mind. We can support

Re: [cmake-developers] C++11 and target_compiler_feature proposal

2013-10-17 Thread Stephen Kelly
Stephen Kelly wrote: > I'll try to get a reviewable and first-feature-complete infrastructure > branch together soon. I've pushed a first iteration of the target_compiler_features branch to my clone. For the language specification, I added a prefix to each feature. This matches the feature tes

[cmake-developers] [CMake 0014491]: file(GLOB) and file(GLOB_RECURSE) indeterministic

2013-10-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14491 == Reported By:ingolf Assigned To: =

Re: [cmake-developers] C++11 and target_compiler_feature proposal

2013-10-17 Thread Stephen Kelly
Stephen Kelly wrote: >> I'll try to get a reviewable and first-feature-complete infrastructure >> branch together soon. > > I've pushed a first iteration of the target_compiler_features branch to my > clone. > It was broken in several ways, so I've force pushed it since. Thanks, Steve. --

Re: [cmake-developers] Documentation or parse bug

2013-10-17 Thread Brad King
On 10/16/2013 02:40 PM, James Bigler wrote: > The documentation for target_link_libraries has this description: > > target_link_libraries( > > [[debug|optimized|general] ] ... > [ > [[debug|optim

Re: [cmake-developers] C++11 and target_compiler_feature proposal

2013-10-17 Thread Brad King
Hi Steve, Thanks for working on this! On 10/17/2013 10:28 AM, Stephen Kelly wrote: > For the language specification, I added a prefix to each feature. This > matches the feature tests of clang for standard features, and it is > extensible to extensions with gnuxx_typeof, msvc_sealed etc. > >

Re: [cmake-developers] Documentation or parse bug

2013-10-17 Thread Stephen Kelly
Brad King wrote: > On 10/16/2013 02:40 PM, James Bigler wrote: >> The documentation for target_link_libraries has this description: >> >> target_link_libraries( >> >> [[debug|optimized|general] ] ... >> [ >>

Re: [cmake-developers] C++11 and target_compiler_feature proposal

2013-10-17 Thread Stephen Kelly
Brad King wrote: >> Optional features with defines are not yet implemented. I was considering >> renaming target_compiler_features to target_required_features > > I think target_compiler_features is a clearer name even if it only > supports required features. Please leave room in the signature f

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Pedro Navarro
Ok, I have the patch working and I'm going to send it soon. One question, is it possible to launch a detached process from within CMake? If I use EXECUTE_PROCESS to start p4d, CMake waits for it to finish so -for now- I'm launching the Perforce daemon outside CMake. Pedro On Wed, Oct 16, 2013 at

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Bill Hoffman
On 10/17/2013 1:52 PM, Pedro Navarro wrote: Ok, I have the patch working and I'm going to send it soon. One question, is it possible to launch a detached process from within CMake? If I use EXECUTE_PROCESS to start p4d, CMake waits for it to finish so -for now- I'm launching the Perforce daemon o

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Brad King
On 10/17/2013 02:18 PM, Bill Hoffman wrote: > On 10/17/2013 1:52 PM, Pedro Navarro wrote: >> Ok, I have the patch working and I'm going to send it soon. One >> question, is it possible to launch a detached process from within CMake? >> If I use EXECUTE_PROCESS to start p4d, CMake waits for it to fi

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Pedro Navarro
I experimented with nohup but from inside a shell script that was being executed from execute_process, but that didn't work. I'll give that a try, thanks! There happens to be a way to cleanly shutdown perforce, executing "p4 admin stop", so this could mean that we can start p4d if it's present and

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Brad King
On 10/17/2013 03:23 PM, Pedro Navarro wrote: > I experimented with nohup but from inside a shell script > that was being executed from execute_process, but that didn't work. You also need to disconnect the stdout/stderr pipes by redirecting them to /dev/null. Then execute_process can fully let go

[cmake-developers] [CMake 0014492]: Visual Studio 2013 breaks parallel command-line builds

2013-10-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14492 == Reported By:Nick Hutchinson Assigned To:

[cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

2013-10-17 Thread Nils Gladitz
Hello, I'm trying to fix: http://public.kitware.com/Bug/view.php?id=14484 which I reported earlier. I pushed my topic "ctest-fix-run-serial" to stage. Could some of you take a look at my changes? They seem to fix the issue for me and don't seem to break any of the existing tests but the code i

Re: [cmake-developers] Roadmap to CMake 3.0

2013-10-17 Thread Alexander Neundorf
On Monday 14 October 2013, Brad King wrote: > On 10/13/2013 6:03 AM, Alexander Neundorf wrote: ... > > I'd like to remove the --find-package mode, which was my attempt to make > > cmake packages easier to use by non-cmake projects. > > The idea was that you can use cmake --find-package JPEG similar

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Rolf Eike Beer
Am Donnerstag, 17. Oktober 2013, 14:18:34 schrieb Bill Hoffman: > On 10/17/2013 1:52 PM, Pedro Navarro wrote: > > Ok, I have the patch working and I'm going to send it soon. One > > question, is it possible to launch a detached process from within CMake? > > If I use EXECUTE_PROCESS to start p4d, C

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Brad King
On 10/17/2013 04:56 PM, Rolf Eike Beer wrote: > We should think if this should be something that is needed. Running some sort > of background process is a common pattern for all sorts of tests. Often > really > detaching is not needed, It is usually sufficient to have one process running > in

Re: [cmake-developers] cmake --find-package (was: Roadmap to CMake 3.0)

2013-10-17 Thread Brad King
On 10/17/2013 04:58 PM, Alexander Neundorf wrote: > Yes, that was the idea, but I can't rely anymore on a Foo_LIBRARIES variable > (or a slight variation) being set after a successful find_package(Foo): > http://lists.kde.org/?l=kde-core-devel&m=138198795723680&w=2 > I.e. in the future there will

Re: [cmake-developers] cmake --find-package (was: Roadmap to CMake 3.0)

2013-10-17 Thread Stephen Kelly
Brad King wrote: > On 10/17/2013 04:58 PM, Alexander Neundorf wrote: >> Yes, that was the idea, but I can't rely anymore on a Foo_LIBRARIES >> variable (or a slight variation) being set after a successful >> find_package(Foo): >> http://lists.kde.org/?l=kde-core-devel&m=138198795723680&w=2 I.e. in

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

2013-10-17 Thread Bill Hoffman
On 10/17/2013 4:41 PM, Nils Gladitz wrote: I pushed my topic "ctest-fix-run-serial" to stage. I am taking a look. It has been a long time since I looked at this code. However, it seems like your patch removes the running of dependent tests. old code did this: StartTest(int test) ... for

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Bill Hoffman
On 10/17/2013 4:59 PM, Brad King wrote: As I explained in a sibling response the KWSys Process library has support for creating detached processes. It should only be a matter of exposing that through execute_process command options. +1, this does come up a lot. It would be good to have this ex

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

2013-10-17 Thread Nils Gladitz
Hello Bill, thanks for looking into this! All four tests in my example are still run (as you can see in the test output I provided). This includes the dependent test. What I did change is that all tests (from an dependency or otherwise) are run from StartNextTests() which ensures that serial

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

2013-10-17 Thread Bill Hoffman
On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz wrote: > Hello Bill, thanks for looking into this! > > All four tests in my example are still run (as you can see in the test > output I provided). > This includes the dependent test. > > What I did change is that all tests (from an dependency or othe

Re: [cmake-developers] CTest: Request review of topic "ctest-fix-run-serial"

2013-10-17 Thread Nils Gladitz
StartTest() returns false without running the test if there are any dependencies remaining. Nils On 17.10.2013 23:57, Bill Hoffman wrote: On Thu, Oct 17, 2013 at 5:31 PM, Nils Gladitz > wrote: Hello Bill, thanks for looking into this! All four tests in m

Re: [cmake-developers] Perforce Patch for CTest

2013-10-17 Thread Matthew Woehlke
On 2013-10-17 16:59, Brad King wrote: On 10/17/2013 04:56 PM, Rolf Eike Beer wrote: We should think if this should be something that is needed. Running some sort of background process is a common pattern for all sorts of tests. Often really detaching is not needed, It is usually sufficient to ha