Re: [cmake-developers] Learning from the source

2014-04-18 Thread Chuck Atkins
Hi Ingwie, It depends on what exactly you're referring to. If you mean calls to find_library and find_path, those usually have a set of known directories and patterns that they search for. However, if you're referring to the configure time checks line CHECK_INCLUDE_FILE and related functions, th

[cmake-developers] [CMake 0014891]: CMake incorrectly handles path to gfortran compiler containing spaces

2014-04-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14891 == Reported By:vitaut Assigned To: =

Re: [cmake-developers] target_compile_features remaining issues

2014-04-18 Thread Brad King
On 04/15/2014 11:39 AM, Stephen Kelly wrote: >> I think we should reverse our earlier decision and go ahead and add >> an error whenever a feature is requested that we do not know *is* >> supported for the current {id, version}. > > Yes, I think that makes sense. Such an error can be relaxed in th

Re: [cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands

2014-04-18 Thread Ben Boeckel
On Fri, Apr 18, 2014 at 10:06:36 -0400, Matthew Woehlke wrote: > Where a variable is created (e.g. the SET command), presumably. Internally-created variables would then be missed. string(TOUPPER "mystr" "varname with spaces") > I don't think the performance hit should be so bad if only write

[cmake-developers] [CMake 0014890]: cpack, wix, It's not possible to patch directories (patch attached)

2014-04-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14890 == Reported By:Nicolas H. Assigned To: =

[cmake-developers] [CMake 0014889]: Cpack crashes when issuing a bad Wix Patch

2014-04-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14889 == Reported By:Nicolas H. Assigned To: =

Re: [cmake-developers] Default generator

2014-04-18 Thread Matthew Woehlke
On 2014-04-17 07:56, Peter Kümmel wrote: Is there a way to configure the default generator for command-line cmake calls? If you're using bash: 'alias cmake="cmake -GNinja"' (for example)... I'm not sure how folks would feel about having a different default built into the cmake binary itself (

Re: [cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands

2014-04-18 Thread Matthew Woehlke
On 2014-04-17 22:23, Ben Boeckel wrote: On Thu, Apr 17, 2014 at 17:17:21 -0400, Matthew Woehlke wrote: Alas, the only character that may not appear in a variable name is '\0'. (And even that is more due to use of raw char* with no length than intent, I bet.) Actually, it's all std::string now,

Re: [cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands

2014-04-18 Thread Brad King
On 04/18/2014 08:58 AM, Rolf Eike Beer wrote: > To forbid whitespace and control characters in variable names can IMHO only > be good. Some people use arbitrary variable names as a way to do key/value tables. In such cases it is intentional to use arbitrary characters in variable names even thoug

[cmake-developers] [CMake 0014888]: FeatureSummary does not recognize Qt 4

2014-04-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14888 == Reported By:Peter Kuemmel Assigned To:

Re: [cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands

2014-04-18 Thread Rolf Eike Beer
Brad King wrote: > On 04/18/2014 03:07 AM, Rolf Eike Beer wrote: > > what about nuking at least all > > control characters and whitespace from variable names in 3.1? I don't > > think > > that anyone has used them on purpose, and accidentially using them will > > only cause trouble. > > If we're g

Re: [cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands

2014-04-18 Thread Brad King
On 04/18/2014 03:07 AM, Rolf Eike Beer wrote: > what about nuking at least all > control characters and whitespace from variable names in 3.1? I don't think > that anyone has used them on purpose, and accidentially using them will only > cause trouble. If we're going to change this I don't want

Re: [cmake-developers] Topic UseSWIG-guess_module_name

2014-04-18 Thread Brad King
On 04/18/2014 06:19 AM, Julien Schueller wrote: > I wondered why my topic UseSWIG-guess_module_name to fix #10080 was not > merged yet. > Did I miss a negative review ? Yes: http://www.cmake.org/Bug/view.php?id=10080#c35708 -Brad -- Powered by www.kitware.com Please keep messages on-topic

[cmake-developers] [CMake 0014887]: CMake fails to compile - error: use of undeclared identifier 'abi'

2014-04-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14887 == Reported By:cakersq Assigned To:

[cmake-developers] Topic UseSWIG-guess_module_name

2014-04-18 Thread Julien Schueller
Hi, I wondered why my topic UseSWIG-guess_module_name to fix #10080 was not merged yet. Did I miss a negative review ? J. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support

[cmake-developers] [CMake 0014886]: [PATCH] Make documentation generation python3 compatible.

2014-04-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://cmake.org/Bug/view.php?id=14886 == Reported By:Uwe L. Korn Assigned To:

Re: [cmake-developers] [PATCH] remove "x" placeholder from STREQUAL operands

2014-04-18 Thread Rolf Eike Beer
Matthew Woehlke wrote: > On 2014-04-13 03:37, Rolf Eike Beer wrote: > > Sadly the expression is even expanded when it is quoted as long as it is a > > valid variable name. So what you could do is: replace the "x" by a simple > > space and then quote the match string, because " Linux" is no valid >