Re: [cmake-developers] New platform file for Cray Compute Node Linux

2014-08-17 Thread Rolf Eike Beer
Chuck Atkins wrote: Updated to allow for static and shared libs (yes, you can use shared libs on a cray). The expectation is that your toolchain file will have the appropriate logic to deal with this. Something like: set(CMAKE_SYSTEM_NAME ComputeNodeLinux) ... if(DEFINED

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would like any further changes making, please just let me know. Regards, Roger On Sat, Aug 16, 2014 at 11:11:42AM -0400, Chuck Atkins wrote: Hey Roger, thanks for

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Rolf Eike Beer
Roger Leigh wrote: Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would like any further changes making, please just let me know. I don't think you need the functions for anything, especially not

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 02:57:36PM +0200, Rolf Eike Beer wrote: Roger Leigh wrote: Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would like any further changes making, please just let me know. I

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 02:28:59PM +0100, Roger Leigh wrote: On Sun, Aug 17, 2014 at 02:57:36PM +0200, Rolf Eike Beer wrote: Roger Leigh wrote: Dear Chuck, Thanks for looking at this. Please find attached a new copy of the patch which should address all your points. If you would

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Rolf Eike Beer
Sorry for the naïve question, but the find_package docs also mentions setting package_VERSION_COUNT but I don't see any examples of this in cmake git. Is setting the MAJOR/MINOR/PATCH versions here correct or redundant or plain wrong? Or all handled internally by

Re: [cmake-developers] [PATCH] New module FindXerces

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 03:46:14PM +0200, Rolf Eike Beer wrote: Sorry for the naïve question, but the find_package docs also mentions setting package_VERSION_COUNT but I don't see any examples of this in cmake git. Is setting the MAJOR/MINOR/PATCH versions here correct or redundant or

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

2014-08-17 Thread Roger Leigh
On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote: OK. I'll have to read up on this and see what needs doing. In the meantime, I've attached a revised patch with all the above corrections included. Based on the comments made on my other FindXerces patch, I've updated this patch to

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

2014-08-17 Thread Rolf Eike Beer
Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh: On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote: OK. I'll have to read up on this and see what needs doing. In the meantime, I've attached a revised patch with all the above corrections included. Based on the

Re: [cmake-developers] [PATCH] New module: FindIce.cmake

2014-08-17 Thread Roger Leigh
On Sun, Aug 17, 2014 at 05:50:58PM +0200, Rolf Eike Beer wrote: Am Sonntag, 17. August 2014, 16:21:24 schrieb Roger Leigh: On Fri, Aug 15, 2014 at 12:31:17AM +0100, Roger Leigh wrote: OK. I'll have to read up on this and see what needs doing. In the meantime, I've attached a revised