On 09/19/2014 07:30 AM, James Bigler wrote:
Could someone please explain to me why we need to change all the if
statements to look super ugly?
It sounds like you might have missed the follow up within this thread.
Expanding "WIN32" to dereference the value is just a recipe for
confusion. Hon
Could someone please explain to me why we need to change all the if
statements to look super ugly?
Expanding "WIN32" to dereference the value is just a recipe for confusion.
Honestly I would prefer if there was a policy to never deference variables
in if statements and replace the if's with:
if
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=15164
==
Reported By:Janne Rönkkö
Assigned To:
On Mon, Sep 8, 2014 at 2:51 PM, Brad King wrote:
> On 09/03/2014 12:12 PM, Aleix Pol wrote:
> > On Wed, Sep 3, 2014 at 5:48 PM, Alexander Neundorf wrote:
> >> I still don't understand why this shouldn't be an additional
> ExtraGenerator.
> >
> > Because it's not possible to change the generat
On 09/18/2014 12:03 PM, Pascal Bach wrote:
> diff --git a/Help/manual/cmake-toolchains.7.rst
> b/Help/manual/cmake-toolchains.7.rst
> index f36a43c..095a43f 100644
> --- a/Help/manual/cmake-toolchains.7.rst
> +++ b/Help/manual/cmake-toolchains.7.rst
> @@ -174,5 +174,25 @@ toolchain which will be u
On 09/18/2014 01:00 PM, Adam Strzelecki wrote:
> If I understand correctly all modules included via
> include/find_package have implicit POLICY PUSH and POP
Yes.
> at the EOF. Wouldn't it be reasonable to require all
> internal .cmake files to begin with:
>
> cmake_policy(VERSION 3.1) # or
On Thursday, September 18, 2014 06:15:51 PM Adam Strzelecki wrote:
> FYI I pushed stage/fix-OSX-bundle-rpaths-and-Qt5 topic for final review.
>
> Regards,
Does the functionality you add allow us to modify
CMake/Tests/BundleUtilities/CMakeLists.txt such that the last part in the
tests where @rpa
If I understand correctly all modules included via include/find_package have
implicit POLICY PUSH and POP at the EOF. Wouldn't it be reasonable to require
all internal .cmake files to begin with:
cmake_policy(VERSION 3.1) # or whatever version the module was tested
against
Then before
FYI I pushed stage/fix-OSX-bundle-rpaths-and-Qt5 topic for final review.
Regards,
--
Adam
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
info
---
Help/manual/cmake-toolchains.7.rst | 20
1 file changed, 20 insertions(+)
diff --git a/Help/manual/cmake-toolchains.7.rst
b/Help/manual/cmake-toolchains.7.rst
index f36a43c..095a43f 100644
--- a/Help/manual/cmake-toolchains.7.rst
+++ b/Help/manual/cmake-toolchains.7.rs
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=15163
==
Reported By:Ilya Rusyanov
Assigned To:
On 09/18/2014 04:05 PM, Brad King wrote:
On 09/17/2014 02:25 PM, Nils Gladitz wrote:
I pushed "root-modules-set-policies-new" to stage which sets all
policies to NEW for modules from cmake's own Modules directory if
NO_POLICY_SCOPE is not used.
A minor comment on the impl: use cmSystemTools::G
On 09/17/2014 02:25 PM, Nils Gladitz wrote:
> I pushed "root-modules-set-policies-new" to stage which sets all
> policies to NEW for modules from cmake's own Modules directory if
> NO_POLICY_SCOPE is not used.
A minor comment on the impl: use cmSystemTools::GetCMakeRoot
instead of looking up CMA
On 09/17/2014 02:42 AM, Mattias Helsing wrote:
> If I'm not requiring osgUI it shouldn't break my build.
Applied, thanks:
FindOpenSceneGraph: Do not add unfound OSG libs if not required
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b683da3e
-Brad
--
Powered by www.kitware.com
Please keep
This is done by gathering LC_RPATH commands for main bundle executable and
using it for @rpath lookup in dependent frameworks.
All functions that need to carry rpaths to now take optional argument.
This enabled apps using @rpath to be bundled correctly, which will be necessary
for upcoming Qt 5.
> After that change is dropped, I give a +1 for the patch set.
Done, both in attached 3/5 patch and GitHub branch of mine.
--Adam
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to sup
16 matches
Mail list logo
