Re: [cmake-developers] FindMPI take 2

2014-12-09 Thread Thompson, KT
Brad King wrote: >> 0002-first-try-to-see-if-what-user-provided-produces-an-m.patch > The check for whether the CMAKE__COMPILER is already a > MPI compiler requires a try_compile. Is there some other way > to check to see if there is any chance before the full test? I have been looking into thi

Re: [cmake-developers] Volunteering to maintain a new module: FindGSL.cmake

2014-12-09 Thread Thompson, KT
Stephen Kelly wrote: > This looks like it needs a suffix. GSL_CONFIG_EXECUTABLE would seem > appropriate. >> # Windows with dlls, but only Release libraries. >> set_target_properties( GSL::gslcblas PROPERTIES >> IMPORTED_LOCATION "${GSL_CBLAS_LIBRARY_DLL}" > This s

Re: [cmake-developers] [DISCUSSION] Using COMPONENTs for CMake install(...)?

2014-12-09 Thread Konstantin Podsvirov
09.12.2014, 23:48, "Brad King" : > On 12/9/2014 1:39 PM, Konstantin Podsvirov wrote: >>> That looks good, except that "cmake/ctest/cpack" must all be in >>> one component. >> specify whether the component is required and can be specified as >> any of the components referenced by this component. > >

[cmake-developers] [ANNOUNCE] CMake 3.1.0-rc3 is now ready!

2014-12-09 Thread Robert Maynard
I am proud to announce the CMake 3.1 third release candidate. Sources and binaries are available at: http://www.cmake.org/files/v3.1/?C=M;O=D Documentation is available at: http://www.cmake.org/cmake/help/v3.1 Release notes appear below and are also published at http://www.cmake.org/cmake/

Re: [cmake-developers] [DISCUSSION] Using COMPONENTs for CMake install(...)?

2014-12-09 Thread Brad King
On 12/9/2014 1:39 PM, Konstantin Podsvirov wrote: >> That looks good, except that "cmake/ctest/cpack" must all be in >> one component. > > specify whether the component is required and can be specified as > any of the components referenced by this component. I suppose they can be separate compone

Re: [cmake-developers] [PATCH 1/2] Add handling for XCTest bundles

2014-12-09 Thread Brad King
On 12/9/2014 6:02 AM, Gregor Jasny wrote: > +XCTEST_HOST > +--- > + > +XCTest works by injecting an XCTest CFBundle directly into an AppBundle > +or Framework. This property names this destination target under test. Please add mention of :prop_tgt:`XCTEST` here. > \ No newline at end of f

Re: [cmake-developers] [PATCH 0/2] XCTest support

2014-12-09 Thread Brad King
On 12/9/2014 6:02 AM, Gregor Jasny wrote: > See: > https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/testing_with_xcode/ Thanks. > On non-Apple platforms and Xcode < 5.0 those XCTest bundles are pretty > useless. What should CMake do on those platforms? The fact t

[cmake-developers] Qt5

2014-12-09 Thread imran lala
Hi, is there an easy way to compile Qt 5.2.1 using CMake? Thanks,Imran -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offer

Re: [cmake-developers] [DISCUSSION] Using COMPONENTs for CMake install(...)?

2014-12-09 Thread Konstantin Podsvirov
08.12.2014, 17:26, "Brad King" : > On 12/07/2014 05:34 PM, Konstantin Podsvirov wrote: >> Well, work has started! > Good work so far. I tried :-) > Please reorganize the commits to have the first one add the install > COMPONENT options and the second one add the CPack configuration. >> Added comp

Re: [cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds

2014-12-09 Thread Brad King
On 12/09/2014 10:57 AM, Bach, Pascal wrote: > set_target_properties(target PROPERTIES LINK_FLAGS "/ENTRY:mainCRTStartup") I prefer to use LINK_FLAGS only as a last resort. For common settings we should provide a first-class setting. > For consistency reason there could be something like a > WIN3

Re: [cmake-developers] FindMPI take 2

2014-12-09 Thread Brad King
On 12/09/2014 06:59 AM, Alin Marin Elena wrote: > 0001-correctly-detect-MPI-linker-flags-for-Intel-MPI-mayb.patch Thanks. That adds a block much like one above it. Can the preceding block be modified to match both -Wl, and -Xlinker? Something like: -string(REGEX MATCHALL "(^| )-Wl,([^\

Re: [cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds

2014-12-09 Thread Bach, Pascal
> The closest place to something like that is here: > > http://www.cmake.org/cmake/help/v3.1/manual/cmake- > toolchains.7.html#cross-compiling-for-windows-ce > > However, in this case isn't a new target property needed to provide > a clean way to set the entry point? That property would at leas

Re: [cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds

2014-12-09 Thread Brad King
On 12/09/2014 10:46 AM, Bach, Pascal wrote: > Is there a place where we could document things like this in the > CMake documentation? Something like a platform specific collection > of best practice and commonly required tasks. The closest place to something like that is here: http://www.cmake.

Re: [cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds

2014-12-09 Thread Bach, Pascal
> On 12/09/2014 09:45 AM, Bach, Pascal wrote: > > the old behavior was better. The user should then be able to set the > > entry point independent of the UNICODE setting via a target property. > > This would be similar to how WIN32_EXECUTABLE selects WinMain as > startup. > > Good catch. They a

Re: [cmake-developers] [PATCH] FindQt4: Fix handling of QT_VERSION_MAJOR mismatch

2014-12-09 Thread Brad King
On 12/09/2014 09:40 AM, Daniel Scharrer wrote: > This caused find_package(Qt4) to appear successful when it was not. > Note that the legacy QT4_FOUND variable is unconditionally overwritten > at the end of the file with the value of Qt4_FOUND. Applied with slightly modified commit message: FindQ

Re: [cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds

2014-12-09 Thread Brad King
On 12/09/2014 09:45 AM, Bach, Pascal wrote: > the old behavior was better. The user should then be able to set the > entry point independent of the UNICODE setting via a target property. > This would be similar to how WIN32_EXECUTABLE selects WinMain as startup. Good catch. They are orthogonal se

Re: [cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds

2014-12-09 Thread Bach, Pascal
> Fixed typo in commit message: > > VS, WINCE: Fix entry point for Unicode builds > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=681cda02 > I figured out that the combination /ENTRY:mainCRTStartup is also possible even if UNICODE is enabled. The question is now what should CMake do as

[cmake-developers] [PATCH] FindQt4: Fix handling of QT_VERSION_MAJOR mismatch

2014-12-09 Thread Daniel Scharrer
This caused find_package(Qt4) to appear successful when it was not. Note that the legacy QT4_FOUND variable is unconditionally overwritten at the end of the file with the value of Qt4_FOUND. --- Modules/FindQt4.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/FindQ

[cmake-developers] FindMPI take 2

2014-12-09 Thread Alin Marin Elena
Dear All, recently I have run into some issues with FindMPI and intel mpi[1], more intel mpi issue rather than cmake. The original issue reported in[1] was solved. However in the process I made few points related mainly to FindMPI, that I summarise in here: 1. the linker information is not parsed

[cmake-developers] [PATCH 2/2] Add XCTest Example

2014-12-09 Thread Gregor Jasny
This test builds an trivial Cocoa App Bundle and an XCTest Bundle. After project generation open it in Xcode and 'Test' the project. Signed-off-by: Gregor Jasny --- Tests/CocoaExample/CMakeLists.txt | 25 + Tests/CocoaExample/CocoaExample/AppDelegate.h | 7 + Tests/Cocoa

[cmake-developers] [PATCH 1/2] Add handling for XCTest bundles

2014-12-09 Thread Gregor Jasny
An XCTest bundle is a CFBundle with a special product-type and bundle extension. It gets loaded directly into the AppBundle or Framework it should test. For more information about XCTest visit the Mac Developer library at: http://developer.apple.com/library/mac/documentation/DeveloperTools/Concept

[cmake-developers] [PATCH 0/2] XCTest support

2014-12-09 Thread Gregor Jasny
Hi Brad, > I'm not very familiar with Xcode-specific things like xctest binaries. > Please briefly explain their purpose, how they work, and how developers > might use them. How should they be treated on non-Apple platforms? XCTest is Apples latest idea of how to write Unit Tests for App Bundles

[cmake-developers] [CMake 0015295]: CMake should not concatenate commands for cmd.exe

2014-12-09 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15295 == Reported By:Ilya Assigned To: ===