Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-02-26 Thread Raffi Enficiaud
Quick question: Is it possible to redirect the input stream of execute_process from /dev/null on OSX and Linux ? Right now on these platforms, I need to reset my shell. If I run the ctest command with /dev/null, everything is fine. So my guess is that Matlab is manipulating the console

Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-02-26 Thread Raffi Enficiaud
Hi Brad, Please find the patch addressing the issues you raised. My local tests are clear on the 3 platforms. I removed the RunCMake test on Linux as now the Matlab_MAIN_PROGRAM is required if MATLAB_USER_ROOT is not specified. In the previous implementation, I used temporary variables to

Re: [cmake-developers] [PATCH] Pass CMAKE_VERBOSE_MAKEFILE value to Ninja Generator

2015-02-26 Thread Brad King
On 02/26/2015 05:32 AM, Gregor Jasny wrote: Ninja build system does not support a in-Makefile verbositiy switch. So we use cmake --build as a fall back to extract the CMAKE_VERBOSE_MAKEFILE property and pass it as an optional -v argument to Ninja. Applied and test case added: cmake: Teach

Re: [cmake-developers] [PATCH v6 0/2] Add XCTest Bundle Support

2015-02-26 Thread Brad King
On 02/25/2015 03:07 PM, Gregor Jasny wrote: Changes since v5: * Rebased against master (could drop two applied patches) * kept help modules list sorted * indirected xctest wiring Great. The tests pass on my machine with no special configuration. The basic functionality is in good shape. My

[cmake-developers] [CMake 0015421]: FindOpenMP always re-run

2015-02-26 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=15421 == Reported By:Mathieu Malaterre Assigned To:

[cmake-developers] [CMake 0015422]: cmake --help should be explicit about how to specify architecture.

2015-02-26 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15422 == Reported By:Stephen Kelly Assigned To:

Re: [cmake-developers] cmake install command expected performance?

2015-02-26 Thread Brad King
On 02/26/2015 02:18 PM, Robert Goulet wrote: turns out to be 5000+ file open/close Good catch! It looks like it's been that way since manifest generation was first added here: ENH: When installing project, write manifest http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=99feab35 I've

Re: [cmake-developers] Introduction and volunteering for the Matlab package

2015-02-26 Thread Raffi Enficiaud
Thanks! here is the patch then, replacing the previous one, rebased on 1416d214b3. Best, Raffi 0001-Simplified-workflow.patch Description: Binary data On 26 Feb 2015, at 18:52, Brad King brad.k...@kitware.com wrote: On 02/26/2015 12:06 PM, Raffi Enficiaud wrote: Is it possible to

Re: [cmake-developers] cmake install command expected performance?

2015-02-26 Thread Robert Goulet
Great, let us know if the test is clean! Cheers! -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Thursday, February 26, 2015 3:13 PM To: Robert Goulet; Joshua Clayton Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] cmake install command expected

Re: [cmake-developers] cmake install command expected performance?

2015-02-26 Thread Robert Goulet
Here is what we discovered. It looks like that when cmake write the install manifest file, it does it in a for_loop for each file, which in the end turns out to be 5000+ file open/close, and then our administrator controlled anti-virus checks the file each time, considerably slowing everything

[cmake-developers] [PATCH v7 2/4] Add XCTest Utilities

2015-02-26 Thread Gregor Jasny
Signed-off-by: Gregor Jasny gja...@googlemail.com --- Help/manual/cmake-modules.7.rst | 1 + Help/module/XCTestUtilities.rst | 1 + Modules/XCTestUtilities.cmake | 139 3 files changed, 141 insertions(+) create mode 100644

[cmake-developers] [PATCH v7 3/4] Add XCTest example to test Frameworks and Cocoa App Bundles

2015-02-26 Thread Gregor Jasny
Signed-off-by: Gregor Jasny gja...@googlemail.com --- Tests/CMakeLists.txt | 13 + Tests/XCTest/CMakeLists.txt| 59 ++ Tests/XCTest/CocoaExample/AppDelegate.h| 7 + Tests/XCTest/CocoaExample/AppDelegate.m| 18 +

[cmake-developers] [PATCH v7 4/4] Also test XCTest on command line

2015-02-26 Thread Gregor Jasny
Signed-off-by: Gregor Jasny gja...@googlemail.com --- Tests/CMakeLists.txt | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Tests/CMakeLists.txt b/Tests/CMakeLists.txt index 6afedf2..a2e2e24 100644 --- a/Tests/CMakeLists.txt +++ b/Tests/CMakeLists.txt @@

Re: [cmake-developers] [PATCH v6 0/2] Add XCTest Bundle Support

2015-02-26 Thread Gregor Jasny
Hello Brad, thank you for the review. In addition to the last series I added a test case also for the Makefile generator. On 26/02/15 15:50, Brad King wrote: The basic functionality is in good shape. My remaining comments are on the XCTestUtilities module that I hadn't fully reviewed before:

[cmake-developers] [PATCH] Pass CMAKE_VERBOSE_MAKEFILE value to Ninja Generator

2015-02-26 Thread Gregor Jasny
Ninja build system does not support a in-Makefile verbositiy switch. So we use cmake --build as a fall back to extract the CMAKE_VERBOSE_MAKEFILE property and pass it as an optional -v argument to Ninja. Signed-off-by: Gregor Jasny gja...@googlemail.com --- Source/CPack/cmCPackGenerator.cxx

Re: [cmake-developers] [ANNOUNCE] CMake 3.2.0-rc1 now ready for testing!

2015-02-26 Thread Orion Poplawski
On 02/17/2015 12:41 AM, Stephen Kelly wrote: Orion Poplawski wrote: On 02/13/2015 01:12 PM, Robert Maynard wrote: I am proud to announce that CMake 3.2 has entered the release candidate stage. We're getting a fair number of test failures on Fedora Rawhide (with gcc 5 c++11): This is a bug