Re: [cmake-developers] [PATCH 0/9] Xcode: Generate stable project files

Nice!! I agree with Eike: perhaps you could start the patch series by putting the verbose explanation in the text of the first commit, and explain "the following 8... commits all help to minimize the diffs between CMake generated project files and Xcode native project files." I love it when peopl

Re: [cmake-developers] [PATCH 0/9] Xcode: Generate stable project files

Am Montag, 13. April 2015, 21:37:57 schrieb Gregor Jasny: > Hello, > > this patch series aims to minimize deltas between the CMake Xcode > generator and Xcode itself. It was started by the observation that > if one makes any change to the project within Xcode (e.g. to see > how a variable is calle

[cmake-developers] [PATCH 5/9] Xcode: Properly indent PBXFileReference and PBXBuildFile

Move indent factor change behind indention of start-of-line. --- Source/cmXCodeObject.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/cmXCodeObject.cxx b/Source/cmXCodeObject.cxx index 33ce8cc..519545a 100644 --- a/Source/cmXCodeObject.cxx +++ b/Source/cmXCodeObject.

[cmake-developers] [PATCH 7/9] Xcode: PrintComment will prepend a whitespace itself before the comment

--- Source/cmXCode21Object.cxx | 2 +- Source/cmXCodeObject.cxx | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Source/cmXCode21Object.cxx b/Source/cmXCode21Object.cxx index 855e1ad..96f7b0f 100644 --- a/Source/cmXCode21Object.cxx +++ b/Source/cmXCode21Object.cxx @@ -31

[cmake-developers] [PATCH 6/9] Xcode: Do not add whitespace after attribute group opening brace

This suppresses the extra space that would be generated if the separator is a space. The conditional block is also used in this form elsewhere. --- Source/cmXCodeObject.cxx | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Source/cmXCodeObject.cxx b/Source/cmXCodeObject.cxx

[cmake-developers] [PATCH 9/9] Xcode: Refine quoting rules for Strings

$ and . do not need to be quoted, but brackets and * must be to not confuse the Xcode parser. --- Source/cmXCodeObject.cxx | 2 +- Tests/RunCMake/XcodeProject/XcodeFileType-check.cmake | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/cmXC

[cmake-developers] [PATCH 4/9] Xcode: Remove extra space in PBXProject comment

--- Source/cmGlobalXCodeGenerator.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx index 2e13692..4d98359 100644 --- a/Source/cmGlobalXCodeGenerator.cxx +++ b/Source/cmGlobalXCodeGenerator.cxx @@ -3386,7

[cmake-developers] [PATCH 1/9] Xcode: Indent using tabs

--- Source/cmXCodeObject.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/cmXCodeObject.cxx b/Source/cmXCodeObject.cxx index 5a90fd9..33ce8cc 100644 --- a/Source/cmXCodeObject.cxx +++ b/Source/cmXCodeObject.cxx @@ -81,7 +81,7 @@ void cmXCodeObject::Indent(int level, s

[cmake-developers] [PATCH 8/9] Xcode: Let PrintComment decide if the comment is non-empty

--- Source/cmXCode21Object.cxx | 4 Source/cmXCodeObject.cxx | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Source/cmXCode21Object.cxx b/Source/cmXCode21Object.cxx index 96f7b0f..f30f700 100644 --- a/Source/cmXCode21Object.cxx +++ b/Source/cmXCode21Object.cxx @@ -

[cmake-developers] [PATCH 3/9] Xcode: Add comment after root object

--- Source/cmGlobalXCodeGenerator.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx index be40c66..2e13692 100644 --- a/Source/cmGlobalXCodeGenerator.cxx +++ b/Source/cmGlobalXCodeGenerator.cxx @@ -3756,

[cmake-developers] [PATCH 2/9] Xcode: Sort Xcode objects by Id

Xcode keeps the objects ordered by the object id. Because cmake stores them into an unordered container at creation time they must be sorted before writing the pbxproj file. --- Source/cmGlobalXCodeGenerator.cxx | 16 Source/cmGlobalXCodeGenerator.h | 1 + 2 files changed, 17 i

[cmake-developers] [PATCH 0/9] Xcode: Generate stable project files

Hello, this patch series aims to minimize deltas between the CMake Xcode generator and Xcode itself. It was started by the observation that if one makes any change to the project within Xcode (e.g. to see how a variable is called internally) the user cannot diff the CMake project and the one store

Re: [cmake-developers] Should Ninja be marked non-experimental?

On 04/13/2015 02:09 PM, Stephen Kelly wrote: > There are a few limitations of Ninja (like lack of Fortran support), but I > think it is not experimental at this point. Yes, please. For some reason I thought we'd already dropped that from the documentation but I see it is still there. Thanks, -B

[cmake-developers] Should Ninja be marked non-experimental?

Hi, Following from: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/11260/focus=12940 Brad King wrote: > This was done with the Ninja generator when it was > introduced, though fortunately in that case we didn't have to > break anything IIRC. It is still documented as experime

[cmake-developers] [CMake 0015512]: CTest git update to specific commit reivision / CTEST_GIT_UPDATE_CUSTOM with multiple git commands

The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15512 == Reported By:trsystran Assigned To:

Re: [cmake-developers] [CMake] Bug in CMake GUI 3.2.1?

On 04/13/2015 04:28 PM, Robert Dailey wrote: I am running on Windows 8.1. Screenshots attached. Those are options for cmake itself rather than for the compiler: http://www.cmake.org/cmake/help/v3.2/manual/cmake.1.html Nils -- Powered by www.kitware.com Please keep messages on-topic and ch

Re: [cmake-developers] [CMake] Bug in CMake GUI 3.2.1?

I am running on Windows 8.1. Screenshots attached. On Mon, Apr 13, 2015 at 9:20 AM, Brad King wrote: > On 04/10/2015 12:26 PM, Robert Dailey wrote: >> I am noticing that after installing the official Windows installer for >> 3.2.1 release, CMake GUI looks different. Menu options have GCC >> speci

Re: [cmake-developers] [CMake] Bug in CMake GUI 3.2.1?

On 04/10/2015 12:26 PM, Robert Dailey wrote: > I am noticing that after installing the official Windows installer for > 3.2.1 release, CMake GUI looks different. Menu options have GCC > specific options and when I generate through the GUI for Visual Studio > 2013, my projects are missing preprocess

Re: [cmake-developers] FW: FW: Initial Attempt at Green Hill MULTI IDE Generator Support

On 04/12/2015 11:01 PM, Geoffrey Viola wrote: > Attached is the patch Thanks. I've applied it: GHS: removed hard coded flag and cleaned cmds http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c2e650bf and will squash it in before merging to 'master'. I also extended the topic with slight doc

[cmake-developers] [CMake 0015511]: Don't include failed tests in timing graph

The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15511 == Reported By:Gerald Hofmann Assigned To:

[cmake-developers] [CMake 0015510]: After 15.04 upgrade, cannot link against against pthread using C++11

The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15510 == Reported By:nickdesaulniers Assigned To: