Re: [cmake-developers] Code style auto-formatting

On Tue, 2015-11-17 at 08:14 +, Stuermer, Michael SP/HZA-ZSEP wrote: > In short, there is no fully automated style checking. If someone would > come up with a tool & configuration I would love to use this. So far I > tested astyle and the C++ edition of ReSharper (unfortunately quite >

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On 11/16/2015 03:14 PM, Levi Morrison wrote: > It seems my attachments are getting scrubbed or something? It was just that one message that was missing one. This one worked. >> How did you test these? For full testing we need the CMake test >> suite to pass with the Intel compilers. In

Re: [cmake-developers] Code style auto-formatting

> -Original Message- > From: Kislinskiy, Stefan [mailto:s.kislins...@dkfz-heidelberg.de] > Sent: Tuesday, November 17, 2015 10:11 AM > To: Stuermer, Michael SP/HZA-ZSEP; CMake Developers > Subject: AW: [cmake-developers] Code style auto-formatting > > Do you know ClangFormat[1]? Pretty

[cmake-developers] FindGTest.cmake and CMP0064

We’ve been getting a warning from FindGTest.cmake about CMP0064 when building SimpleITK.  The warning occurs at lines 127, 129 and 131 when the variable ${test_type} is equal to “TEST”.  With CMP0064 this TEST could be interpreted as commands in the if() and elseif() statements unless the policy

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

On 11/16/2015 10:52 PM, Robert Dailey wrote: > I also forgot to mention that this patch is based on the 'next' > branch. Originally it was based on 'master' but I rebased it to > 'next'. Let me know if this is correct. I'm assuming the master branch > is used for maintenance releases only and

[cmake-developers] [CMake 0015848]: Generalize RESOURCE target property to by used by all Bundles (not only by FRAMEWORK)

The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15848 == Reported By:gang65 Assigned To:

Re: [cmake-developers] FindGTest.cmake and CMP0064

Am 17.11.2015 17:08, schrieb David Chen: We’ve been getting a warning from FindGTest.cmake about CMP0064 when building SimpleITK. The warning occurs at lines 127, 129 and 131 when the variable ${test_type} is equal to “TEST”. With CMP0064 this TEST could be interpreted as commands in the if()

Re: [cmake-developers] CMake 3.40, CMAKE_C_STANDARD_COMPUTED_DEFAULT and LTO

On 11/17/2015 11:03 AM, Setze Post wrote: > First ever upstreamed upstreamed mail from me, please gently inform me > if I took the wrong route here. > Running Gentoo Linux x86_64 and compiling with LTO enabled in C*FLAGS, > the configuration stage seems to fail compiling CMake 3.4.0 as described >

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On Tue, Nov 17, 2015 at 6:50 AM, Brad King wrote: > On 11/16/2015 03:14 PM, Levi Morrison wrote: > > It seems my attachments are getting scrubbed or something? > > It was just that one message that was missing one. This one worked. > > >> How did you test these? For full

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On Tue, Nov 17, 2015 at 11:13 AM, Levi Morrison wrote: > On Tue, Nov 17, 2015 at 6:50 AM, Brad King wrote: > >> On 11/16/2015 03:14 PM, Levi Morrison wrote: >> > It seems my attachments are getting scrubbed or something? >> >> It was just that one

Re: [cmake-developers] Code style auto-formatting

On Tue, Nov 17, 2015 at 3:35 PM, Brad King wrote: > Hi Folks, > > For reference, the current CMake indentation style is: > > https://en.wikipedia.org/wiki/Indent_style#Whitesmiths_style > > but with 2 space indentation instead of 4 as shown on that page. > The style was

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On 11/17/2015 03:23 PM, Levi Morrison wrote: > Attached is the patch. Thanks. In the CompileFeatures test output one can see Detecting CXX compile features - failed Then in Tests/CompileFeatures/CMakeFiles/CMakeError.log one can see the error:

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

> > Also after fixing the above I see in > Tests/CompileFeatures/CMakeFiles/CMakeOutput.log the following: > > Detecting CXX [-std=c++14] compiler features compiled with the > following output: > ... > icpc: command line warning #10159: invalid argument for option '-std' > > This is

Re: [cmake-developers] [PATCH] FindBoost: Add imported targets

On 17-Nov-15 15:48, Roger Leigh wrote: On 17/11/2015 07:53, Ruslan Baratov wrote: On 16-Nov-15 21:01, rle...@codelibre.net wrote: I have attached a patch to add imported targets to FindBoost, in the form of Boost:: (e.g. Boost::date_time) or Boost::Boost as a generic interface library for

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On 11/17/2015 03:57 PM, Levi Morrison wrote: > Also, it is worth pointing out that some of the features are partially > supported in earlier versions, but in the FeatureTests.cmake I put it > only for the first version that claims complete compatibility > - is that the correct action? Yes,

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On Tue, Nov 17, 2015 at 1:23 PM, Levi Morrison wrote: > > I'm not sure how to edit Tests/CompileFeatures/CMakeLists.txt, though. >> > I don't even know what half of this file is trying to accomplish. >> > It seems like it is pure duplication of work; these checks are

Re: [cmake-developers] [PATCH] FindBoost: Add imported targets

On 17/11/2015 07:53, Ruslan Baratov wrote: On 16-Nov-15 21:01, rle...@codelibre.net wrote: I have attached a patch to add imported targets to FindBoost, in the form of Boost:: (e.g. Boost::date_time) or Boost::Boost as a generic interface library for header-only components. Since it's

Re: [cmake-developers] [CPackRPM] Configure RPM package group and name per component

2015-11-15 20:32 GMT+01:00 Markus Rickert : > Hi, > > similar to the previous patch for CPackDeb, the attached patch adds > component-specific settings for group and name of an RPM package. > > CPACK_RPM__PACKAGE_GROUP allows setting the group of the > component with the main

Re: [cmake-developers] Code style auto-formatting

Do you know ClangFormat[1]? Pretty popular choice these days. You just put a format description file into your repository (which can be based on popular styles + your exceptions to keep the file rather small). It can be integrated into many editors including the Visual Studio IDE. You probably

Re: [cmake-developers] Add command line options for deprecation message control

In particular, I moved the hunk below forward to "Modify dev warning options to affect deprecated warnings", the commit where it actually becomes needed because the default changes. I'm not sure I follow, which hunk are we talking about here? Please add a Help/release/dev/cmake-W-options.rst

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On 11/17/2015 01:13 PM, Levi Morrison wrote: > I have updated Modules/Compiler/Intel-CXX-FeatureTests.cmake. Great. > I'm not sure how to edit Tests/CompileFeatures/CMakeLists.txt, though. > I don't even know what half of this file is trying to accomplish. > It seems like it is pure duplication

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

> > > I'm not sure how to edit Tests/CompileFeatures/CMakeLists.txt, though. > > I don't even know what half of this file is trying to accomplish. > > It seems like it is pure duplication of work; these checks are saying > > EXPECT_C_STATIC_ASSERT=1 if some compiler conditions are true but > > I

Re: [cmake-developers] Code style auto-formatting

Hi Folks, For reference, the current CMake indentation style is: https://en.wikipedia.org/wiki/Indent_style#Whitesmiths_style but with 2 space indentation instead of 4 as shown on that page. The style was popular when CMake started (year 2000) but is not very widely used anymore. For Emacs,

[cmake-developers] [CMake 0015849]: Linker failure when WINDOWS_EXPORT_ALL_SYMBOLS and /bigobj are used together in a Win64 build.

The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=15849 == Reported By:Chris M Assigned To:

Re: [cmake-developers] Code style auto-formatting

On Tue, Nov 17, 2015 at 10:12 PM, Robert Dailey wrote: > On Tue, Nov 17, 2015 at 6:57 AM, Paul Smith wrote: >> On Tue, 2015-11-17 at 08:14 +, Stuermer, Michael SP/HZA-ZSEP wrote: >>> In short, there is no fully automated style checking. If

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On 11/17/2015 04:34 PM, Levi Morrison wrote: > On Tue, Nov 17, 2015 at 2:07 PM, Levi Morrison wrote: >>> icpc: command line warning #10159: invalid argument for option '-std' >> Hmm. Can you tell me what the value of -std was for that invocation? > > Hazarding a guess I think it might be gnu++14

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On Tue, Nov 17, 2015 at 2:38 PM, Brad King wrote: > On 11/17/2015 04:34 PM, Levi Morrison wrote: > > On Tue, Nov 17, 2015 at 2:07 PM, Levi Morrison wrote: > >>> icpc: command line warning #10159: invalid argument for option '-std' > >> Hmm. Can you tell me what the value

Re: [cmake-developers] Code style auto-formatting

On Tue, Nov 17, 2015 at 6:57 AM, Paul Smith wrote: > On Tue, 2015-11-17 at 08:14 +, Stuermer, Michael SP/HZA-ZSEP wrote: >> In short, there is no fully automated style checking. If someone would >> come up with a tool & configuration I would love to use this. So far I

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

On Tue, Nov 17, 2015 at 2:07 PM, Levi Morrison wrote: > Also after fixing the above I see in >> Tests/CompileFeatures/CMakeFiles/CMakeOutput.log the following: >> >> Detecting CXX [-std=c++14] compiler features compiled with the >> following output: >> ... >>