Re: [cmake-developers] CMake daemon-mode

2016-06-13 Thread Tobias Hunger
Hi Brad, I just rebased this branch on top of current master and pushed it. There were some conflicts. Best Regards, Tobias On Mon, Jun 13, 2016 at 4:16 PM, Brad King wrote: > On 06/10/2016 12:31 PM, Tobias Hunger wrote: >> I did try to do the changes you requested. The

[cmake-developers] daemon-mode: Infrastructure

2016-06-13 Thread Tobias Hunger
Hello, one important piece of feedback from the daemon-mode: Project structure discussion is that we need a policy to remove old code again. So I thought I should write up a bit about the infrastructure and versioning support of the daemon-mode branch I am working on. Basic Assumptions:

Re: [cmake-developers] daemon-mode: Project structure

2016-06-13 Thread Brad King
On 06/13/2016 03:12 PM, Stephen Kelly wrote: > I suggest switching gears and designing the initial protocol handshake and > version negotiation, and come back to this buildsystem description part of > the protocol later. > > Designing the how versioning the protocol works can include design and

Re: [cmake-developers] Problems when generating xcarchive from within Xcode

2016-06-13 Thread Brad King
On 06/13/2016 02:58 PM, Roman Wüger wrote: > I have successfully configured a project with CMake 3.5.2 so it > creates a valid Release and Debug *.app bundle which runs on iOS. > However if I build an archive in Xcode with "Product->Archive" > then the app bundle seems not complete under >

Re: [cmake-developers] daemon-mode: Project structure

2016-06-13 Thread Stephen Kelly
Tobias Hunger wrote: >> * Designing a protocol like this is hard (and not fast) > > We have been discussing this for about two years now. That's a misleading thing to say. Time since an effort or discussion started has never been a guideline for when something is ready for CMake master. > I

[cmake-developers] [ANNOUNCE] CMake 3.6.0-rc2 now ready for testing!

2016-06-13 Thread Robert Maynard
I am proud to announce the second CMake 3.6 release candidate. https://cmake.org/download/ Documentation is available at: https://cmake.org/cmake/help/v3.6 Release notes appear below and are also published at https://cmake.org/cmake/help/v3.6/release/3.6.html Some of the more significant

[cmake-developers] Problems when generating xcarchive from within Xcode

2016-06-13 Thread Roman Wüger
Hello, I have successfully configured a project with CMake 3.5.2 so it creates a valid Release and Debug *.app bundle which runs on iOS. However if I build an archive in Xcode with "Product->Archive" then the app bundle seems not complete under

Re: [cmake-developers] Review request: extract-cmMessenger branch

2016-06-13 Thread Stephen Kelly
On 06/13/2016 04:22 PM, Brad King wrote: > On 06/11/2016 08:14 AM, Stephen Kelly wrote: >> Thanks for your thorough review! I think I've fixed the errors I >> introduced while rebasing now. >> >> I'm not completely certain that the gymnastics I do with the >> cmListFileBacktrace in the parser in

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Ben Boeckel
On Mon, Jun 13, 2016 at 16:14:51 +0200, Daniel Pfeifer wrote: > On Mon, Jun 13, 2016 at 2:09 PM, Ben Boeckel wrote: > > Usually NULL means "unset". See properties, > > variable values, etc. As an output, any place which doesn't care should > > already be using

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

2016-06-13 Thread Brad King
Hi Christian, Thanks for working on this. On 06/12/2016 05:59 AM, Christian Schmidbauer wrote: > A similar idea has already been suggested in #10287 Yes. > and is required for bug #15594. That issue appears unrelated. Did you typo the number? > Help/command/find_library.rst

Re: [cmake-developers] cmCacheManager related changes

2016-06-13 Thread Brad King
On 06/10/2016 02:13 PM, Stephen Kelly wrote: > Things which do change in such a way should be accessed through > cmState::Snapshot, or classes which depend on cmState::Snapshot such as > cmState::Directory for directory properties, or some day cmState::Target for > target properties. That way

Re: [cmake-developers] CMake daemon-mode

2016-06-13 Thread Brad King
On 06/10/2016 12:31 PM, Tobias Hunger wrote: > I did try to do the changes you requested. The branch is here: > > https://github.com/hunger/CMake/commits/compileflags Thanks. I'm about to go on travel but should hopefully be able to look at that again when I return. -Brad -- Powered by

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Brad King
On 06/10/2016 05:43 PM, Daniel Pfeifer wrote: >> Please look at documenting this in CONTRIBUTING.rst once we resolve >> this discussion. > > ok. +1 to Steve's suggestion of putting it in cmake-developer(7). >>> So far it is pretty consistent. But how to name free functions and >>> macros? I

Re: [cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use

2016-06-13 Thread Brad King
On 06/12/2016 05:47 PM, Daniel Pfeifer wrote: > I have set up a dashboard build where all three mechanisms are enabled: [snip] > I have already drastically reduced the number of clang-tidy warnings > in the last weeks. I am currently experimenting with > include-what-you-use and will push some

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Daniel Pfeifer
On Mon, Jun 13, 2016 at 2:09 PM, Ben Boeckel wrote: > On Mon, Jun 13, 2016 at 00:03:29 +0200, Daniel Pfeifer wrote: >> Can you show an example? To be clear: We are looking for a function, >> that has a code path for `str == NULL` and a *different* codepath for >> `str[0]

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Ben Boeckel
On Mon, Jun 13, 2016 at 00:03:29 +0200, Daniel Pfeifer wrote: > Can you show an example? To be clear: We are looking for a function, > that has a code path for `str == NULL` and a *different* codepath for > `str[0] = '\0'`. As input to functions? Usually NULL means "unset". See properties,