[cmake-developers] [CpackIFW] Fix bug in cpack_ifw_configure_... commands

2016-07-07 Thread Konstantin Podsvirov
Hello, Brad!Can you also merge topic 'cpack-ifw-list-variable' to release branch?It's fix processing of LICENSES arguments of cpack_ifw_configure... commands where license display_name contain spaces. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http:/

Re: [cmake-developers] [CpackIFW] Fix bug in cpack_ifw_configure_... commands

2016-07-07 Thread Brad King
On 07/07/2016 07:43 AM, Konstantin Podsvirov wrote: > Can you also merge topic 'cpack-ifw-list-variable' to release branch? Does it fix a 3.6 regression or a bug in a 3.6 new feature? Fixes to long-standing bugs are not eligible to be backported to the release. Thanks, -Brad -- Powered by www.k

Re: [cmake-developers] [PATCH v3 2/7] Deprecate const char* SystemTools::GetEnv function

2016-07-07 Thread Brad King
On 07/06/2016 03:12 PM, Dāvis Mosāns wrote: > On Windows this function returns environment variable encoded > in ANSI codepage which might not match internally used encoding. [snip] > - static const char* GetEnv(const char* key); > - static const char* GetEnv(const std::string& key); > + DEPRECA

Re: [cmake-developers] [PATCH v3 4/7] For Windows encode process output to internally used encoding

2016-07-07 Thread Brad King
On 07/06/2016 03:12 PM, Dāvis Mosāns wrote: > Typically Windows applications (eg. MSVC compiler) use current console's > codepage for output to pipes so we need to encode that to internally used > encoding (KWSYS_ENCODING_DEFAULT_CODEPAGE). We can't do that here. KWSys Process is a low-level proc

Re: [cmake-developers] [CpackIFW] Fix bug in cpack_ifw_configure_... commands

2016-07-07 Thread Konstantin Podsvirov
15:44, 7 jul 2016 г., Brad King :On 07/07/2016 07:43 AM, Konstantin Podsvirov wrote: Can you also merge topic 'cpack-ifw-list-variable' to release branch?Does it fix a 3.6 regression or a bug in a 3.6 new feature?No.Fixes to long-standing bugs are not eligible to be backportedto the release.It's lo

Re: [cmake-developers] ExternalProject default downloaded file name

2016-07-07 Thread Brad King
On 07/06/2016 12:07 PM, Ruslan Baratov wrote: > Attaching rebased patch. Thanks, applied with some re-wording: ExternalProject: Use default file name if extracting from URL fails https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=af7da934 -Brad -- Powered by www.kitware.com Please keep me

Re: [cmake-developers] cmake -E capabilities

2016-07-07 Thread Tobias Hunger
Sorry for the late reply... we had a beta release and a new patch level release out this week and I had to fix some bugs in both:-) On Sun, Jul 3, 2016 at 1:30 PM, Stephen Kelly wrote: >> "KDevelop3", > > This generator should probably be removed/hidden by now. It has > confused users of more-re

Re: [cmake-developers] cmake -E capabilities

2016-07-07 Thread Tobias Hunger
Hello, On Tue, Jul 5, 2016 at 1:48 AM, Stephen Kelly , me, Stephen Kelly wrote: >>> Such a feature would also work with cmake projects if the user chooses to >>> use the XCode generator on mac or VS generator on Windows (or if someday >>> we have a multi-config Ninja generator or so). >> >> How is

[cmake-developers] [ANNOUNCE] CMake 3.6.0 available for download

2016-07-07 Thread Robert Maynard
I am proud to announce that CMake 3.6.0 is now available for download at: https://cmake.org/download/ Documentation is available at: https://cmake.org/cmake/help/v3.6 Release notes appear below and are also published at https://cmake.org/cmake/help/v3.6/release/3.6.html Some of the more si

[cmake-developers] [PATCH v4 1/4] On Windows use correct encoding for SystemTools::GetEnv

2016-07-07 Thread Dāvis Mosāns
On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv) instead and encode that. Also add SystemTools::HasEnv function. --- Source/kwsys/SystemTools.cxx| 78 +++

[cmake-developers] [PATCH v4 3/4] Use SystemTools::GetEnv and HasEnv functions

2016-07-07 Thread Dāvis Mosāns
--- Source/CPack/cmCPackGenerator.cxx | 8 +++--- Source/CTest/cmCTestCoverageHandler.cxx | 12 - Source/CTest/cmCTestCurl.cxx| 27 ++-- Source/CTest/cmCTestMultiProcessHandler.cxx | 8 +++--- Source/cmBuildCommand.cxx | 25

[cmake-developers] [PATCH v4 4/4] For Windows encode process output to internally used encoding

2016-07-07 Thread Dāvis Mosāns
Typically Windows applications (eg. MSVC compiler) use current console's codepage for output to pipes so we need to encode that to internally used encoding (KWSYS_ENCODING_DEFAULT_CODEPAGE). --- Source/cmExecProgramCommand.cxx| 1 + Source/cmExecuteProcessCommand.cxx | 1 + Source/cmProcessT

[cmake-developers] [PATCH v4 2/4] Deprecate const char* SystemTools::GetEnv function

2016-07-07 Thread Dāvis Mosāns
--- Source/kwsys/SystemTools.hxx.in | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/Source/kwsys/SystemTools.hxx.in b/Source/kwsys/SystemTools.hxx.in index 8f01e75..f6fc282 100644 --- a/Source/kwsys/SystemTools.hxx.in +++ b/Source/kwsys/SystemTools.hxx.in @@ -26

[cmake-developers] [PATCH v4 fixed 1/4] On Windows use correct encoding for SystemTools::GetEnv

2016-07-07 Thread Dāvis Mosāns
On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv) instead and encode that. Also add SystemTools::HasEnv function. --- Source/kwsys/SystemTools.cxx| 80 +++