[cmake-developers] GIT push access please

2014-02-15 Thread Dan Cristiu
Hi, I'd like to push a couple of changes to the VS11/12 generators. They are currently ignoring non-default CMake platforms, with the exception of WinCE. Found a bug related to this issue: http://public.kitware.com/Bug/view.php?id=14673 Mainly I've added support for generic Visual Studio pla

Re: [cmake-developers] GIT push access please

2014-02-16 Thread Dan Cristiu
Thanks Steve, that makes sense. I have my fork as well, was just waiting for someone to clear the waters with regards to reviewing and committing the changes. Anyhow, I realized I want to take it a step further anyway. On Sun, Feb 16, 2014 at 9:15 PM, Stephen Kelly wrote: > Dan Cristiu wr

[cmake-developers] VS10-12 generators deserve much more love

2014-02-16 Thread Dan Cristiu
Wanted to add a simple change to the VS11 generator to support non-default toolsets, but after taking another look through the code for the VS10 generator and above, I decided I wasn't happy with the result. It shows those files have been the result of years of patches, with much of the code just

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Dan Cristiu
hough would be happy with having a separate CMake that works better for Visual Studio. Dan On Mon, Feb 17, 2014 at 8:28 AM, Stephen Kelly wrote: > Dan Cristiu wrote: > > > Wanted to add a simple change to the VS11 generator to support > non-default > > toolsets, but

Re: [cmake-developers] VS10-12 generators deserve much more love

2014-02-17 Thread Dan Cristiu
at 2:14 PM, Brad King wrote: > On 02/16/2014 08:25 PM, Dan Cristiu wrote: > > I've decided to review the code in there and clean it to the point > > where the duplication is minimal. > > I would welcome such an effort. Can you cite some examples of > duplication that y