Re: [cmake-developers] adding FindJsonCpp

Hi, 2016-06-29 19:31 GMT+02:00 Ben Boeckel : > On Wed, Jun 29, 2016 at 17:36:45 +0200, Farbos a wrote: >> I have a concern with generating package configs: >> >> 1 It seems to contain absolute path, so not really portable with git. > > The actual config files are g

Re: [cmake-developers] adding FindJsonCpp

I have a concern with generating package configs: 1 It seems to contain absolute path, so not really portable with git. 2 It does not respect the naming of imported targets with `::`. As you can see here: https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#a-sample-find-module T

[cmake-developers] adding FindJsonCpp

Hi, I would like to add a find module: FindJsonCpp.cmake that I attached. the library github: https://github.com/open-source-parsers/jsoncpp. This library allows JSON manipulation. It's used by more than one person and I think it could useful to add a find module for this library. Thanks, -- A

[cmake-developers] handling components in Find****

Hi, I am trying to write a Find module with components and I am not sure of how it should be written. I attached the find module, Could someone tell me if I did it well? Thanks, -- Arnaud FARBOS FindILMBase.cmake Description: Binary data -- Powered by www.kitware.com Please keep messages o

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

I am not sure to understand why you removed GLEW_LIBRARY: -mark_as_advanced(GLEW_INCLUDE_DIR GLEW_LIBRARY) +mark_as_advanced(GLEW_INCLUDE_DIR) 2016-06-20 21:09 GMT+02:00 Brad King : > On 06/20/2016 10:52 AM, Farbos a wrote: >> Here is the patch fixed. > > Thanks, applied: > &

[cmake-developers] How can we add Find****

Hi, I was wondering how can we add new Find.cmake. For examples I don't see any FindTBB, FindJsonCpp ... and I think some of them are used a lot. So my question is, Who decide if we can add new Find*** ? Thanks, -- Arnaud FARBOS -- Powered by www.kitware.com Please keep messages on-topi

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

Brad, Here is the patch fixed. Thanks, 2016-06-20 16:17 GMT+02:00 Brad King : > On 06/20/2016 07:55 AM, Farbos a wrote: >> I added the Glew debug library to the FindGLEW.cmake, here is the patch. > > Good start. Here are some comments: > > * For compatibility

[cmake-developers] [PATCH] add debug glew to FindGLEW

Hi, I added the Glew debug library to the FindGLEW.cmake, here is the patch. Tell me if everything looks good and if I can do a pull request. Thanks, -- Arnaud FARBOS 0001-add-debug-glew-to-FindGLEW.patch Description: Binary data -- Powered by www.kitware.com Please keep messages on-topic