[cmake-developers] CMake 3.12: transitive OBJECT library failing

2018-07-18 Thread Levi Morrison
I have an issue in CMake 3.12 with using transitive OBJECT libraries.The basic skeleton is: cmake_minimum_required(VERSION 3.12) project(objectlib LANGUAGES CXX) add_library(box OBJECT box.cc box.hh) add_library(make_box OBJECT make_box.cc make_box.hh) target_link_libraries(make_box PUBLIC box)

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2016-11-02 Thread Levi Morrison
On Wed, Dec 2, 2015 at 8:40 AM, Brad King wrote: > On 12/02/2015 10:31 AM, Levi Morrison wrote: >> Hmm. What is the purpose of this module? I verified that indeed my >> changeset somehow breaks this test but I don't even understand what it >> is trying to do. At a glanc

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-12-02 Thread Levi Morrison
On Tue, Dec 1, 2015 at 11:11 AM, Brad King wrote: > On 12/01/2015 12:47 PM, Levi Morrison wrote: >> I am having trouble reproducing this failure. When I do an >> unrestricted ctest (test everything) it will fail, but if I do >> something like `ctest -VV -R WriteCompilerDet

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-12-01 Thread Levi Morrison
On Tue, Dec 1, 2015 at 7:11 AM, Brad King wrote: > On 11/30/2015 02:13 PM, Levi Morrison wrote: >> Hmm. > > Thanks. I applied it yesterday and merged to 'next' for testing: > > Features: Record standards and features for Intel C++ on UNIX > https://cmake.org

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-30 Thread Levi Morrison
On Mon, Nov 30, 2015 at 11:33 AM, Brad King wrote: > On 11/30/2015 01:18 PM, Levi Morrison wrote: >> My latest patch is attached. All tests seem to be working for me on >> the compiler versions I have access to. Can you check it for any >> glaring errors? > > Good.

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-30 Thread Levi Morrison
On Thu, Nov 19, 2015 at 9:28 AM, Levi Morrison wrote: > On Thu, Nov 19, 2015 at 8:41 AM, Brad King wrote: >> >> On 11/18/2015 08:00 PM, Levi Morrison wrote: >> > At a glance this seems to fix the issues in all versions. I will comb >> > through the output aga

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-19 Thread Levi Morrison
On Thu, Nov 19, 2015 at 8:41 AM, Brad King wrote: > On 11/18/2015 08:00 PM, Levi Morrison wrote: > > At a glance this seems to fix the issues in all versions. I will comb > > through the output again later when I have a fresh mind. > > Great! > > > +if (

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-18 Thread Levi Morrison
On Wed, Nov 18, 2015 at 3:34 PM, Levi Morrison wrote: > On Wed, Nov 18, 2015 at 1:06 PM, Brad King wrote: > >> On 11/18/2015 02:32 PM, Levi Morrison wrote: >> > After some other tweaks I am able to get Intel C++ compiler versions >> > 12.1.4 13.0.1, 14.0.0, 14.

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-18 Thread Levi Morrison
On Wed, Nov 18, 2015 at 1:06 PM, Brad King wrote: > On 11/18/2015 02:32 PM, Levi Morrison wrote: > > After some other tweaks I am able to get Intel C++ compiler versions > > 12.1.4 13.0.1, 14.0.0, 14.0.2, 15.0.0, 15.0.2, 15.0.3 to work! > > Both tests found by `ctest -R Comp

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-18 Thread Levi Morrison
On Wed, Nov 18, 2015 at 9:45 AM, Brad King wrote: > On 11/18/2015 11:20 AM, Levi Morrison wrote: > > I have fixed a smattering of issues and was able to get > > Intel versions 14.0.2 , 15.0.2 and 15.0.3 to pass the > > CompilerFeature tests! Hooray! > > Great! > &g

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-18 Thread Levi Morrison
On Tue, Nov 17, 2015 at 4:14 PM, Levi Morrison wrote: > On Tue, Nov 17, 2015 at 3:09 PM, Levi Morrison > wrote: > >> On Tue, Nov 17, 2015 at 2:38 PM, Brad King wrote: >> >>> On 11/17/2015 04:34 PM, Levi Morrison wrote: >>> > On Tue, Nov 17, 2015 at

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
On Tue, Nov 17, 2015 at 3:09 PM, Levi Morrison wrote: > On Tue, Nov 17, 2015 at 2:38 PM, Brad King wrote: > >> On 11/17/2015 04:34 PM, Levi Morrison wrote: >> > On Tue, Nov 17, 2015 at 2:07 PM, Levi Morrison wrote: >> >>> icpc: command line warning #1015

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
On Tue, Nov 17, 2015 at 2:38 PM, Brad King wrote: > On 11/17/2015 04:34 PM, Levi Morrison wrote: > > On Tue, Nov 17, 2015 at 2:07 PM, Levi Morrison wrote: > >>> icpc: command line warning #10159: invalid argument for option '-std' > >> Hmm. Can you tel

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
On Tue, Nov 17, 2015 at 2:07 PM, Levi Morrison wrote: > Also after fixing the above I see in >> Tests/CompileFeatures/CMakeFiles/CMakeOutput.log the following: >> >> Detecting CXX [-std=c++14] compiler features compiled with the >> following output: >>

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
> > Also after fixing the above I see in > Tests/CompileFeatures/CMakeFiles/CMakeOutput.log the following: > > Detecting CXX [-std=c++14] compiler features compiled with the > following output: > ... > icpc: command line warning #10159: invalid argument for option '-std' > > This is wit

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
On Tue, Nov 17, 2015 at 1:23 PM, Levi Morrison wrote: > > I'm not sure how to edit Tests/CompileFeatures/CMakeLists.txt, though. >> > I don't even know what half of this file is trying to accomplish. >> > It seems like it is pure duplicatio

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
> > > I'm not sure how to edit Tests/CompileFeatures/CMakeLists.txt, though. > > I don't even know what half of this file is trying to accomplish. > > It seems like it is pure duplication of work; these checks are saying > > EXPECT_C_STATIC_ASSERT=1 if some compiler conditions are true but > > I al

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
On Tue, Nov 17, 2015 at 11:13 AM, Levi Morrison wrote: > On Tue, Nov 17, 2015 at 6:50 AM, Brad King wrote: > >> On 11/16/2015 03:14 PM, Levi Morrison wrote: >> > It seems my attachments are getting scrubbed or something? >> >> It was just that one message that

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-17 Thread Levi Morrison
On Tue, Nov 17, 2015 at 6:50 AM, Brad King wrote: > On 11/16/2015 03:14 PM, Levi Morrison wrote: > > It seems my attachments are getting scrubbed or something? > > It was just that one message that was missing one. This one worked. > > >> How did you test these? F

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-16 Thread Levi Morrison
> > How did you test these? For full testing we need the CMake test >> suite to pass with the Intel compilers. In particular, tests with >> 'CompileFeatures' in their name cover this functionality. > > > I was able to build and use (or not use as appropriately) C++11 and C++14 > for a given proje

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-16 Thread Levi Morrison
On Mon, Nov 16, 2015 at 11:31 AM, Brad King wrote: > On 11/16/2015 12:21 PM, Levi Morrison wrote: > > I found and fixed a mistake in my macro. > > Great. Did you mean to attach the corrected version? > It seems my attachments are getting scrubbed or something? > I ha

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-16 Thread Levi Morrison
On Mon, Nov 16, 2015 at 9:54 AM, Levi Morrison wrote: > Note that the Intel compiler may be tricky because it simulates MSVC >> on Windows and GNU elsewhere. The needed options may vary across >> platforms, and our tables need to reflect this. > > > See the attached

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-16 Thread Levi Morrison
> > Note that the Intel compiler may be tricky because it simulates MSVC > on Windows and GNU elsewhere. The needed options may vary across > platforms, and our tables need to reflect this. See the attached patch; will the if UNIX check will suffice for now? 0001-Add-CXX_STANDARD-support-to-In

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-16 Thread Levi Morrison
On Mon, Nov 16, 2015 at 9:42 AM, Brad King wrote: > HI Levi, > > Thanks for coming forward to work on this! > > On 11/16/2015 11:34 AM, Levi Morrison wrote: > > Why is MSVC doing a version check around the CXX_STANDARD_DEFAULT? > > The version check delimits the set

Re: [cmake-developers] Add CXX_STANDARD support for Intel C++ compilers

2015-11-16 Thread Levi Morrison
Message was rejected – retrying. On Mon, Nov 16, 2015 at 9:31 AM, Levi Morrison wrote: > First off, this is my first attempt at a CMake contribution ever, so > please be gentle! > > I have a few questions about my patch, though: > > Why is MSVC doing a versio