Re: [cmake-developers] [CMake 0016030]: CMAKE_ASM_NASM_COMPILE_OBJECT lacks

2016-03-28 Thread Brad King
On 03/25/2016 06:27 PM, Gregor Jasny wrote: > I pushed a first commit to asm-includes topic but did not merge to next, > yet. Looking at your quoted patch I wonder if is missing as well? Yes, but that would have been missing before was split out too. The were split out long before. You'll

Re: [cmake-developers] [CMake 0016030]: CMAKE_ASM_NASM_COMPILE_OBJECT lacks

2016-03-25 Thread Gregor Jasny via cmake-developers
On 25/03/16 19:28, Brad King wrote: > On 03/25/2016 01:46 PM, Gregor Jasny via cmake-developers wrote: >> Does anyone see a reason to *not* prepend all with a ? > > I'm not particularly familiar with the ASM tooling landscape but > that prepend step is exactly what was done for all other

Re: [cmake-developers] [CMake 0016030]: CMAKE_ASM_NASM_COMPILE_OBJECT lacks

2016-03-25 Thread Brad King
On 03/25/2016 01:46 PM, Gregor Jasny via cmake-developers wrote: > Does anyone see a reason to *not* prepend all with a ? I'm not particularly familiar with the ASM tooling landscape but that prepend step is exactly what was done for all other languages in commit v3.4.0-rc1~342^2 (Factor an

Re: [cmake-developers] [CMake 0016030]: CMAKE_ASM_NASM_COMPILE_OBJECT lacks

2016-03-25 Thread Gregor Jasny via cmake-developers
Hello, On 22/03/16 17:10, Mantis Bug Tracker wrote: > Starting with CMake 3.4 the ASM_NASM language does not pass forward > include_directories(XYZ) to the nasm compiler line. > > As far as I can see is missing for other assemblers as well. When I grep for CMAKE_ASM * _COMPILE_OBJECT I get the