Re: [cmake-developers] [PATCH] fix use of CMAKE_REQUIRED_DEFINITIONS

2015-07-08 Thread Brad King
On 02/24/2015 09:47 AM, Brad King wrote: > On 02/24/2015 08:25 AM, Mark Abraham wrote: >> Some modules shoud use CMAKE_REQUIRED_FLAGS, not CMAKE_REQUIRED_DEFINITIONS, >> I think. > > Actually both technically support any flags, but the latter > only for legacy reasons. I agree CMAKE_REQUIRED_FLA

Re: [cmake-developers] [PATCH] fix use of CMAKE_REQUIRED_DEFINITIONS

2015-02-24 Thread Brad King
On 02/24/2015 08:25 AM, Mark Abraham wrote: > Some modules shoud use CMAKE_REQUIRED_FLAGS, not CMAKE_REQUIRED_DEFINITIONS, > I think. Actually both technically support any flags, but the latter only for legacy reasons. I agree CMAKE_REQUIRED_FLAGS is clearer for this purpose. I've applied the p

[cmake-developers] [PATCH] fix use of CMAKE_REQUIRED_DEFINITIONS

2015-02-24 Thread Mark Abraham
Hi, Some modules shoud use CMAKE_REQUIRED_FLAGS, not CMAKE_REQUIRED_DEFINITIONS, I think. Mark From ed93849e9635a67f6d8ae4256f9a8d8f13c1b8bb Mon Sep 17 00:00:00 2001 From: Mark Abraham Date: Tue, 24 Feb 2015 14:20:16 +0100 Subject: [PATCH] Fix incorrect use of CMAKE_REQUIRED_DEFINITIONS Variabl