Re: [cmake-developers] [REVIEW REQUEST] find_package(Protobuf CONFIG)

2015-08-03 Thread Konstantin Podsvirov
Hi, Brad! 03.08.2015, 23:26, "Brad King" : > On 08/02/2015 03:31 PM, Konstantin Podsvirov wrote: >> https://github.com/google/protobuf/pull/673 > > [snip] >> I try to make find_package(Protobuf [MODULE|CONFIG]) compatible. > > Thanks for working on this. Thanks for the FindProtobuf module > compat

Re: [cmake-developers] [REVIEW REQUEST] find_package(Protobuf CONFIG)

2015-08-03 Thread Brad King
On 08/02/2015 03:31 PM, Konstantin Podsvirov wrote: > https://github.com/google/protobuf/pull/673 [snip] > I try to make find_package(Protobuf [MODULE|CONFIG]) compatible. Thanks for working on this. Thanks for the FindProtobuf module compatibility layer. I tried your changes locally as of commi

[cmake-developers] [REVIEW REQUEST] find_package(Protobuf CONFIG)

2015-08-02 Thread Konstantin Podsvirov
Since may of this year, Google's Protocol Buffers are supplied with a CMake project to build with the MCVS by the compiler. Related issues: CMake issue: http://public.kitware.com/Bug/view.php?id=14833 Protobuf issue: https://github.com/google/protobuf/issues/578 The other day I opened a pull r