Re: [cmake-developers] [Review request] TopicFind GTK2_sigc++_c++11

2015-10-07 Thread Daniele E. Domenichelli
On 06/10/2015 19:25, Brad King wrote: > On 10/06/2015 12:20 PM, Daniele E. Domenichelli wrote: >> I updated the topic according to your comments. The new commit is this: >> >> FindGTK2: Enable c++11 for sigc++ 2.5.1 or later >> https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=33eb8fa >

Re: [cmake-developers] [Review request] TopicFind GTK2_sigc++_c++11

2015-10-06 Thread Brad King
On 10/06/2015 12:20 PM, Daniele E. Domenichelli wrote: > I updated the topic according to your comments. The new commit is this: > > FindGTK2: Enable c++11 for sigc++ 2.5.1 or later > https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=33eb8fa LGTM. > I'm not 100% sure that there aren'

Re: [cmake-developers] [Review request] TopicFind GTK2_sigc++_c++11

2015-10-06 Thread Daniele E. Domenichelli
Thanks Brad for the review. I updated the topic according to your comments. The new commit is this: FindGTK2: Enable c++11 for sigc++ 2.5.1 or later https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=33eb8fa On 06/10/2015 17:05, Brad King wrote: >> +set_property(TARGET GT

Re: [cmake-developers] [Review request] TopicFind GTK2_sigc++_c++11

2015-10-06 Thread Brad King
On 10/06/2015 07:51 AM, Daniele E. Domenichelli wrote: > According to the sigc++ changelog, starting with version 2.5.1, sigc++ > requires c++11 enabled, hence this patch. Thanks. > +* Starting with sigc++ 2.5.1, c++11 must be enabled in order to use > + sigc++. Generally we don't do release no

[cmake-developers] [Review request] TopicFind GTK2_sigc++_c++11

2015-10-06 Thread Daniele E. Domenichelli
Hello, Starting with some recent update on my system that updated sigc++ from 2.4.0 to 2.6.1, I noticed that a few GTK2Targets tests depending on sigc++ are failing. According to the sigc++ changelog, starting with version 2.5.1, sigc++ requires c++11 enabled, hence this patch. FindGTK2: Enabl