Re: [cmake-developers] adding FindJsonCpp

2016-06-30 Thread Farbos a
Hi, 2016-06-29 19:31 GMT+02:00 Ben Boeckel : > On Wed, Jun 29, 2016 at 17:36:45 +0200, Farbos a wrote: >> I have a concern with generating package configs: >> >> 1 It seems to contain absolute path, so not really portable with git. > > The actual config files are generated at build time, not commi

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Ben Boeckel
On Wed, Jun 29, 2016 at 17:36:45 +0200, Farbos a wrote: > I have a concern with generating package configs: > > 1 It seems to contain absolute path, so not really portable with git. The actual config files are generated at build time, not committed to the source control (template files with @vari

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Farbos a
I have a concern with generating package configs: 1 It seems to contain absolute path, so not really portable with git. 2 It does not respect the naming of imported targets with `::`. As you can see here: https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#a-sample-find-module T

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Brad King
On 06/29/2016 09:40 AM, Chuck Atkins wrote: > Given these issues, how about we "bring back" the FindJsonCpp module, > and alter it to explicitly look for the package config first. > It's still in the Modules tree and is actually used by CMake to build > itself, it'd just not installed. It is in So

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Chuck Atkins
> > The library builds using CMake and rather than using more code to find > itself, it should instead create a package configuration file which > contains the exact information CMake needs to use its install tree. See > the docs: > > > https://cmake.org/cmake/help/latest/manual/cmake-packages.7.ht

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Ben Boeckel
On Wed, Jun 29, 2016 at 11:02:30 +0200, Farbos a wrote: > I would like to add a find module: FindJsonCpp.cmake that I attached. > the library github: https://github.com/open-source-parsers/jsoncpp. > > This library allows JSON manipulation. It's used by more than one > person and I think it could

[cmake-developers] adding FindJsonCpp

2016-06-29 Thread Farbos a
Hi, I would like to add a find module: FindJsonCpp.cmake that I attached. the library github: https://github.com/open-source-parsers/jsoncpp. This library allows JSON manipulation. It's used by more than one person and I think it could useful to add a find module for this library. Thanks, -- A