[cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-06 Thread Alexander Neundorf
Hi, in KDE we have a simple macro which helps with creating a FooConfigVersion.cmake for installation along the FooConfig.cmake file. Since that Version.cmake file in most cases looks basically the same, I thought it is a good idea to provide such a basic file, and the only thing which has to

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-06 Thread Brad King
On 7/6/2011 4:00 PM, Alexander Neundorf wrote: > Since that Version.cmake file in most cases looks basically the same They're only the same within a specific community's versioning scheme. The whole reason find_package loads package-provided version check files is to avoid imposing a versioning/co

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-07 Thread Alexander Neundorf
On Thursday 07 July 2011, Brad King wrote: > On 7/6/2011 4:00 PM, Alexander Neundorf wrote: > > Since that Version.cmake file in most cases looks basically the same > > They're only the same within a specific community's versioning scheme. > The whole reason find_package loads package-provided ver

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-29 Thread Alexander Neundorf
On Thursday 07 July 2011, Alexander Neundorf wrote: > On Thursday 07 July 2011, Brad King wrote: > > On 7/6/2011 4:00 PM, Alexander Neundorf wrote: > > > Since that Version.cmake file in most cases looks basically the same > > > > They're only the same within a specific community's versioning sche

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-29 Thread Brad King
On 07/29/2011 12:04 PM, Alexander Neundorf wrote: > On Thursday 07 July 2011, Alexander Neundorf wrote: >> I think everything else are special cases, at least I can't think of other >> generic cases. >> How could another common scheme look like ? > > Any ideas ? Huh. I thought I responded to thi

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-30 Thread Rolf Eike Beer
> Another common scheme is to say that a version is compatible if the > major version number matches and incompatible otherwise.  I'm not > saying we have to try to include every common scheme.  I think just > the basic one you proposed originally is sufficient.  However, I'd > like to come up w

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-31 Thread Brad King
On 7/30/2011 3:33 AM, Rolf Eike Beer wrote: >> Another common scheme is to say that a version is compatible if the >> major version number matches and incompatible otherwise. I'm not >> saying we have to try to include every common scheme. I think just >> the basic one you proposed originally i

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-07-31 Thread Alexander Neundorf
On Sunday 31 July 2011, Brad King wrote: > On 7/30/2011 3:33 AM, Rolf Eike Beer wrote: > >> Another common scheme is to say that a version is compatible if the > >> major version number matches and incompatible otherwise. I'm not > >> saying we have to try to include every common scheme. I thin

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-08-01 Thread Brad King
On 07/31/2011 04:09 PM, Alexander Neundorf wrote: > I'm not sure which syntax I like better. The one with the macro feels more > high-level, but maybe hides too much what is actually going on (which is not > much). The one where the user must use configure_file() directly feels more > low-level,

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-08-01 Thread Alexander Neundorf
On Monday 01 August 2011, Brad King wrote: > On 07/31/2011 04:09 PM, Alexander Neundorf wrote: > > I'm not sure which syntax I like better. The one with the macro feels > > more high-level, but maybe hides too much what is actually going on > > (which is not much). The one where the user must use c

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-08-03 Thread Alexander Neundorf
On Monday 01 August 2011, Alexander Neundorf wrote: > On Monday 01 August 2011, Brad King wrote: > > On 07/31/2011 04:09 PM, Alexander Neundorf wrote: > > > I'm not sure which syntax I like better. The one with the macro feels > > > more high-level, but maybe hides too much what is actually going o

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-08-03 Thread Brad King
On 8/3/2011 4:00 PM, Alexander Neundorf wrote: Are you ok with this branch or are there issues left (...since it wasn't merged into master on Tuesday) ? I still need to find time to do further review and try it out. -Brad ___ cmake-developers mailing

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-08-04 Thread Brad King
On 8/3/2011 4:04 PM, Brad King wrote: On 8/3/2011 4:00 PM, Alexander Neundorf wrote: Are you ok with this branch or are there issues left (...since it wasn't merged into master on Tuesday) ? I still need to find time to do further review and try it out. Okay, here are a few comments from a q

Re: [cmake-developers] Adding MacroWriteBasicCMakeVersionFile.cmake file to cmake ?

2011-08-08 Thread Brad King
On 8/5/2011 5:14 PM, Alexander Neundorf wrote: (2) The documentation of the module has a few typos. Please proofread it again. Also, please use the word "compatible" rather than "suitable" to refer version acceptability. This makes the distinction noted above in (1). I hope it's better now.