On 09/01/2015 03:56 PM, Michael Scott wrote:
> The attached patch should maintain that compatibility now. If
> ZLIB_LIBRARY is set manually, then it won't try and find the library and
> it'll set the ZLIB_LIBRARIES and IMPORTED_LOCATION variables using the
> provided ZLIB_LIBRARY variable (if th
Thanks. We also need to be compatible with projects or scripts that
set ZLIB_LIBRARY themselves.
The attached patch should maintain that compatibility now. If
ZLIB_LIBRARY is set manually, then it won't try and find the library and
it'll set the ZLIB_LIBRARIES and IMPORTED_LOCATION variables
On 08/28/2015 05:37 PM, Michael Scott wrote:
> Okay, I've modified the patch to only add the DEBUG and RELEASE
> configurations when the corresponding library is found, and not set the
> generic IMPORTED_LOCATION property at all.
Thanks. We also need to be compatible with projects or scripts th
No, there doesn't need to be. Once IMPORTED_CONFIGURATIONS is populated
then we expect each configuration to have an IMPORTED_LOCATION_
setting too. CMake will choose an appropriate configuration and use
that location.
Okay, I've modified the patch to only add the DEBUG and RELEASE
configurat
On 08/25/2015 04:39 PM, Michael Scott wrote:
> I'm assuming that there should be a IMPORTED_LOCATION property defined
> in all cases as well?
No, there doesn't need to be. Once IMPORTED_CONFIGURATIONS is populated
then we expect each configuration to have an IMPORTED_LOCATION_
setting too. CMak
Please add each of the _DEBUG and _RELEASE configurations if and
only if the corresponding variables are set. Grep for mention of
IMPORTED_CONFIGURATIONS in other Modules/Find*.cmake files for
examples.
I'm assuming that there should be a IMPORTED_LOCATION property defined
in all cases as well
On 08/23/2015 04:41 PM, Michael Scott wrote:
> Okay no problem, I've changed the patch to use
> SelectLibraryConfigurations instead. I've also changed the last bit of
> the patch, to set the "IMPORTED_CONFIGURATIONS" target property as well
> when there's debug and release variants, to be consis
I don't think so. The debug suffix is a Windows-ism which you don't see
on UNIX.
Okay great, I thought this was the case.
One criticism of the patch: It's not using SelectLibraryConfigurations
to choose between the release and debug variants. Could it be updated
to do that for consistency?
On 23/08/2015 10:07, Michael Scott wrote:
Carrying on in the list of open issues to look at for contributing to
CMake, I've had a look at issue "15280 - FindZLIB module should find
debug and release variants". I've made some changes to the FindZLIB
module which should make it so that debug and re
Michael Scott wrote:
> Hi,
>
> Carrying on in the list of open issues to look at for contributing to
> CMake, I've had a look at issue "15280 - FindZLIB module should find
> debug and release variants". I've made some changes to the FindZLIB
> module which should make it so that debug and release
Hi,
Carrying on in the list of open issues to look at for contributing to
CMake, I've had a look at issue "15280 - FindZLIB module should find
debug and release variants". I've made some changes to the FindZLIB
module which should make it so that debug and release variants are found
as separa
11 matches
Mail list logo