Re: [cmake-developers] LZMA support

2014-07-30 Thread Brad King
On 07/30/2014 03:42 PM, Daniel Pfeifer wrote: > I think we should add packaging options like 'CPACK_BINARY_7Z' to > 'Modules/CPack.cmake'. Thanks. Patch applied: CPack: Add lzma-compressed package options http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9d93e099 > Maybe the options should

Re: [cmake-developers] LZMA support

2014-07-30 Thread Daniel Pfeifer
2014-07-30 15:58 GMT+02:00 Brad King : > On 07/23/2014 10:43 AM, Brad King wrote: > > I've merged the topic to 'next' for testing, but without the CPack > > or ExternalProject pieces. Likely some more portability fixes > > will be required after testing on the dashboard. Once that is clean > > I

Re: [cmake-developers] LZMA support

2014-07-30 Thread Brad King
On 07/23/2014 10:43 AM, Brad King wrote: > I've merged the topic to 'next' for testing, but without the CPack > or ExternalProject pieces. Likely some more portability fixes > will be required after testing on the dashboard. Once that is clean > I will add the other changes again on top of the re

Re: [cmake-developers] LZMA support

2014-07-23 Thread David Cole via cmake-developers
Thanks. Actually I think adding "xz" is incorrect anyway. We support compressed tarballs, not arbitrary compressed files. Therefore the list should be 7z|bz2|tar\\.gz|tar\\.xz|tgz|txz|zip correct? Well, then it should be tar.bz2, too. And since this is a regex anyway: 7z|tar\\.bz2|t

Re: [cmake-developers] LZMA support

2014-07-23 Thread Nils Gladitz
On 23.07.2014 16:43, Brad King wrote: Therefore the list should be 7z|bz2|tar\\.gz|tar\\.xz|tgz|txz|zip correct? bz2 -> tar\\.bz2 as well while you are at it(?) Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake

Re: [cmake-developers] LZMA support

2014-07-23 Thread Rolf Eike Beer
Am 23.07.2014 16:43, schrieb Brad King: On 07/23/2014 08:16 AM, David Cole wrote: Thanks to Daniel, great work on this contribution... This is a ton of tedious work, but it will be very useful. Thank you *very much*. +1 I've merged the topic to 'next' for testing, but without the CPack or Ext

Re: [cmake-developers] LZMA support

2014-07-23 Thread Brad King
On 07/23/2014 08:16 AM, David Cole wrote: > Thanks to Daniel, great work on this contribution... This is a ton of > tedious work, but it will be very useful. Thank you *very much*. +1 I've merged the topic to 'next' for testing, but without the CPack or ExternalProject pieces. Likely some more p

Re: [cmake-developers] LZMA support

2014-07-23 Thread David Cole via cmake-developers
Wow! Fantastic! Thanks to Daniel, great work on this contribution... This is a ton of tedious work, but it will be very useful. Thank you *very much*. Two minor comments -- in the commit at the tip of this topic: http://public.kitware.com/gitweb?p=stage/cmake.git;a=commitdiff;h=5201fb2e62fb06609

Re: [cmake-developers] LZMA support

2014-07-21 Thread Brad King
On 07/20/2014 05:22 AM, Daniel Pfeifer wrote: > * add the liblzma source from XZ Utils > * make it compile with CMake (by adding CMakeLists.txt etc.) > * make it compile in VC6 (by porting the source from C99 to C90) > * make cmlibarchive use cmliblzma (using cm_lzma.h) > * add cpack generators for

[cmake-developers] LZMA support

2014-07-20 Thread Daniel Pfeifer
Hi, In my liblzma branch (https://github.com/purpleKarrot/CMake/commits/liblzma), I did the following: * add the liblzma source from XZ Utils * make it compile with CMake (by adding CMakeLists.txt etc.) * make it compile in VC6 (by porting the source from C99 to C90) * make cmlibarchive use cmlib