Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-20 Thread Fraser Hutchison
On 20/11/2014 13:59, Brad King wrote: The latter will be merged to 'release' for 3.1.0-rc3. Thanks very much. Fraser. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-20 Thread Brad King
On 11/19/2014 4:26 AM, Fraser Hutchison wrote: > I've attached an updated patch Thanks. Applied here: Avoid if() quoted auto-dereference when checking for "MSVC" http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4d52cd36 and backported for the 'release' branch here: Avoid if() quoted auto-

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-19 Thread Ben Boeckel
On Wed, Nov 19, 2014 at 21:02:35 +, Fraser Hutchison wrote: > Yeah - no worries. I understand my previous mistake and what's in the > patch should now be OK I think. However, I'm more than happy if you > want to fix this another way and reject the patch - but it'd be good to > nail this be

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-19 Thread Fraser Hutchison
Yeah - no worries. I understand my previous mistake and what's in the patch should now be OK I think. However, I'm more than happy if you want to fix this another way and reject the patch - but it'd be good to nail this before v3.1 is released since it's pretty trivial. Cheers, Fraser. On 1

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-19 Thread Ben Boeckel
On Wed, Nov 19, 2014 at 11:05:48 -0500, Ben Boeckel wrote: And I now see Rolf's reply. Should have waited for email to refresh. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services t

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-19 Thread Ben Boeckel
On Tue, Nov 18, 2014 at 23:18:20 +, Fraser Hutchison wrote: > -if(CMAKE_C_SIMULATE_ID STREQUAL "MSVC" > - OR CMAKE_CXX_SIMULATE_ID STREQUAL "MSVC" > - OR CMAKE_Fortran_SIMULATE_ID STREQUAL "MSVC" > - OR CMAKE_C_COMPILER_ID STREQUAL "MSVC" > - OR CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" > +

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-19 Thread Fraser Hutchison
Hi Eike, Yes - my mistake - thanks!  I've attached an updated patch as per your suggestion. Cheers, Fraser. On 19/11/2014 06:29, Rolf Eike Beer wrote: Fraser Hutchison wrote: Hi there, CMake 3.1 (both release

Re: [cmake-developers] Patch for new warning caused by CMP0054

2014-11-18 Thread Rolf Eike Beer
Fraser Hutchison wrote: > Hi there, > > CMake 3.1 (both release candidates) now generate a CMP0054 warning when > configuring the following CMakeLists.txt in a clean build folder with MSVC > as the generator: > > cmake_minimum_required(VERSION 2.8) > enable_language(ASM_MASM) > > The warning is:

[cmake-developers] Patch for new warning caused by CMP0054

2014-11-18 Thread Fraser Hutchison
Hi there, CMake 3.1 (both release candidates) now generate a CMP0054 warning when configuring the following CMakeLists.txt in a clean build folder with MSVC as the generator: cmake_minimum_required(VERSION 2.8) enable_language(ASM_MASM) The warning