Re: [cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

On Mon, Mar 7, 2016 at 8:06 PM, Brad King wrote: > On 03/07/2016 02:49 PM, Bruce Stephens wrote: >> Moving the method into there worked cleanly. > > Thanks. I split that into a separate commit: Thanks. I wondered whether or not to do that separately. -- Powered by

Re: [cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

On 03/07/2016 02:49 PM, Bruce Stephens wrote: > Moving the method into there worked cleanly. Thanks. I split that into a separate commit: cmCommonTargetGenerator: Adopt AppendOSXVerFlag method https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1f2b39c6 Then I applied the main change:

Re: [cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

On Mon, Mar 7, 2016 at 6:06 PM, Brad King wrote: > On 03/01/2016 04:58 PM, Bruce Stephens wrote: >> I just copied the relevant code from the Makefiles generator. > > Thanks. Instead of copying, please look at moving the relevant > methods up to cmCommonTargetGenerator so

Re: [cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

On 03/01/2016 04:58 PM, Bruce Stephens wrote: > I just copied the relevant code from the Makefiles generator. Thanks. Instead of copying, please look at moving the relevant methods up to cmCommonTargetGenerator so it can be shared between the two generators instead. Thanks, -Brad -- Powered

[cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

I just copied the relevant code from the Makefiles generator. (And now I find gmail doesn't let me change the properties of the attachment. Bother.) 0001-Copy-logic-for-OS-X-dylib-versioning-to-Ninja-genera.patch Description: Binary data -- Powered by www.kitware.com Please keep messages