Hi,
I have been using CMake for about 7 years now and I maintain several modules in
my local projects. I am new to the cmake-developers list and I am offering a
new module, FindGSL.cmake, and offering to maintain it. I have maintained and
used this module for about 4 years supporting various
On 12/02/2014 12:06 PM, Thompson, KT wrote:
> A copy of my proposed module follows.
Great, thanks. Here are some comments.
> #=
This line should be dropped.
> # GSL_INCLUDE_DIR- Location of GSL header files.
> #
Brad King wrote:
> On 12/02/2014 12:06 PM, Thompson, KT wrote:
> > # GSL_ROOT_DIR - The top level directory of the discovered GSL
> > # install (useful if GSL is not in a standard
> > location)
> This and the other singular names should be documented as variables
> tha
Brad,
Thank you very much for the constructive comments concerning my submitted
FindGSL.cmake module. I believe I have addressed nearly all of your concerns
in the version shown below. I have two comments that may be useful:
1. The command "add_library(GSL::gsl UNKOWN IMPORTED)" generates war
On 12/02/2014 07:52 PM, Thompson, KT wrote:
> 1. The command "add_library(GSL::gsl UNKOWN IMPORTED)" generates
> warnings on platforms that do not support shared libraries.
That is a bug in the warning. Fixed:
add_library: Fix target type check for non-shared-lib platforms
http://cmake.org/git
Thompson, KT wrote:
> # GSL_INCLUDE_DIRS - Location of GSL header files.
> # GSL_LIBRARIES - The GSL libraries.
I'm curious: Given that you provide IMPORTED targets, what would a user need
these variables for? Do you have a particular use-case that needs them?
> # Windows with dlls
Brad,
Here is a repeat and reformatted version of the email I sent off list (sorry
about that). The attached file also addresses comments from Stephen Kelly
concerning IMPORTED_CONFIGURATIONS.
Brad King wrote:
> > The command "add_library(GSL::gsl UNKOWN IMPORTED)" generates
> > warnings on p
Stephen Kelly wrote:
>> # GSL_INCLUDE_DIRS - Location of GSL header files.
>> # GSL_LIBRARIES - The GSL libraries.
> I'm curious: Given that you provide IMPORTED targets, what would a user need
> these variables for? Do you have a particular use-case that needs them?
These are defined m
It looks like the mailing list doesn't like attachments (is that correct?).
Here's my updated FindGSL.cmake:
-kt
#.rst:
# FindGSL
#
#
# Find the native GSL includes and libraries.
#
# The GNU Scientific Library (GSL) is a numerical library for C and C++
# programmers. It is free softwa
Thompson, KT wrote:
> Stephen Kelly wrote:
>
>>> # GSL_INCLUDE_DIRS - Location of GSL header files.
>>> # GSL_LIBRARIES - The GSL libraries.
>
>> I'm curious: Given that you provide IMPORTED targets, what would a user
>> need these variables for? Do you have a particular use-case that n
On 12/04/2014 02:29 PM, Stephen Kelly wrote:
# GSL_INCLUDE_DIRS - Location of GSL header files.
# GSL_LIBRARIES - The GSL libraries.
>>
>> These are defined mostly as a courtesy for folks who don't use imported
>> targets yet.
>
> Yes. They are useful at least when a FindXXX doe
Thompson, KT wrote:
> It looks like the mailing list doesn't like attachments (is that
> correct?).
The attachment seems to have worked too:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/11783/focus=11829
> # These variables may optionally be set
> # to help this module
Brad King wrote:
> We're still learning the process of providing imported targets from
> find modules. As evidenced by the recent trouble with FindOpenGL:
I think the 'normal' case of them is well understood, at least as evidenced
by the Qt4 and GTK2 imported targets, which are the most-complete
Stephen Kelly wrote:
> This looks like it needs a suffix. GSL_CONFIG_EXECUTABLE would seem
> appropriate.
>> # Windows with dlls, but only Release libraries.
>> set_target_properties( GSL::gslcblas PROPERTIES
>> IMPORTED_LOCATION "${GSL_CBLAS_LIBRARY_DLL}"
> This s
On 12/09/2014 05:56 PM, Thompson, KT wrote:
> I made both of these recommended changes.
Thanks.
> set( GSL_INCLUDE_DIRS ${GSL_INCLUDE_DIR} CACHE PATH "Location of GSL include
> directives." )
> set( GSL_LIBRARIES ${GSL_LIBRARY};${GSL_CBLAS_LIBRARY} CACHE PATH "GSL
> libraries." )
These values
Brad,
I made the changes that you suggested wrt removing trailing whitespace and
removing variables from the cache. I also reverted a recent change by replacing
GSL_CONFIG_EXECUTABLE with GSL_CONFIG to remain consistent with the naming
conventions of PkgConfig.cmake. The updated FindGSL.cmake i
On 12/16/2014 01:36 PM, Thompson, KT wrote:
> I also reverted a recent change by replacing GSL_CONFIG_EXECUTABLE
> with GSL_CONFIG to remain consistent with the naming conventions
> of PkgConfig.cmake.
The convention is for libraries to be FOO_LIBRARY and executables
to be FOO_EXECUTABLE. PkgConf
17 matches
Mail list logo
