Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-11-02 Thread Nils Gladitz
Thanks! Let me know if there is anything else I can do. Nils On 10/31/2012 09:52 PM, David Cole wrote: Has anybody tried this anywhere else? I'm going to merge it to 'next' tomorrow, so that it will get tested on the dashboards after that. Just curious if there are any other known problems

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-11-02 Thread David Cole
You're welcome. I decided to wait till the dashboard cleans up again before merging this topic, but it should be in the next few days. On Fri, Nov 2, 2012 at 10:19 AM, Nils Gladitz glad...@sci-vis.de wrote: Thanks! Let me know if there is anything else I can do. Nils On 10/31/2012 09:52

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-31 Thread David Cole
Has anybody tried this anywhere else? I'm going to merge it to 'next' tomorrow, so that it will get tested on the dashboards after that. Just curious if there are any other known problems with it that I should squash in before doing that... Thanks, David On Tue, Oct 16, 2012 at 1:57 PM, David

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread David Cole
I had to do this to get the bootstrap version of CMake to work (and the BootstrapTest to pass): $ git diff diff --git a/Source/CMakeLists.txt b/Source/CMakeLists.txt index 9d46355..8bf6c40 100644 --- a/Source/CMakeLists.txt +++ b/Source/CMakeLists.txt @@ -264,8 +264,6 @@ set(SRCS cmTarget.cxx

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread Nils Gladitz
I certainly wouldn't mind though I'm not sure what that means. Do the changes in next still potentially make it into 2.8.10? Brad mentioned this would be on the TODO list for after 2.8.10. I've tried to run all tests successfully before submitting but I can't tell if any of those were called

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread David Cole
On Tue, Oct 16, 2012 at 10:12 AM, Nils Gladitz glad...@sci-vis.de wrote: I certainly wouldn't mind though I'm not sure what that means. Do the changes in next still potentially make it into 2.8.10? Going into 'next' is how stuff gets tested on the dashboards, and then later Brad and I merge

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread Nils Gladitz
Ah that might explain it ... I may have been using nmake on Windows and ninja on linux. Thanks! Nils On 10/16/2012 05:27 PM, David Cole wrote: On Tue, Oct 16, 2012 at 10:12 AM, Nils Gladitz glad...@sci-vis.de wrote: I certainly wouldn't mind though I'm not sure what that means. Do the

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-05 Thread Nils Gladitz
My initial thought was that NOTFOUND would be a good idea since it evaluates to false and the get_*_property commands also seem to use it. Looking at the documentation for if() again only -NOTFOUND as a suffix should evaluate to false though (I assume the documentation is incomplete here?).

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-05 Thread Brad King
On 10/05/2012 02:53 PM, Nils Gladitz wrote: My initial thought was that NOTFOUND would be a good idea since it evaluates to false and the get_*_property commands also seem to use it. I wrote the more general get_property command to replace those and the newer command uses empty string rather

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-29 Thread Nils Gladitz
I've updated the patch (attached) to include a TIMESTAMP sub-command for file as well (I hope indentation is also fixed). I only implemented the last modification time since creation and last access time are not implemented by all filesystems (or disabled for performance). Nils From

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-28 Thread Nils Gladitz
Why is TIMESTAMP misleading? Per default it currently outputs year, month, day, hour, minute and second. This includes both a date (a day on a calendar) as well as time (time of day). Timestamp I'd define as both date and time bound to an event (here the call or the (sub-)command). Date

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-28 Thread David Cole
On Fri, Sep 28, 2012 at 2:28 AM, Nils Gladitz glad...@sci-vis.de wrote: Why is TIMESTAMP misleading? Per default it currently outputs year, month, day, hour, minute and second. This includes both a date (a day on a calendar) as well as time (time of day). Timestamp I'd define as both date

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-28 Thread Rolf Eike Beer
Am 2012-09-28 08:44, schrieb Nils Gladitz: Sorry about the indentation ... I've still got a bit of trouble switching between coding conventions. Yeah, kernel style is the only sane one ;) On that note, are there documented coding conventions, coding guidelines or similar somewhere? My

[cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
I've tried creating a patch (attached; should apply to master) that adds a timestamp creation command. It builds on strftime but only allows a limited number of conversion specifiers. I tried to only allow those which are portable (C89), locale independent and of fixed range and length (with

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Brad King
On 09/27/2012 08:37 AM, David Cole wrote: Should we add a new command for this? Or should it be a sub-command of string( like RANDOM is? It should be a string(TIMESTAMP) subcommand. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Nils Gladitz
I wouldn't mind if this were a string subcommand. Initially I wanted something like this to tag package filenames. What gave me another push is this CMake test: http://open.cdash.org/testDetails.php?test=160586053build=2583145 It seems to fail on my system because it relies on the US locale

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Brad King
On 09/27/2012 08:59 AM, Brad King wrote: On 09/27/2012 08:37 AM, David Cole wrote: Should we add a new command for this? Or should it be a sub-command of string( like RANDOM is? It should be a string(TIMESTAMP) subcommand. We haven't added any top-level commands since 2008. At this point

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Eric Noulard
2012/9/27 David Cole david.c...@kitware.com: H. Good idea. Should we add a new command for this? Or should it be a sub-command of string( like RANDOM is? And... while we're at it, I've always thought we should add the ability to get the creation/modified/access times from a file via the

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Rolf Eike Beer
Eric Noulard wrote: 2012/9/27 David Cole david.c...@kitware.com: H. Good idea. Should we add a new command for this? Or should it be a sub-command of string( like RANDOM is? And... while we're at it, I've always thought we should add the ability to get the

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-09-27 Thread Rolf Eike Beer
Am Donnerstag, 27. September 2012, 17:10:20 schrieb Nils Gladitz: I've tried to reimplement this as a sting sub-command (patch attached). Looks good, but the indentation looks wrong at some places. signature.asc Description: This is a digitally signed message part. -- Powered by