[PATCH v2] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls

2019-07-01 Thread Markus Elfring
From: Markus Elfring Date: Mon, 1 Jul 2019 10:00:39 +0200 The function “devm_ioremap_resource” contains appropriate error reporting. Thus it can be questionable to present another error message at other places. Provide design options for the adjustment of affected source code by the means of the

Re: [PATCH v2] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls

2019-07-01 Thread Enrico Weigelt, metux IT consult
On 01.07.19 10:10, Markus Elfring wrote: Hi folks, > +@script:python to_do depends on org@ > +p << or.p; > +@@ > +coccilib.org.print_todo(p[0], > +"WARNING: An error message is probably not needed > here because the devm_ioremap_resource() function contains appropriate er

Re: [v2] Coccinelle: Suppression of warnings?

2019-07-01 Thread Markus Elfring
> By the way: do we have any mechanism for explicitly suppressing > individual warnings (some kind of annotation), I do not know such an accepted specification interface (for the handling together with SmPL scripts) so far. How would you identify possibly unwanted messages in a safe way? > when

Re: [PATCH v2] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls

2019-07-01 Thread Julia Lawall
On Mon, 1 Jul 2019, Enrico Weigelt, metux IT consult wrote: > On 01.07.19 10:10, Markus Elfring wrote: > > Hi folks, > > > +@script:python to_do depends on org@ > > +p << or.p; > > +@@ > > +coccilib.org.print_todo(p[0], > > +"WARNING: An error message is probably not nee