Re: [Cocci] [PATCH 20/32] parsing_c: ast_c: Add Cast attributes

2020-05-03 Thread Julia Lawall
On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Add cast attributes to the C AST. This is a list of attributes in the > Cast type of the C AST. > > Signed-off-by: Jaskaran Singh > --- > parsing_c/ast_c.ml | 2 +- > parsing_c/ast_c.mli | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [Cocci] [PATCH 22/32] parsing_c: pretty_print_c: Reflect Cast attributes

2020-05-03 Thread Julia Lawall
On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to the SmPL AST. Print these attributes in > pretty_print_c.ml. > > Signed-off-by: Jaskaran Singh > --- > parsing_c/pretty_print_c.ml | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git

Re: [Cocci] [PATCH 15/32] parsing_cocci: visitor_ast: Visit cast attributes

2020-05-03 Thread Julia Lawall
On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to AST0 of SmPL. Visit these attributes in the AST0 -> AST julia > SmPL AST visitor. > > Signed-off-by: Jaskaran Singh > --- > parsing_cocci/visitor_ast.ml | 10 ++ > 1 file changed, 6 insertions(+), 4

Re: [Cocci] [PATCH 09/32] parsing_cocci: arity: Reflect Cast attributes

2020-05-03 Thread Julia Lawall
On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to the SmPL AST. Reflect these changes in > arity.ml. > > Signed-off-by: Jaskaran Singh > --- > parsing_cocci/arity.ml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/parsing_cocci/arity.ml

Re: [Cocci] [PATCH 03/32] parsing_cocci: parser: Parse cast attributes

2020-05-03 Thread Julia Lawall
On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to the SmPL ASTs. Parse these attributes in > the SmPL parser and place them in the SmPL AST. The added production > only supports attributes after the type and before the expression. It would be good to say that on

Re: [Cocci] [PATCH 01/32] parsing_c: parser: Pass attribute list from type_name

2020-05-03 Thread Julia Lawall
On Tue, 28 Apr 2020, Jaskaran Singh wrote: > To add Cast attributes to the C AST, pass attributes from the type_name > rule of the C parser. I'm not sure what you mean by "pass". Normally, one passes something to something else, but it's not clear what the something else is. > >

Re: [Cocci] Checking the application of the SmPL isomorphism “drop_else”

2020-05-03 Thread Markus Elfring
> I hoped for another clarification also for the message “warning: iso drop_else > does not match the code below on line 55” (and the corresponding debug > display). I imagine that there is another bit of fine-tuning possible. >> There is an isomorphism that drops else's in ifs, but that only