Re: [Cocci] [PATCH 1/5] Coccinelle: put_device: Adjust a message construction

2019-07-06 Thread Masahiro Yamada
On Mon, May 13, 2019 at 5:59 PM Markus Elfring wrote: > > From: Markus Elfring > Date: Tue, 7 May 2019 11:20:48 +0200 > > The Linux coding style tolerates long string literals so that > the provided information can be easier found also by search tools > like grep. > Thus simplify a message constr

Re: [Cocci] [1/5] Coccinelle: put_device: Adjust a message construction

2019-05-13 Thread Markus Elfring
> I realize that you don't like it, although I have no idea why. > Does it make the code slower? Would you like to compare the run time characteristics from creating and looking up an identifier for a Python variable to direct passing of a concatenated string for the desired function call? > I t

Re: [Cocci] [1/5] Coccinelle: put_device: Adjust a message construction

2019-05-13 Thread Julia Lawall
On Mon, 13 May 2019, Markus Elfring wrote: > >> Thus simplify a message construction in a SmPL rule by concatenating text > >> with two plus operators less. > > > > Is there any way to unindent, so that the string doesn't exceed 80 > > characters, > > or at least no so much? > > How does your

Re: [1/5] Coccinelle: put_device: Adjust a message construction

2019-05-13 Thread Markus Elfring
>> Thus simplify a message construction in a SmPL rule by concatenating text >> with two plus operators less. > > Is there any way to unindent, so that the string doesn't exceed 80 characters, > or at least no so much? How does your concern fit to the string literal tolerance from the Linux coding

Re: [PATCH 1/5] Coccinelle: put_device: Adjust a message construction

2019-05-13 Thread Julia Lawall
On Mon, 13 May 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 May 2019 11:20:48 +0200 > > The Linux coding style tolerates long string literals so that > the provided information can be easier found also by search tools > like grep. > Thus simplify a message construction in

[PATCH 1/5] Coccinelle: put_device: Adjust a message construction

2019-05-13 Thread Markus Elfring
From: Markus Elfring Date: Tue, 7 May 2019 11:20:48 +0200 The Linux coding style tolerates long string literals so that the provided information can be easier found also by search tools like grep. Thus simplify a message construction in a SmPL rule by concatenating text with two plus operators le