Re: [5/5] Coccinelle: put_device: Merge two SmPL when constraints into one

2019-05-13 Thread Markus Elfring
>> Combine the exclusion specifications into a disjunction for the semantic >> patch language so that this argument is referenced only once there. … > NACK. This hurts readability I suggest to reconsider such readability concerns once more. Can corresponding software limitations be adjusted any

Re: [PATCH 5/5] Coccinelle: put_device: Merge two SmPL when constraints into one

2019-05-13 Thread Julia Lawall
On Mon, 13 May 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 13 May 2019 09:55:22 +0200 > > A single parameter was repeated for a function call in two SmPL > when constraints. > Combine the exclusion specifications into a disjunction for the semantic > patch language so that

[Cocci] [PATCH 5/5] Coccinelle: put_device: Merge two SmPL when constraints into one

2019-05-13 Thread Markus Elfring
From: Markus Elfring Date: Mon, 13 May 2019 09:55:22 +0200 A single parameter was repeated for a function call in two SmPL when constraints. Combine the exclusion specifications into a disjunction for the semantic patch language so that this argument is referenced only once there.