Menu item key equiv mods not correct

2013-08-15 Thread Steve Mills
When adding some certain-mode-only menus, we scan the existing menus to temporarily remove key equivs that are also in the new menu. They're put back later. However, something isn't right when I ask for each menu item's modifiers. Our Edit menu has Select All, which is command-a. Another menu

Re: Menu item key equiv mods not correct

2013-08-15 Thread Ken Thomases
On Aug 15, 2013, at 2:31 PM, Steve Mills wrote: When adding some certain-mode-only menus, we scan the existing menus to temporarily remove key equivs that are also in the new menu. They're put back later. However, something isn't right when I ask for each menu item's modifiers. Our Edit

Re: Menu item key equiv mods not correct

2013-08-15 Thread Steve Mills
On Aug 15, 2013, at 14:39:56, Ken Thomases k...@codeweavers.com wrote: Shifted key equivalents which use letter keys are usually represented with capital letters, not NSShiftKeyMask. You're using a case-insensitive match, so you're catching those. Use a case-sensitive match and you should