[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221817558 --- Diff: core/sql/parser/sqlparser.y --- @@ -13280,13 +13288,130 @@ table_expression : from_clause where_clause sample_clause

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221817891 --- Diff: core/sql/parser/sqlparser.y --- @@ -13280,13 +13288,130 @@ table_expression : from_clause where_clause sample_clause

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221821123 --- Diff: core/sql/optimizer/RelExpr.h --- @@ -525,7 +540,7 @@ class RelExpr : public ExprNode // QSTUFF //

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221824983 --- Diff: core/sql/executor/ExExeUtil.h --- @@ -4172,6 +4173,48 @@ class ExExeUtilLobInfoPrivateState : public ex_tcb_private_state protected:

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221821938 --- Diff: core/sql/executor/ExExeUtil.h --- @@ -4138,6 +4138,7 @@ class ExExeUtilLobInfoTableTcb : public ExExeUtilTcb DONE_ };

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221489512 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -1515,6 +1515,9 @@ $1~String1 8034 Z 9 ADVANCED MAJOR DB

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221818448 --- Diff: core/sql/parser/sqlparser.y --- @@ -13836,9 +13960,16 @@ query_spec_body : query_select_list table_expression access_type optional_lock_

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221489667 --- Diff: core/sql/comexe/ComTdbExeUtil.cpp --- @@ -3028,3 +3028,59 @@ Lng32 ComTdbExeUtilLobInfo::unpack(void * base, void * reallocator)

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221816282 --- Diff: core/sql/parser/sqlparser.y --- @@ -13280,13 +13288,130 @@ table_expression : from_clause where_clause sample_clause

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221819747 --- Diff: core/sql/optimizer/RelExpr.h --- @@ -1439,6 +1459,7 @@ class RelExpr : public ExprNode enum Flags { EXPAND_SHORT_ROWS = 0

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221820929 --- Diff: core/sql/optimizer/ValueDesc.cpp --- @@ -4555,7 +4555,7 @@ void ValueIdSet::unparse(NAString &result, NAString connectorText;

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221496330 --- Diff: core/sql/parser/ParKeyWords.cpp --- @@ -862,7 +863,7 @@ ParKeyWord ParKeyWords::keyWords_[] = { ParKeyWord("PREPARE",TO

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221819571 --- Diff: core/sql/optimizer/SynthType.cpp --- @@ -7291,3 +7291,11 @@ const NAType * SplitPart::synthesizeType() )

[GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...

2018-10-01 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1688#discussion_r221818361 --- Diff: core/sql/parser/sqlparser.y --- @@ -13280,13 +13288,130 @@ table_expression : from_clause where_clause sample_clause

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221723371 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp --- @@ -9246,26 +9280,44 @@ short CmpSeabaseDDL::executeSeabaseDDL(DDLExpr * ddlExpr, ExprNode * ddlNo

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221740561 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -563,32 +795,332 @@ void CmpSeabaseDDL::dropSeabaseLibrary(StmtDDLDropLibrary * dropLibraryNod

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221716066 --- Diff: core/sql/optimizer/NARoutine.cpp --- @@ -393,6 +411,14 @@ NARoutine::NARoutine(const QualifiedName &name, char parallelism[5];

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221698725 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE; } + + +Int32

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221692726 --- Diff: core/sqf/sqenvcom.sh --- @@ -200,6 +207,7 @@ export DTM_COMMON_JAR=trafodion-dtm-cdh-${TRAFODION_VER}.jar export SQL_JAR=trafodion-sql-cdh

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221723122 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp --- @@ -9246,26 +9280,44 @@ short CmpSeabaseDDL::executeSeabaseDDL(DDLExpr * ddlExpr, ExprNode * ddlNo

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221747417 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1925,3 +2730,568 @@ short CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface * cliInter

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221726951 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -563,32 +795,332 @@ void CmpSeabaseDDL::dropSeabaseLibrary(StmtDDLDropLibrary * dropLibraryNod

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221698323 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE; } + + +Int32

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221719056 --- Diff: core/sql/regress/tools/rgrCleanup --- @@ -0,0 +1,4 @@ +#temp solution to cleanup udr cached files +#can be removed when cleanup mechanis

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221746525 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1925,3 +2730,568 @@ short CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface * cliInter

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221695191 --- Diff: core/sql/sqlcomp/CmpDDLCatErrorCodes.h --- @@ -69,7 +69,7 @@ enum CatErrorCode { CAT_FIRST_ERROR = 1000 , CAT_CATALOG_ALR

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221696072 --- Diff: core/sql/cli/sqlcli.h --- @@ -1,4 +1,4 @@ -/** +/***

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221699218 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE; } + + +Int32

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221713729 --- Diff: core/sql/common/ComMisc.cpp --- @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName( return FALSE; } + + +Int32

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221746810 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLroutine.cpp --- @@ -1925,3 +2730,568 @@ short CmpSeabaseDDL::createSeabaseLibmgrCPPLib(ExeCliInterface * cliInter

[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

2018-10-01 Thread zellerh
Github user zellerh commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1721#discussion_r221720911 --- Diff: core/sql/regress/udr/FILTER001 --- @@ -21,6 +21,6 @@ # @@@ END COPYRIGHT @@@ sed " -s#[^ ]*/TEST001.dll#dir/TEST001.dll#g