[GitHub] trafodion pull request #1759: [TRAFODION-3237] Fix incorrect PCode optimizat...

2018-12-10 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1759 [TRAFODION-3237] Fix incorrect PCode optimization When an interval literal was referenced twice or more in an INSERT/SELECT in expressions with different INTERVAL types, the PCode

[GitHub] trafodion pull request #1756: [TRAFODION-3243] Avoid dereference of deleted ...

2018-12-05 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1756 [TRAFODION-3243] Avoid dereference of deleted NAString in UPDATE STATISTICS In the HSColGroupStruct destructor, move the call to HSColGroupStruct::freeISMemory up to the front, before the

[GitHub] trafodion pull request #1750: [TRAFODION-3238] ODBC can not connect to serve...

2018-11-29 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1750#discussion_r237702542 --- Diff: win-odbc64/security_dll/native/source/secpwd.cpp --- @@ -217,8 +221,25 @@ SecPwd::SecPwd(const char *dir, const char* fileName

[GitHub] trafodion pull request #1750: [TRAFODION-3238] ODBC can not connect to serve...

2018-11-28 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1750#discussion_r237304832 --- Diff: win-odbc64/security_dll/native/source/secpwd.cpp --- @@ -217,8 +221,25 @@ SecPwd::SecPwd(const char *dir, const char* fileName

[GitHub] trafodion pull request #1750: [TRAFODION-3238] ODBC can not connect to serve...

2018-11-28 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1750#discussion_r237304599 --- Diff: win-odbc64/security_dll/native/source/secpwd.cpp --- @@ -217,8 +221,25 @@ SecPwd::SecPwd(const char *dir, const char* fileName

[GitHub] trafodion pull request #1748: [TRAFODION-3236] fix the issue of buffer overr...

2018-11-23 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1748#discussion_r236024891 --- Diff: core/sqf/src/tm/tm.cpp --- @@ -2789,7 +2789,7 @@ void tm_process_msg(BMS_SRE *pp_sre) { short lv_ret

[GitHub] trafodion pull request #1741: [TRAFODION-3190] expression involving NULL sho...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1741#discussion_r235216010 --- Diff: core/sql/exp/exp_bool.cpp --- @@ -96,7 +96,7 @@ ex_expr::exp_return_type ex_branch_clause::eval(char *op_data[], switch

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235207369 --- Diff: core/sql/executor/HiveClient_JNI.cpp --- @@ -68,6 +68,27 @@ char* HiveClient_JNI::getErrorText(HVC_RetCode errEnum) return (char

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235210675 --- Diff: core/sql/optimizer/hiveHook.h --- @@ -140,31 +145,42 @@ struct hive_sd_desc char* nullFormat_; NABoolean

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235206682 --- Diff: core/sql/executor/HiveClient_JNI.cpp --- @@ -42,17 +43,16 @@ static const char* const hvcErrorEnumStr[] = ,"Java exception in

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235211297 --- Diff: core/sql/sqlcomp/CmpDescribe.cpp --- @@ -2355,10 +2355,134 @@ short CmpDescribeHiveTable ( NAString colString(buf

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235211551 --- Diff: core/sql/sqlcomp/CmpDescribe.cpp --- @@ -2355,10 +2355,134 @@ short CmpDescribeHiveTable ( NAString colString(buf

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235206424 --- Diff: core/sql/executor/HiveClient_JNI.cpp --- @@ -42,17 +43,16 @@ static const char* const hvcErrorEnumStr[] = ,"Java exception in

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r235211107 --- Diff: core/sql/sqlcomp/CmpDescribe.cpp --- @@ -2355,10 +2355,134 @@ short CmpDescribeHiveTable ( NAString colString(buf

[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-19 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1747#discussion_r234716204 --- Diff: core/conn/odb/src/odb.c --- @@ -10076,6 +10114,7 @@ static int Oloadbuff(int eid) clock_gettime(CLOCK_MONOTONIC, &

[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-19 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1747#discussion_r234715228 --- Diff: core/conn/odb/src/odb.c --- @@ -6246,7 +6248,8 @@ static void Oload(int eid) trt[16]; /* translit to array

[GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...

2018-11-19 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1747#discussion_r234717573 --- Diff: core/conn/odb/src/odb.c --- @@ -14685,6 +14743,56 @@ static void addGlobalPointer(void *ptr) globalPointers[nGlobalPointers

[GitHub] trafodion pull request #1739: [TRAFODION-3230] The number of error message i...

2018-11-07 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1739#discussion_r231655749 --- Diff: core/conn/odb/src/odb.c --- @@ -10183,6 +10183,7 @@ static int Oloadbuff(int eid) } Oi

[GitHub] trafodion pull request #1728: [TRAFODION-2626] Make logs directory location ...

2018-10-17 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1728#discussion_r226129024 --- Diff: core/sql/sqludr/SqlUdrPredefLogReader.cpp --- @@ -530,37 +530,28 @@ void ReadCppEventsUDFInterface::processData(UDRInvocationInfo &

[GitHub] trafodion pull request #1728: [TRAFODION-2626] Make logs directory location ...

2018-10-17 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1728#discussion_r226128603 --- Diff: core/sql/sqludr/SqlUdrPredefLogReader.cpp --- @@ -530,37 +530,28 @@ void ReadCppEventsUDFInterface::processData(UDRInvocationInfo &

[GitHub] trafodion pull request #1730: [TRAFODION-3223] Don't scale down for non-Puts...

2018-10-17 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1730 [TRAFODION-3223] Don't scale down for non-Puts when estimating row counts The estimateRowCount code in HBaseClient.java tried to scale down row counts by the proportion of non-Put cel

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r225695077 --- Diff: core/sql/optimizer/NATable.cpp --- @@ -6805,46 +6809,94 @@ void NATable::getPrivileges(TrafDesc * priv_desc) ComSecurityKeySet

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r225662018 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -1665,10 +1665,10 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs( if (ComUser

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r225659935 --- Diff: core/sql/common/ComSecurityKey.cpp --- @@ -191,33 +216,41 @@ bool buildSecurityKeys( const int32_t userID, return false

[GitHub] trafodion pull request #1723: TRAFODION - 3218 User still has privilege afte...

2018-10-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1723#discussion_r225658074 --- Diff: core/sql/cli/Context.cpp --- @@ -4199,19 +4219,35 @@ RETCODE ContextCli::setDatabaseUserByName(const char *userName

[GitHub] trafodion pull request #1718: [TRAFODION-3214] ODBC error message is truncat...

2018-09-26 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1718#discussion_r220703185 --- Diff: win-odbc64/odbcclient/drvr35/cdiag.cpp --- @@ -378,15 +378,15 @@ SQLRETURN CDiagRec::GetDiagRec(SQLSMALLINT RecNumber

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-27 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r213061994 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -11290,6 +11295,99 @@ ID --- 1 row(s) selected

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-27 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r213061831 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -442,7 +444,10 @@ the expressions have NULL values

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-27 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r213061940 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -11290,6 +11295,99 @@ ID --- 1 row(s) selected

[GitHub] trafodion pull request #1704: [TRAFODION-2952] large amount of data will cau...

2018-08-27 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1704#discussion_r213058744 --- Diff: core/sql/cli/Cli.cpp --- @@ -10599,7 +10599,10 @@ static Lng32 SeqGenCliInterfaceUpdAndValidateMulti( numTries

[GitHub] trafodion pull request #1704: [TRAFODION-2952] large amount of data will cau...

2018-08-27 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1704#discussion_r213058185 --- Diff: core/sql/sqlcomp/DefaultConstants.h --- @@ -2946,6 +2946,12 @@ enum DefaultConstants // this is used to change cache size of

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-22 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r212092534 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -11290,6 +11295,99 @@ ID --- 1 row(s) selected

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-22 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r212092254 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -11290,6 +11295,99 @@ ID --- 1 row(s) selected

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-22 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r212091583 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -442,7 +444,10 @@ the expressions have NULL values

[GitHub] trafodion pull request #1698: [TRAFODION-2968] update SQL manual for MySQL f...

2018-08-22 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1698#discussion_r212091436 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -442,7 +444,10 @@ the expressions have NULL values

[GitHub] trafodion pull request #1699: [TRAFODION-2404] enhance the regexpr performan...

2018-08-20 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1699#discussion_r211423746 --- Diff: core/sql/exp/exp_like.cpp --- @@ -513,11 +512,16 @@ ex_expr::exp_return_type ExRegexpClauseChar::eval(char *op_data

[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...

2018-08-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1695#discussion_r210705551 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc --- @@ -776,14 +776,105 @@ of digits in the fractional seconds and

[GitHub] trafodion pull request #1695: [TRAFODION-3184] Correct Syntax Descriptions a...

2018-08-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1695#discussion_r210709602 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc --- @@ -776,14 +776,105 @@ of digits in the fractional seconds and

[GitHub] trafodion pull request #1682: [TRAFODION-3177] Error when selecting count(*)...

2018-08-15 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1682#discussion_r210397770 --- Diff: core/sql/sqludr/SqlUdrPredefLogReader.cpp --- @@ -1311,17 +1362,19 @@ bool ReadCppEventsUDFInterface::validateEvent(const

[GitHub] trafodion pull request #1684: [TRAFODION-3179] Correct Syntax Descriptions o...

2018-08-07 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1684#discussion_r208400577 --- Diff: docs/spj_guide/src/asciidoc/_chapters/develop_spjs.adoc --- @@ -83,19 +83,19 @@ PIC[TURE] X^1^ + NCHAR + NCHAR VARYING

[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...

2018-08-07 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1683#discussion_r208396395 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_clauses.adoc --- @@ -1053,8 +1053,7 @@ expressions in each item must be the same as the

[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...

2018-08-07 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1683#discussion_r208397031 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -31,20 +31,27 @@ and expressions that you can use in

[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...

2018-08-06 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1679#discussion_r208041994 --- Diff: core/sqf/src/tm/tools/dtmci.cpp --- @@ -1801,6 +1801,20 @@ int main(int argc, char *argv[]) << "&

[GitHub] trafodion pull request #1677: TRAFODION-3146 Support ANSI OVERLAY function

2018-08-02 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1677#discussion_r207411473 --- Diff: core/sql/exp/exp_function.cpp --- @@ -786,13 +786,18 @@ ExpRaiseErrorFunction::ExpRaiseErrorFunction (Attributes **attr

[GitHub] trafodion pull request #1677: TRAFODION-3146 Support ANSI OVERLAY function

2018-08-02 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1677#discussion_r207412672 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -1535,6 +1535,7 @@ $1~String1 8142 Z 9 ADVANCED INFRM

[GitHub] trafodion pull request #1658: [TRAFODION-3155] implemented the OVERLAPS pred...

2018-08-01 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1658#discussion_r206907388 --- Diff: core/sql/generator/GenPreCode.cpp --- @@ -7518,6 +7518,53 @@ ItemExpr * AggrMinMax::preCodeGen(Generator * generator) return this

[GitHub] trafodion pull request #1658: [TRAFODION-3155] implemented the OVERLAPS pred...

2018-07-31 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1658#discussion_r206726135 --- Diff: core/sql/generator/GenPreCode.cpp --- @@ -7518,6 +7518,53 @@ ItemExpr * AggrMinMax::preCodeGen(Generator * generator) return this

[GitHub] trafodion pull request #1658: [TRAFODION-3155] implemented the OVERLAPS pred...

2018-07-31 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1658#discussion_r206722914 --- Diff: core/sql/generator/GenPreCode.cpp --- @@ -7518,6 +7518,53 @@ ItemExpr * AggrMinMax::preCodeGen(Generator * generator) return this

[GitHub] trafodion pull request #1669: Fix for TRAFODION-3112

2018-07-31 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1669#discussion_r206662600 --- Diff: core/sql/regress/compGeneral/EXPECTEDTOK --- @@ -1,5 +1,5 @@ sqlparser.y: warning: 61 shift/reduce conflicts [-Wconflicts-sr

[GitHub] trafodion pull request #1669: Fix for TRAFODION-3112

2018-07-31 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1669#discussion_r206663223 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -85,7 +85,7 @@ 1083 Z 9 BEGINNER MAJOR DBADMIN Validation for constraint $0

[GitHub] trafodion pull request #1664: [TRAFODION-2884] Multiple fixes with Name Serv...

2018-07-26 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1664#discussion_r205629519 --- Diff: core/sqf/monitor/linux/process.cxx --- @@ -4775,46 +4818,85 @@ void CProcessContainer::Bcast (struct message_def *msg) char

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-25 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r205178175 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1663: [TRAFODION-3152] Fix bug in UPDATE STATISTICS ...

2018-07-24 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1663 [TRAFODION-3152] Fix bug in UPDATE STATISTICS CREATE SAMPLE If the "_HIVESTATS_" schema didn't already exist, UPDATE STATISTICS ... CREATE SAMPLE and UPDATE STATISTICS ..

[GitHub] trafodion pull request #1653: [TRAFODION-3156] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1653#discussion_r204917685 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -4437,35 +4437,670 @@ interval value expression. It

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204860494 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9098,30 +9305,606 @@ is one of the following

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204862408 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204862138 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204862754 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204860831 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204862548 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204862675 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9066,13 +9066,220 @@ second argument describes the

[GitHub] trafodion pull request #1656: [TRAFODION-3159] Add *Syntax Descriptions and ...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1656#discussion_r204860415 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc --- @@ -9098,30 +9305,606 @@ is one of the following

[GitHub] trafodion pull request #1658: [TRAFODION-3155] implemented the OVERLAPS pred...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1658#discussion_r204855585 --- Diff: core/sql/parser/sqlparser.y --- @@ -19430,6 +19432,124 @@ exists_predicate : TOK_EXISTS rel_subquery

[GitHub] trafodion pull request #1658: [TRAFODION-3155] implemented the OVERLAPS pred...

2018-07-24 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1658#discussion_r204855399 --- Diff: core/sql/parser/sqlparser.y --- @@ -19430,6 +19432,124 @@ exists_predicate : TOK_EXISTS rel_subquery

[GitHub] trafodion pull request #1660: [TRAFODION-3158] Make EncodedValue error handl...

2018-07-23 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1660 [TRAFODION-3158] Make EncodedValue error handling more robust This pull request makes two code changes to function EncodedValue::constructorFunction. 1. Formerly, the function

[GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...

2018-07-18 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1645#discussion_r203555447 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -390,25 +390,27 @@ alter-action is: column-definition is

[GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...

2018-07-18 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1645#discussion_r203555402 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -390,25 +390,27 @@ alter-action is: column-definition is

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-18 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203554845 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-18 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203554900 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is

[GitHub] trafodion pull request #1652: [TRAFODION-3153] Fix issue with CREATE EXTERNA...

2018-07-18 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1652 [TRAFODION-3153] Fix issue with CREATE EXTERNAL TABLE Change the parser production for CREATE EXTERNAL TABLE to point to the proper token for the optional IF NOT EXISTS clause. You can

[GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...

2018-07-17 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1645#discussion_r203094486 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -390,25 +390,27 @@ alter-action is: column-definition is

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-17 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203093950 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-17 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r203091243 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is

[GitHub] trafodion pull request #1642: [TRAFODION-3136] New featrue: improve on split...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1642#discussion_r202838056 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -1450,6 +1450,7 @@ $1~String1 4494 Z 9 BEGINNER MINOR

[GitHub] trafodion pull request #1642: [TRAFODION-3136] New featrue: improve on split...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1642#discussion_r202841083 --- Diff: core/sql/exp/exp_function.cpp --- @@ -2746,6 +2754,59 @@ ex_expr::exp_return_type ex_function_unixtime::eval(char *op_data

[GitHub] trafodion pull request #1642: [TRAFODION-3136] New featrue: improve on split...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1642#discussion_r202841611 --- Diff: docs/messages_guide/src/asciidoc/_chapters/binder_msgs.adoc --- @@ -2919,3 +2919,15 @@ Use of predefined UDF is deprecated and this

[GitHub] trafodion pull request #1642: [TRAFODION-3136] New featrue: improve on split...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1642#discussion_r202842026 --- Diff: docs/messages_guide/src/asciidoc/_chapters/binder_msgs.adoc --- @@ -2919,3 +2919,15 @@ Use of predefined UDF is deprecated and this

[GitHub] trafodion pull request #1642: [TRAFODION-3136] New featrue: improve on split...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1642#discussion_r202839688 --- Diff: core/sql/optimizer/SynthType.cpp --- @@ -7139,3 +7139,79 @@ const NAType * ItmLeadOlapFunction::synthesizeType() return result

[GitHub] trafodion pull request #1649: [TRAFODION-3148] Fix UPDATE STATS bug on Hive ...

2018-07-16 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1649 [TRAFODION-3148] Fix UPDATE STATS bug on Hive tables w/ column _DIVISION_1_ This fixes a bug concerning sample tables created by UPDATE STATISTICS on Hive tables. When a Hive

[GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1645#discussion_r202732987 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -390,25 +390,27 @@ alter-action is: column-definition is

[GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1645#discussion_r202733241 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -756,6 +758,86 @@ Alter TABLE PRODUCT ALTER COLUMN vend_id

[GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1645#discussion_r202732750 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -390,25 +390,27 @@ alter-action is: column-definition is

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202728022 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202731971 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -3712,6 +3716,60 @@ ATTRIBUTES ALIGNED FORMAT --- SQL operation

[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...

2018-07-16 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1644#discussion_r202727823 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -2963,18 +2963,22 @@ column-definition is

[GitHub] trafodion pull request #1641: [TRAFODION-3140] Update QQ ID and other news o...

2018-07-12 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1641 [TRAFODION-3140] Update QQ ID and other news on Apache Trafodion main page This change updates the QQ ID for Chinese discussions on the Apache Trafodion main page. It also updates

[GitHub] trafodion pull request #1640: [TRAFODION-3135] Remove anachronisms from keyw...

2018-07-11 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1640 [TRAFODION-3135] Remove anachronisms from keyword tables This set of changes removes references to reserved words from a predecessor product from key word tables in parser/ParKeyWords.cpp

[GitHub] trafodion pull request #1639: [TRAFODION-3138] Part 1 of removing static SQL...

2018-07-11 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1639 [TRAFODION-3138] Part 1 of removing static SQL code from ustats + one bug fix This pull request contains two changes: 1. It removes obsolete static SQL code from two ustat modules

[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support

2018-07-11 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1633#discussion_r201728736 --- Diff: win-odbc64/odbcclient/drvr35/lob.cpp --- @@ -54,8 +54,12 @@ namespace ODBC { CStmt *pStatement = (CStmt *)hstmt

[GitHub] trafodion pull request #1637: [TRAFODION-3131] Fix some reserved and non-res...

2018-07-10 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1637 [TRAFODION-3131] Fix some reserved and non-reserved word issues This set of changes does the following: 1. Fixes some issues with reserved words not being recognized as reserved

[GitHub] trafodion pull request #1632: [TRAFODION-3127] tochar enhancement

2018-07-10 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1632#discussion_r201484661 --- Diff: core/sql/exp/exp_datetime.cpp --- @@ -3294,6 +3338,39 @@ convertMonthToStr(Lng32 value, char *&result, UInt32 width) re

[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support

2018-07-10 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1633#discussion_r201439488 --- Diff: win-odbc64/Common/TransportBase.h --- @@ -134,6 +134,8 @@ enum SRVR_API { SRVR_API_SQLFASTEXECDIRECT

[GitHub] trafodion pull request #1633: [TRAFODION-2743] Windows ODBC LOB support

2018-07-09 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1633#discussion_r201149361 --- Diff: win-odbc64/Common/TransportBase.h --- @@ -134,6 +134,8 @@ enum SRVR_API { SRVR_API_SQLFASTEXECDIRECT

[GitHub] trafodion pull request #1634: [TRAFODION-3132] Add and Correct Descriptions ...

2018-07-09 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1634#discussion_r201148299 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_language_elements.adoc --- @@ -396,21 +396,22 @@ length of 8 bytes. * _precision_

[GitHub] trafodion pull request #1635: [TRAFODION-2926] Fix issue-tracking URL on web...

2018-07-09 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1635 [TRAFODION-2926] Fix issue-tracking URL on web site Change the URL from http: to https: You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafodion pull request #1630: [TRAFODION 3128] Fix issue with interval liter...

2018-07-05 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request: https://github.com/apache/trafodion/pull/1630 [TRAFODION 3128] Fix issue with interval literals in multi-column histograms When an INTERVAL SECOND(m,n) column participates in a multi-column histogram, EncodedValue::constructorFunction

[GitHub] trafodion pull request #1587: [TRAFODION-3094] Add Syntax and Examples for *...

2018-07-02 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1587#discussion_r199651804 --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc --- @@ -4342,6 +4363,45 @@ DELETE FROM invent.partsupp WHERE suppnum NOT IN

[GitHub] trafodion pull request #1622: [TRAFODION-3118] Improve on parts of EXTRACT

2018-07-02 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1622#discussion_r199649187 --- Diff: core/sql/parser/sqlparser.y --- @@ -500,6 +501,7 @@ static void enableMakeQuotedStringISO88591Mechanism() %token TOK_CARDINALITY

[GitHub] trafodion pull request #1622: [TRAFODION-3118] Improve on parts of EXTRACT

2018-07-02 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1622#discussion_r199650319 --- Diff: core/sql/optimizer/SynthType.cpp --- @@ -4416,6 +4416,22 @@ const NAType *Extract::synthesizeType() return NULL

[GitHub] trafodion pull request #1622: [TRAFODION-3118] Improve on parts of EXTRACT

2018-07-02 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1622#discussion_r199649960 --- Diff: core/sql/regress/seabase/TEST030 --- @@ -98,6 +98,11 @@ select HOUR(interval '5:2:15:36.33' day to second(2)) from (values(

  1   2   3   4   >