[GitHub] trafodion pull request #1694: [TRAFODION-3183] fetch huge data give rise to ...

2018-12-20 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1694#discussion_r243471435 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4ResultSet.java --- @@ -2779,6 +2779,19 @@ public boolean next() throws

[GitHub] trafodion pull request #1694: [TRAFODION-3183] fetch huge data give rise to ...

2018-12-20 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1694#discussion_r243471406 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4ResultSet.java --- @@ -2779,6 +2779,19 @@ public boolean next() throws

[GitHub] trafodion pull request #1762: Fix for hive/TEST003 failure. Created a known ...

2018-12-14 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1762 Fix for hive/TEST003 failure. Created a known failure to accommodate the costing change between Jenkins and contributor's work space environments. You can merge this pull request

[GitHub] trafodion pull request #1758: Fix for hive/TEST003 failure seen in recent bu...

2018-12-10 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1758 Fix for hive/TEST003 failure seen in recent builds. You can merge this pull request into a Git repository by running: $ git pull https://github.com/selvaganesang/trafodion

[GitHub] trafodion pull request #1754: [TRAFODION-2408] Remove code that empties the ...

2018-12-04 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1754#discussion_r238717456 --- Diff: core/sql/exp/ExpLOBaccess.cpp --- @@ -1779,77 +1779,23 @@ Ex_Lob_Error ExLob::allocateDesc(ULng32 size, Int64 , Int64

[GitHub] trafodion pull request #1754: [TRAFODION-2408] Remove code that empties the ...

2018-11-30 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1754#discussion_r238029142 --- Diff: core/sql/exp/ExpLOBaccess.cpp --- @@ -1779,77 +1779,23 @@ Ex_Lob_Error ExLob::allocateDesc(ULng32 size, Int64 , Int64

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Refactor hive meta calls to b...

2018-11-29 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r237713985 --- Diff: core/sql/sqlcomp/CmpDescribe.cpp --- @@ -2355,10 +2355,134 @@ short CmpDescribeHiveTable ( NAString colString(buf

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Refactor hive meta calls to b...

2018-11-29 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r237713928 --- Diff: core/sql/sqlcomp/CmpDescribe.cpp --- @@ -2355,10 +2355,134 @@ short CmpDescribeHiveTable ( NAString colString(buf

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Refactor hive meta calls to b...

2018-11-29 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r237711864 --- Diff: core/sql/executor/HiveClient_JNI.cpp --- @@ -42,17 +43,16 @@ static const char* const hvcErrorEnumStr[] = ,"Java exception in

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Refactor hive meta calls to b...

2018-11-29 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1746#discussion_r237711771 --- Diff: core/sql/executor/HiveClient_JNI.cpp --- @@ -42,17 +43,16 @@ static const char* const hvcErrorEnumStr[] = ,"Java exception in

[GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...

2018-11-14 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1746 [TRAFODION-3234] Add support for hive partitioned tables Refactored the interaction with hive metastore to use the efficient APIs to obtain the necessary information to construct

[GitHub] trafodion pull request #1694: [TRAFODION-3183] fetch huge data give rise to ...

2018-11-12 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1694#discussion_r232720071 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4ResultSet.java --- @@ -2779,6 +2779,19 @@ public boolean next() throws

[GitHub] trafodion pull request #1735: [TRAFODION-3225] Obscure cores seen in RMS and...

2018-10-30 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1735 [TRAFODION-3225] Obscure cores seen in RMS and logger related code wh… …en Trafodion is stressed Process de-registration is now logged to understand the spate of cores seen

[GitHub] trafodion pull request #1706: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-27 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1706 [TRAFODION-3171] Refactor Hive sequence file reading to use the new i… …mplementation Fix for hive/TEST006 failure in daily build You can merge this pull request into a Git

[GitHub] trafodion pull request #1702: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-24 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1702 [TRAFODION-3171] Refactor Hive sequence file reading to use the new i… …mplementation Fix for the following exception seen while accessing hive sequence file with the new

[GitHub] trafodion pull request #1696: [TRAFODION-3110] Refactor LOB access to use th...

2018-08-23 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1696#discussion_r212400283 --- Diff: core/sql/exp/ExpLOBaccess.cpp --- @@ -2455,16 +2455,59 @@ Ex_Lob_Error ExLob::readDataToHdfsFile(char *tgtFileName, Int64 offset, Int64

[GitHub] trafodion pull request #1696: [TRAFODION-3110] Refactor LOB access to use th...

2018-08-23 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1696#discussion_r212400148 --- Diff: core/sql/exp/ExpLOBaccess.cpp --- @@ -2455,16 +2455,59 @@ Ex_Lob_Error ExLob::readDataToHdfsFile(char *tgtFileName, Int64 offset, Int64

[GitHub] trafodion pull request #1697: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-15 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1697 [TRAFODION-3171] Refactor Hive sequence file reading to use the new i… …mplementation Disabled parallel plan in hive/TEST006 that could cause spliting a compressed sequence

[GitHub] trafodion pull request #1694: [TRAFODION-3183] fetch huge data give rise to ...

2018-08-14 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1694#discussion_r209965872 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4ResultSet.java --- @@ -2779,6 +2779,19 @@ public boolean next() throws

[GitHub] trafodion pull request #1693: [TRAFODION-3180] At times establishing a JDBC/...

2018-08-13 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1693 [TRAFODION-3180] At times establishing a JDBC/ODBC connection takes o… …bservably long time When the sock stream is in use, socket close is kept pending in a queue till

[GitHub] trafodion pull request #1687: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-08 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1687 [TRAFODION-3171] Refactor Hive sequence file reading to use the new i… …mplementation Changes possibly fix the hive/TEST006 failure in daily build. You can merge this pull

[GitHub] trafodion pull request #1685: [TRAFODION-3180] At times establishing a JDBC/...

2018-08-07 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1685 [TRAFODION-3180] At times establishing a JDBC/ODBC connection takes o… …bservably long time Analysis revealed that the mxosrvr process in connecting state was attempting

[GitHub] trafodion pull request #1674: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-03 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1674#discussion_r207459712 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -571,6 +569,7 @@ ExWorkProcRetcode ExHdfsScanTcb::work() hdfsScan_ = HdfsScan

[GitHub] trafodion pull request #1674: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-03 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1674#discussion_r207459245 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -240,7 +256,48 @@ int compressedFileRead(int readLenRemain) throws

[GitHub] trafodion pull request #1665: [TRAFODION-3166] enhance 8427 error detail whe...

2018-08-01 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1665#discussion_r206619328 --- Diff: core/sql/executor/ExSequence.cpp --- @@ -992,23 +992,24 @@ short ExSequenceTcb::work() break

[GitHub] trafodion pull request #1665: [TRAFODION-3166] enhance 8427 error detail whe...

2018-08-01 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1665#discussion_r206623834 --- Diff: core/sql/executor/cluster.cpp --- @@ -2325,6 +2368,50 @@ NABoolean Cluster::read(ExeErrorCode * rc) { } // WHILE ( TRUE

[GitHub] trafodion pull request #1665: [TRAFODION-3166] enhance 8427 error detail whe...

2018-08-01 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1665#discussion_r206621624 --- Diff: core/sql/executor/cluster.cpp --- @@ -1611,6 +1611,49 @@ NABoolean Cluster::initScratch(ExeErrorCode * rc) return FALSE

[GitHub] trafodion pull request #1665: [TRAFODION-3166] enhance 8427 error detail whe...

2018-08-01 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1665#discussion_r206623640 --- Diff: core/sql/executor/cluster.cpp --- @@ -1611,6 +1611,49 @@ NABoolean Cluster::initScratch(ExeErrorCode * rc) return FALSE

[GitHub] trafodion pull request #1674: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-01 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1674 [TRAFODION-3171] Refactor Hive sequence file reading to use the new i… …mplementation You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafodion pull request #1665: [TRAFODION-3166] enhance 8427 error detail whe...

2018-07-26 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1665#discussion_r205606604 --- Diff: core/sql/executor/ExSequence.cpp --- @@ -1487,7 +1487,35 @@ void ExSequenceTcb::updateDiagsArea( ExeErrorCode rc_

[GitHub] trafodion pull request #1626: [TRAFODION-3126] Refactored HDFS client implem...

2018-07-02 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1626#discussion_r199663083 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -142,21 +154,32 @@ HDFSRead

[GitHub] trafodion pull request #1626: [TRAFODION-3126] Refactored HDFS client implem...

2018-07-02 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1626#discussion_r199657006 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -126,6 +128,16 @@ catch (IOException ioe

[GitHub] trafodion pull request #1626: [TRAFODION-3126] Refactored HDFS client implem...

2018-06-29 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1626 [TRAFODION-3126] Refactored HDFS client implementation should also su… …pport Alluxio file system Alluxio doesn't support direct ByteBuffer access. Circumvented

[GitHub] trafodion pull request #:

2018-06-28 Thread selvaganesang
Github user selvaganesang commented on the pull request: https://github.com/apache/trafodion/commit/0f04ef978472adadc0fad4d534b7ea9515ba2ceb#commitcomment-29536789 In core/sql/runtimestats/SqlStats.cpp: In core/sql/runtimestats/SqlStats.cpp on line 1628: getInitError

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-27 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r198638476 --- Diff: core/sql/cli/SessionDefaults.cpp --- @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap sessionDefaultMap

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-26 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r198366844 --- Diff: core/sql/cli/SessionDefaults.cpp --- @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap sessionDefaultMap

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-26 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r198287745 --- Diff: core/sql/cli/SessionDefaults.cpp --- @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap sessionDefaultMap

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-26 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r198243407 --- Diff: core/sql/cli/SessionDefaults.cpp --- @@ -108,6 +108,7 @@ static const SessionDefaults::SessionDefaultMap sessionDefaultMap

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r197980387 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -374,10 +375,9 @@ ex_tcb_private_state *ExHdfsScanTcb::allocatePstates( Int32 ExHdfsScanTcb

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r197957847 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -359,36 +392,54 @@ int hdfsWrite(byte[] buff) throws IOException

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r197914060 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -359,36 +392,54 @@ int hdfsWrite(byte[] buff) throws IOException

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-18 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1612#discussion_r196119643 --- Diff: core/sql/exp/ExpLOBaccess.cpp --- @@ -1827,14 +1934,15 @@ Ex_Lob_Error ExLob::compactLobDataFile(ExLobInMemoryDescChunksEntry *dcArray

[GitHub] trafodion pull request #1612: [TRAFODION-3110] Refactor LOB access to use th...

2018-06-15 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1612 [TRAFODION-3110] Refactor LOB access to use the new implementation of… … HdfsClient This feature is enabled by default. To disable, set a variable USE_LIBHDFS=1

[GitHub] trafodion pull request #1532: [TRAFODION-3026] add create option storage pol...

2018-06-07 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1532#discussion_r193876755 --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java --- @@ -3226,5

[GitHub] trafodion pull request #1532: [TRAFODION-3026] add create option storage pol...

2018-06-07 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1532#discussion_r193875770 --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java --- @@ -3226,5

[GitHub] trafodion pull request #1532: [TRAFODION-3026] add create option storage pol...

2018-06-07 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1532#discussion_r193880363 --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/TrxRegionEndpoint.java.tmpl

[GitHub] trafodion pull request #1586: [TRAFODION-2946] Support to provide a locking ...

2018-06-01 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1586#discussion_r192541780 --- Diff: core/sql/runtimestats/sscpipc.cpp --- @@ -907,3 +910,53 @@ void SscpNewIncomingConnectionStream::processSecInvReq() request

[GitHub] trafodion pull request #1590: [TRAFODION-3097] At times the query involving ...

2018-06-01 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1590 [TRAFODION-3097] At times the query involving sequence function fail … …and dumps core BiArithmetic sum expression clause in Sequence expression can't have pcode generated

[GitHub] trafodion pull request #1589: [TRAFODION-3095] Trafodion SQL process should ...

2018-06-01 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1589 [TRAFODION-3095] Trafodion SQL process should abort when it encounter… …s OOM condition in java You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-14 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r188042584 --- Diff: core/sqf/src/tm/tmlib.cpp --- @@ -2817,35 +2833,44 @@ void TMLIB::initialize() // This call has been changed so that the node

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-13 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187838464 --- Diff: core/sqf/src/tm/tmtransaction.cpp --- @@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status) return

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-13 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187837665 --- Diff: core/sqf/src/tm/tmlib.cpp --- @@ -2817,35 +2833,44 @@ void TMLIB::initialize() // This call has been changed so that the node

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-13 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187837532 --- Diff: core/sqf/src/tm/tmlib.cpp --- @@ -2817,35 +2833,44 @@ void TMLIB::initialize() // This call has been changed so that the node

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-11 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1562 [TRAFODION-2821] Trafodion core code base needs to be thread safe TMLIB JNI interaction was not thread safe causing T2 driver application to dump core at times. Cleaned up TMLIB

[GitHub] trafodion pull request #1553: [TRAFODION-1861] Run Trafodion on CentOS 7

2018-05-10 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1553#discussion_r187361126 --- Diff: core/sqf/src/seabed/src/Makefile --- @@ -55,6 +55,16 @@ LIBSBUTIL= $(LIBEXPDIR)/libsbutil.so LIBSQSTATESB

[GitHub] trafodion pull request #1557: Changes for [TRAFODION-3065] and [TRAFODION-29...

2018-05-09 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1557#discussion_r187170425 --- Diff: core/sql/comexe/ComTdbFastTransport.h --- @@ -395,9 +399,10 @@ class ComTdbFastExtract : public ComTdb UInt16 filler_

[GitHub] trafodion pull request #1557: Changes for [TRAFODION-3065] and [TRAFODION-29...

2018-05-09 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1557 Changes for [TRAFODION-3065] and [TRAFODION-2982] [TRAFODION-3065] Trafodion to support compressed Hive Text formatted tables Compressed text files are now supported via the new

[GitHub] trafodion pull request #1535: TRAFODION-2957 one stmt support multi-queries

2018-05-03 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1535#discussion_r185934375 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4MultiQueriesPreparedStatement.java --- @@ -0,0 +1,372 @@ +package

[GitHub] trafodion pull request #1532: [TRAFODION-3026] add create option storage pol...

2018-04-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1532#discussion_r184141237 --- Diff: core/sql/src/main/java/org/trafodion/sql/HBaseClient.java --- @@ -552,10 +578,84 @@ public boolean createk(String tblName, Object

[GitHub] trafodion pull request #1532: [TRAFODION-3026] add create option storage pol...

2018-04-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1532#discussion_r184141510 --- Diff: core/sql/src/main/java/org/trafodion/sql/HBaseClient.java --- @@ -552,10 +578,84 @@ public boolean createk(String tblName, Object

[GitHub] trafodion pull request #1535: TRAFODION-2957 one stmt support multi-queries

2018-04-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1535#discussion_r184102393 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4MultiQueriesPreparedStatement.java --- @@ -0,0 +1,372 @@ +package

[GitHub] trafodion pull request #1535: TRAFODION-2957 one stmt support multi-queries

2018-04-25 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1535#discussion_r184096949 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4MultiQueriesPreparedStatement.java --- @@ -0,0 +1,393 @@ +// @@@ START

[GitHub] trafodion pull request #1534: [TRAFODION-3039] SendEventMsg is used in a wro...

2018-04-24 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1534#discussion_r183770455 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_( if (retcode

[GitHub] trafodion pull request #1535: TRAFODION-2957 one stmt support multi-queries

2018-04-24 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1535#discussion_r183744482 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4MultiQueriesPreparedStatement.java --- @@ -0,0 +1,372 @@ +package

[GitHub] trafodion pull request #1535: TRAFODION-2957 one stmt support multi-queries

2018-04-24 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1535#discussion_r183743639 --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4MultiQueriesPreparedStatement.java --- @@ -0,0 +1,393 @@ +// @@@ START

[GitHub] trafodion pull request #1528: [TRAFODION-3009] Streamline error handling in ...

2018-04-19 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1528 [TRAFODION-3009] Streamline error handling in Executor utility commands ComDiagsArea is now allocated only when there are warnings or errors in all the utility commands

[GitHub] trafodion pull request #1522: [TRAFODION-3009] Streamline error handling in ...

2018-04-18 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1522#discussion_r182612555 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -626,14 +625,23 @@ ExWorkProcRetcode ExHdfsScanTcb::work() else

[GitHub] trafodion pull request #1522: [TRAFODION-3009] Streamline error handling in ...

2018-04-17 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1522#discussion_r182166447 --- Diff: core/sql/executor/ExExeUtilCli.cpp --- @@ -1119,7 +1119,7 @@ Lng32 ExeCliInterface::executeImmediate(const char * stmtStr

[GitHub] trafodion pull request #1522: [TRAFODION-3009] Streamline error handling in ...

2018-04-16 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1522 [TRAFODION-3009] Streamline error handling in Executor utility commands Changes to avoid allocation of ComDiagsArea in some more places unless it is needed to pass errors or warnings

[GitHub] trafodion pull request #1513: [TRAFODION-3009] Streamline error handling in ...

2018-04-10 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1513 [TRAFODION-3009] Streamline error handling in Executor utility commands seabase/TEST002 failing with a core file. Yet another attempt to fix this issue. You can merge this pull request

[GitHub] trafodion pull request #1502: various fixes, details in pull request

2018-04-05 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1502#discussion_r179561304 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -5795,40 +5833,51 @@ short ExExeUtilHiveMDaccessTcb::work() str_cpy(infoCol

[GitHub] trafodion pull request #1502: various fixes, details in pull request

2018-04-05 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1502#discussion_r179559224 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -5795,40 +5833,51 @@ short ExExeUtilHiveMDaccessTcb::work() str_cpy(infoCol

[GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...

2018-04-05 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1504#discussion_r179548743 --- Diff: core/sql/bin/SqlciErrors.txt --- @@ -2,7 +2,7 @@ 1000 42000 9 BEGINNER INFRM LOGONLY A syntax error occurred. 1001 Z

[GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...

2018-04-05 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1504#discussion_r179548853 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLschema.cpp --- @@ -410,7 +410,8 @@ Int64 schemaUID = getObjectTypeandOwner(, if (schemaUID <

[GitHub] trafodion pull request #1481: [Trafodion-2335] support functions in the colu...

2018-04-04 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1481#discussion_r179320050 --- Diff: core/sql/regress/seabase/EXPECTED020 --- @@ -3945,4 +3945,35 @@ ?2 --- 1 row(s

[GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...

2018-04-04 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1504#discussion_r179279239 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -1818,8 +1813,9 @@ short ExExeUtilGetMetadataInfoTcb::work

[GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...

2018-04-03 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1504#discussion_r178947965 --- Diff: core/sql/exp/ExpError.cpp --- @@ -135,6 +135,20 @@ ComDiagsArea *ExRaiseSqlError(CollHeap* heap, ComDiagsArea** diagsArea

[GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...

2018-04-03 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1504#discussion_r178944088 --- Diff: core/sql/executor/ExExeUtilExplain.cpp --- @@ -237,8 +237,7 @@ short ExExeUtilDisplayExplainTcb::work() executeImmediate

[GitHub] trafodion pull request #1493: [TRAFODION-2821] Trafodion core code base need...

2018-03-22 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1493#discussion_r176600846 --- Diff: core/sql/executor/HBaseClient_JNI.cpp --- @@ -434,10 +429,7 @@ HBC_RetCode HBaseClient_JNI::releaseHTableClient(HTableClient_JNI* htc

[GitHub] trafodion pull request #1470: [TRAFODION-2853] memory leak of ComDiagsArea i...

2018-03-14 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1470#discussion_r174679546 --- Diff: core/sql/sqlci/SqlCmd.cpp --- @@ -440,25 +461,50 @@ void handleLocalError(ComDiagsArea , SqlciEnv *sqlci_env) // when

[GitHub] trafodion pull request #1461: [TRA[TRAFODION-2917] Refactor Trafodion implem...

2018-03-01 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1461 [TRA[TRAFODION-2917] Refactor Trafodion implementation of hdfs scan for text formatted hive tables Removed the dependency on libhdfs in Trafodion code in some more portions of the code

[GitHub] trafodion pull request #1449: RMS infrastructure now reads the configured pi...

2018-02-16 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1449 RMS infrastructure now reads the configured pid Max from /proc/sys/ke… …rnel/pid_max but limits it to a maximum of 128K. It can be overridden by "PID_MAX" e

[GitHub] trafodion pull request #1447: [TRAFODION-2727] Memory leak in the compiler p...

2018-02-15 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1447 [TRAFODION-2727] Memory leak in the compiler part of the code in Traf… …odion It was found that CmpMessageReplyCode was not getting deleted at all times. But, the handling

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-12 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167601286 --- Diff: core/sql/generator/GenRelScan.cpp --- @@ -1391,6 +1391,9 @@ if (hTabStats->isOrcFile()) hdfsscan_tdb->setUseCif(

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-12 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167600705 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -118,15 +119,39 @@ ExHdfsScanTcb::ExHdfsScanTcb( , dataModCheckDone_(FALSE

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167474597 --- Diff: core/sql/executor/SequenceFileReader.h --- @@ -199,15 +185,6 @@ class SequenceFileWriter : public JavaObjectInterface

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167474575 --- Diff: core/sql/src/main/java/org/trafodion/sql/HdfsScan.java --- @@ -0,0 +1,289 @@ +// @@@ START COPYRIGHT @@@ +// +// Licensed

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167474490 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -0,0 +1,319 @@ +// @@@ START COPYRIGHT @@@ +// +// Licensed

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167474246 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -0,0 +1,319 @@ +// @@@ START COPYRIGHT @@@ +// +// Licensed

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167473755 --- Diff: core/sql/executor/ExExeUtilGet.cpp --- @@ -3521,13 +3521,9 @@ ExExeUtilGetHbaseObjectsTcb::ExExeUtilGetHbaseObjectsTcb

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167473694 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -1149,8 +1297,12 @@ ExWorkProcRetcode ExHdfsScanTcb::work() if (hdfsScanTdb

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167473572 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -514,11 +541,108 @@ ExWorkProcRetcode ExHdfsScanTcb::work() if (step_

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-02-11 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r167473505 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -380,10 +407,12 @@ ExWorkProcRetcode ExHdfsScanTcb::work() HdfsFileInfo *hdfo = NULL

[GitHub] trafodion pull request #1264: [TRAFODION-2772] - retrieve a value from Json ...

2018-02-05 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1264#discussion_r166066307 --- Diff: core/sql/exp/exp_function.cpp --- @@ -6503,8 +6503,19 @@ ex_expr::exp_return_type ex_function_json_object_field_text::eval(char *op_data

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-01-31 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r165170894 --- Diff: core/sql/src/main/java/org/trafodion/sql/HDFSClient.java --- @@ -0,0 +1,319 @@ +// @@@ START COPYRIGHT @@@ +// +// Licensed

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-01-27 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r164278889 --- Diff: core/sql/executor/HdfsClient_JNI.cpp --- @@ -0,0 +1,452

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-01-27 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r164278860 --- Diff: core/sql/executor/ExHdfsScan.cpp --- @@ -1948,6 +1948,54 @@ short ExHdfsScanTcb::handleDone(ExWorkProcRetcode ) return 0

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-01-26 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r164237633 --- Diff: core/sql/executor/ExFastTransport.h --- @@ -407,6 +408,7 @@ class ExHdfsFastExtractTcb : public ExFastExtractTcb

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-01-26 Thread selvaganesang
Github user selvaganesang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1417#discussion_r164211946 --- Diff: core/sql/executor/ExHbaseAccess.cpp --- @@ -502,6 +506,8 @@ void ExHbaseAccessTcb::freeResources() NADELETEBASIC

[GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...

2018-01-26 Thread selvaganesang
GitHub user selvaganesang opened a pull request: https://github.com/apache/trafodion/pull/1417 [TRAFODION-2917] Refactor Trafodion implementation of hdfs scan for t… …ext formatted hive tables Part-1 changes. Created a new class org.trafodion.sql.HDFSClient

  1   2   >