[GitHub] [airflow] codecov-io edited a comment on issue #4859: [AIRFLOW-3917] Added config to support running scheduler(with kuberne…

2019-03-13 Thread GitBox
codecov-io edited a comment on issue #4859: [AIRFLOW-3917] Added config to support running scheduler(with kuberne… URL: https://github.com/apache/airflow/pull/4859#issuecomment-470487618 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4859?src=pr=h1) Report > :exclamation: No

[GitHub] [airflow] ramandumcs commented on a change in pull request #4859: [AIRFLOW-3917] Added config to support running scheduler(with kuberne…

2019-03-13 Thread GitBox
ramandumcs commented on a change in pull request #4859: [AIRFLOW-3917] Added config to support running scheduler(with kuberne… URL: https://github.com/apache/airflow/pull/4859#discussion_r265411249 ## File path: airflow/contrib/kubernetes/kube_client.py ## @@ -48,4 +48,10

[GitHub] [airflow] astahlman commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware

2019-03-13 Thread GitBox
astahlman commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware URL: https://github.com/apache/airflow/pull/4893#discussion_r265408165 ## File path: airflow/www/templates/airflow/graph.html ## @@ -362,6 +362,15 @@ +

[GitHub] [airflow] astahlman commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware

2019-03-13 Thread GitBox
astahlman commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware URL: https://github.com/apache/airflow/pull/4893#discussion_r265408095 ## File path: airflow/www/static/js/index.js ## @@ -0,0 +1,21 @@ +/** Review

[GitHub] [airflow] XD-DENG commented on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
XD-DENG commented on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#issuecomment-472689133 Hi @youngyjd , not really. In my team we never run any Airflow component as root (given we're running on OpenShift,

[GitHub] [airflow] youngyjd edited a comment on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
youngyjd edited a comment on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#issuecomment-472686858 @XD-DENG I guess your situation only works when you run airflow worker command as root, and you provide

[GitHub] [airflow] youngyjd edited a comment on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
youngyjd edited a comment on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#issuecomment-472686858 @XD-DENG I guess your situation only works when you run airflow worker command as root, and you provide

[GitHub] [airflow] youngyjd commented on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
youngyjd commented on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#issuecomment-472686858 @XD-DENG I guess your situation only works when you run airflow worker command as root, and you provide

[GitHub] [airflow] XD-DENG commented on issue #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user

2019-03-13 Thread GitBox
XD-DENG commented on issue #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user URL: https://github.com/apache/airflow/pull/4917#issuecomment-472686522 Merged. Welcome onboard ;-) This is an automated message from the Apache

[GitHub] [airflow] XD-DENG merged pull request #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user

2019-03-13 Thread GitBox
XD-DENG merged pull request #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user URL: https://github.com/apache/airflow/pull/4917 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] jensenity commented on issue #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user

2019-03-13 Thread GitBox
jensenity commented on issue #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user URL: https://github.com/apache/airflow/pull/4917#issuecomment-472686016 Just fixed the typo. Sorry for that. This is an automated message from

[GitHub] [airflow] vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow

2019-03-13 Thread GitBox
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846#issuecomment-472682900 Sure, what tests would you like to see? This is an automated

[GitHub] [airflow] XD-DENG commented on a change in pull request #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user

2019-03-13 Thread GitBox
XD-DENG commented on a change in pull request #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user URL: https://github.com/apache/airflow/pull/4917#discussion_r265401857 ## File path: README.md ## @@ -241,6 +241,7 @@ Currently **officially** using Airflow: 1.

[GitHub] [airflow] jensenity opened a new pull request #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user

2019-03-13 Thread GitBox
jensenity opened a new pull request #4917: [AIRFLOW-XXX] Add Korbit as an Airflow user URL: https://github.com/apache/airflow/pull/4917 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400288 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400258 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400103 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400072 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400258 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400288 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400103 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#discussion_r265400072 ## File path: airflow/contrib/example_dags/example_gcp_translate.py ## @@ -0,0 +1,52 @@ +# -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware URL: https://github.com/apache/airflow/pull/4893#discussion_r265399054 ## File path: airflow/www/templates/airflow/graph.html ## @@ -362,6 +362,15 @@ +

[GitHub] [airflow] mik-laj commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4893: [DRAFT] [AIRFLOW-3891] Make the Graph View time-zone aware URL: https://github.com/apache/airflow/pull/4893#discussion_r265399054 ## File path: airflow/www/templates/airflow/graph.html ## @@ -362,6 +362,15 @@ +

[GitHub] [airflow] mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-13 Thread GitBox
mik-laj commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#issuecomment-472677494 This is not enough reason to change these rules.I think that the code should be rewritten. We have rules

[GitHub] [airflow] mik-laj commented on a change in pull request #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4891: [AIRFLOW-4067] Telegram hook/operator to post messages to telegram channels URL: https://github.com/apache/airflow/pull/4891#discussion_r265398193 ## File path: airflow/contrib/hooks/telegram_hook.py ## @@ -0,0 +1,117

[GitHub] [airflow] jmcarp commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test.

2019-03-13 Thread GitBox
jmcarp commented on issue #4828: [AIRFLOW-4002] Optionally open debugger on errors in airflow test. URL: https://github.com/apache/airflow/pull/4828#issuecomment-472674416 PTAL when you have time @ashb @XD-DENG. This is an

[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r265396114 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,83 @@ +# -*- coding:

[GitHub] [airflow] galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-03-13 Thread GitBox
galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#issuecomment-472673503 > Would it work? after working on it, it looks like it works (see additional unit tests). @bjoernpollex-sc:

[GitHub] [airflow] zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-13 Thread GitBox
zhongjiajie commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r265394390 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,83 @@ +# -*-

[GitHub] [airflow] XD-DENG commented on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
XD-DENG commented on issue #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#issuecomment-472669174 Hi @youngyjd , as I replied in the dev maillist, **sudo** is only required when you're using `run_as_user` option

[GitHub] [airflow] codecov-io edited a comment on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes

2019-03-13 Thread GitBox
codecov-io edited a comment on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes URL: https://github.com/apache/airflow/pull/4648#issuecomment-460139330 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4648?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes

2019-03-13 Thread GitBox
codecov-io edited a comment on issue #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes URL: https://github.com/apache/airflow/pull/4648#issuecomment-460139330 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4648?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r265390331 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,83 @@ +# -*- coding:

[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r265390331 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,83 @@ +# -*- coding:

[GitHub] [airflow] mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator

2019-03-13 Thread GitBox
mik-laj commented on a change in pull request #4903: [AIRFLOW-4069] Add Opsgenie Alert Hook and Operator URL: https://github.com/apache/airflow/pull/4903#discussion_r265390331 ## File path: airflow/contrib/hooks/opsgenie_alert_hook.py ## @@ -0,0 +1,83 @@ +# -*- coding:

[jira] [Created] (AIRFLOW-4088) Airflow exits with code 0 when `airflow list_dags` raises an error

2019-03-13 Thread Maximilian Roos (JIRA)
Maximilian Roos created AIRFLOW-4088: Summary: Airflow exits with code 0 when `airflow list_dags` raises an error Key: AIRFLOW-4088 URL: https://issues.apache.org/jira/browse/AIRFLOW-4088

[GitHub] [airflow] mik-laj commented on issue #4898: [AIRFLOW-XXXX] how to setup simple test env with mysql

2019-03-13 Thread GitBox
mik-laj commented on issue #4898: [AIRFLOW-] how to setup simple test env with mysql URL: https://github.com/apache/airflow/pull/4898#issuecomment-472662950 I think you should add it to the contribute guide . If this is to be in the documentation, my change should be accepted.

[GitHub] [airflow] mik-laj commented on issue #4779: [AIRFLOW-3958] Support list tasks as upstream in chain

2019-03-13 Thread GitBox
mik-laj commented on issue #4779: [AIRFLOW-3958] Support list tasks as upstream in chain URL: https://github.com/apache/airflow/pull/4779#issuecomment-472661763 I think that there is no one solution to the problem. The same as the existing several arithmetic operations, when you only need

[GitHub] [airflow] youngyjd commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
youngyjd commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#discussion_r265379283 ## File path: airflow/task/task_runner/base_task_runner.py ## @@ -161,4 +161,4

[GitHub] [airflow] youngyjd commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
youngyjd commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#discussion_r265379106 ## File path: airflow/task/task_runner/base_task_runner.py ## @@ -161,4 +161,4

[GitHub] [airflow] feng-tao commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
feng-tao commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916#discussion_r265377931 ## File path: airflow/task/task_runner/base_task_runner.py ## @@ -161,4 +161,4

[jira] [Commented] (AIRFLOW-4087) Calling SUDO to remove temp cfg file failed

2019-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792184#comment-16792184 ] ASF GitHub Bot commented on AIRFLOW-4087: - youngyjd commented on pull request #4916:

[GitHub] [airflow] youngyjd opened a new pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner

2019-03-13 Thread GitBox
youngyjd opened a new pull request #4916: [AIRFLOW-4087] remove sudo in on_finish function of BaseTaskRunner URL: https://github.com/apache/airflow/pull/4916 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-4087) Calling SUDO to remove temp cfg file failed

2019-03-13 Thread Junda Yang (JIRA)
Junda Yang created AIRFLOW-4087: --- Summary: Calling SUDO to remove temp cfg file failed Key: AIRFLOW-4087 URL: https://issues.apache.org/jira/browse/AIRFLOW-4087 Project: Apache Airflow Issue

[GitHub] [airflow] pgagnon commented on a change in pull request #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes

2019-03-13 Thread GitBox
pgagnon commented on a change in pull request #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes URL: https://github.com/apache/airflow/pull/4648#discussion_r265372296 ## File path:

[jira] [Commented] (AIRFLOW-4086) Docker build fails

2019-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792176#comment-16792176 ] ASF GitHub Bot commented on AIRFLOW-4086: - potiuk commented on pull request #4915:

[GitHub] [airflow] potiuk opened a new pull request #4915: [AIRFLOW-4086] Fixed pipefail - set bash shell in the current dockerfile

2019-03-13 Thread GitBox
potiuk opened a new pull request #4915: [AIRFLOW-4086] Fixed pipefail - set bash shell in the current dockerfile URL: https://github.com/apache/airflow/pull/4915 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] XD-DENG commented on issue #4913: Remove verbose test on nosetests

2019-03-13 Thread GitBox
XD-DENG commented on issue #4913: Remove verbose test on nosetests URL: https://github.com/apache/airflow/pull/4913#issuecomment-472642923 Hi @ffinfo I don’t think it’s due to these two lines you changed. They have been “DEBUG” for quite Long time, while the verbose Travis log issue only

[jira] [Created] (AIRFLOW-4086) Docker build fails

2019-03-13 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-4086: - Summary: Docker build fails Key: AIRFLOW-4086 URL: https://issues.apache.org/jira/browse/AIRFLOW-4086 Project: Apache Airflow Issue Type: New Feature

[jira] [Created] (AIRFLOW-4085) Support wildcards in FileSensor

2019-03-13 Thread Matthew Livesey (JIRA)
Matthew Livesey created AIRFLOW-4085: Summary: Support wildcards in FileSensor Key: AIRFLOW-4085 URL: https://issues.apache.org/jira/browse/AIRFLOW-4085 Project: Apache Airflow Issue

[GitHub] [airflow] codecov-io commented on issue #4912: [AIRFLOW-4083] Add tests for link generation utils

2019-03-13 Thread GitBox
codecov-io commented on issue #4912: [AIRFLOW-4083] Add tests for link generation utils URL: https://github.com/apache/airflow/pull/4912#issuecomment-472598310 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4912?src=pr=h1) Report > Merging

[GitHub] [airflow] vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow

2019-03-13 Thread GitBox
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846#issuecomment-472598291 @mik-laj I don't know how to fix this, Travis seems to always have one test that fails. I'm not sure how to proceed, so I guess I

[GitHub] [airflow] feng-tao commented on issue #4907: [AIRFLOW-4073] add template_ext for AWS Athena operator

2019-03-13 Thread GitBox
feng-tao commented on issue #4907: [AIRFLOW-4073] add template_ext for AWS Athena operator URL: https://github.com/apache/airflow/pull/4907#issuecomment-472595862 @kurtqq , feel free to create the pr. This is an automated

[GitHub] [airflow] kurtqq commented on issue #4907: [AIRFLOW-4073] add template_ext for AWS Athena operator

2019-03-13 Thread GitBox
kurtqq commented on issue #4907: [AIRFLOW-4073] add template_ext for AWS Athena operator URL: https://github.com/apache/airflow/pull/4907#issuecomment-472593798 can this also be added to bigquery check operators?

[GitHub] [airflow] galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-03-13 Thread GitBox
galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#issuecomment-472589499 @bjoernpollex-sc: Thank you for this constructive discussion. you are bringing very good points to this thread I

[jira] [Commented] (AIRFLOW-4065) misc security fixes and custom spark poll

2019-03-13 Thread t oo (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792069#comment-16792069 ] t oo commented on AIRFLOW-4065: --- point 3 escapes the search.           

[GitHub] [airflow] potiuk commented on issue #4755: [AIRFLOW-3939] Add Google Cloud Translate operator

2019-03-13 Thread GitBox
potiuk commented on issue #4755: [AIRFLOW-3939] Add Google Cloud Translate operator URL: https://github.com/apache/airflow/pull/4755#issuecomment-472585888 Hey @kaxil -> I know you must have been busy after holidays (I hope you rested :)), but just wanted to drag your attention to this

[jira] [Updated] (AIRFLOW-4065) misc security fixes and custom spark poll

2019-03-13 Thread t oo (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] t oo updated AIRFLOW-4065: -- Summary: misc security fixes and custom spark poll (was: misc security fixes) > misc security fixes and

[jira] [Created] (AIRFLOW-4084) Fails to download the entire log when file is large and stored in the ElasticSearch

2019-03-13 Thread Ping Zhang (JIRA)
Ping Zhang created AIRFLOW-4084: --- Summary: Fails to download the entire log when file is large and stored in the ElasticSearch Key: AIRFLOW-4084 URL: https://issues.apache.org/jira/browse/AIRFLOW-4084

[jira] [Commented] (AIRFLOW-4045) BASE_URL not working when RBAC enabled

2019-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792031#comment-16792031 ] ASF GitHub Bot commented on AIRFLOW-4045: - ashb commented on pull request #4914: [AIRFLOW-4045]

[GitHub] [airflow] ashb opened a new pull request #4914: [AIRFLOW-4045] Fix index redirect when base_url is set

2019-03-13 Thread GitBox
ashb opened a new pull request #4914: [AIRFLOW-4045] Fix index redirect when base_url is set URL: https://github.com/apache/airflow/pull/4914 Make sure you have checked _all_ steps below. ### Jira https://issues.apache.org/jira/browse/AIRFLOW-4045 ### Description

[GitHub] [airflow] ffinfo opened a new pull request #4913: Remove verbose test on nosetests

2019-03-13 Thread GitBox
ffinfo opened a new pull request #4913: Remove verbose test on nosetests URL: https://github.com/apache/airflow/pull/4913 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)

[GitHub] [airflow] ashb merged pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
ashb merged pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] codecov-io commented on issue #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
codecov-io commented on issue #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910#issuecomment-472559919 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4910?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb opened a new pull request #4912: [AIRFLOW-4083] Add tests for link generation utils

2019-03-13 Thread GitBox
ashb opened a new pull request #4912: [AIRFLOW-4083] Add tests for link generation utils URL: https://github.com/apache/airflow/pull/4912 Make sure you have checked _all_ steps below. ### Jira https://issues.apache.org/jira/browse/AIRFLOW-4083 ### Description We

[jira] [Created] (AIRFLOW-4083) Unify and test escaping of generated links

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
Ash Berlin-Taylor created AIRFLOW-4083: -- Summary: Unify and test escaping of generated links Key: AIRFLOW-4083 URL: https://issues.apache.org/jira/browse/AIRFLOW-4083 Project: Apache Airflow

[GitHub] [airflow] ashb commented on issue #4901: [AIRFLOW-4058] Rename models tests

2019-03-13 Thread GitBox
ashb commented on issue #4901: [AIRFLOW-4058] Rename models tests URL: https://github.com/apache/airflow/pull/4901#issuecomment-472531575 Thanks for taking the time! @XD-DENG tracked it to this commit on master, but we couldn't see anything obvious that might cause it either.

[GitHub] [airflow] galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…

2019-03-13 Thread GitBox
galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef… URL: https://github.com/apache/airflow/pull/4772#issuecomment-472530565 @ashb I've incorporated Your feedback. Hope it's good now. ;)

[GitHub] [airflow] galuszkak commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…

2019-03-13 Thread GitBox
galuszkak commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef… URL: https://github.com/apache/airflow/pull/4772#discussion_r265251225 ## File path: airflow/contrib/kubernetes/pod.py ## @@ -114,3 +118,4 @@ def

[GitHub] [airflow] galuszkak commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…

2019-03-13 Thread GitBox
galuszkak commented on a change in pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef… URL: https://github.com/apache/airflow/pull/4772#discussion_r265251095 ## File path: airflow/contrib/kubernetes/secret.py ## @@ -14,28 +14,41 @@

[GitHub] [airflow] ffinfo commented on issue #4901: [AIRFLOW-4058] Rename models tests

2019-03-13 Thread GitBox
ffinfo commented on issue #4901: [AIRFLOW-4058] Rename models tests URL: https://github.com/apache/airflow/pull/4901#issuecomment-472527419 @ashb I did do some tracing but I think the cause is not in this merge request. I checked my own fork on travis. Here on the same commit it did

[jira] [Commented] (AIRFLOW-3769) Open Redirect Vulnerability in Admin Create Variable Page

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791884#comment-16791884 ] Ash Berlin-Taylor commented on AIRFLOW-3769: Can you get in touch with me on

[jira] [Commented] (AIRFLOW-3768) XSS Vulnerability in Search Query Parameter

2019-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791870#comment-16791870 ] ASF GitHub Bot commented on AIRFLOW-3768: - ashb commented on pull request #4911: [AIRFLOW-3768]

[GitHub] [airflow] ashb opened a new pull request #4911: [AIRFLOW-3768] Escape search parameter in pagination controls

2019-03-13 Thread GitBox
ashb opened a new pull request #4911: [AIRFLOW-3768] Escape search parameter in pagination controls URL: https://github.com/apache/airflow/pull/4911 Make sure you have checked _all_ steps below. ### Jira https://issues.apache.org/jira/browse/AIRFLOW-3768 ### Description

[GitHub] [airflow] feng-tao commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
feng-tao commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910#discussion_r265223289 ## File path: airflow/bin/cli.py ## @@ -884,13 +884,13 @@ def webserver(args):

[GitHub] [airflow] ashb commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
ashb commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910#discussion_r265222747 ## File path: airflow/bin/cli.py ## @@ -884,13 +884,13 @@ def webserver(args):

[GitHub] [airflow] ashb commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
ashb commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910#discussion_r265222360 ## File path: airflow/bin/cli.py ## @@ -884,13 +884,13 @@ def webserver(args):

[GitHub] [airflow] feng-tao commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
feng-tao commented on a change in pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910#discussion_r265221615 ## File path: airflow/bin/cli.py ## @@ -884,13 +884,13 @@ def webserver(args):

[jira] [Commented] (AIRFLOW-3997) Add accessor for optional variables

2019-03-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791851#comment-16791851 ] ASF subversion and git services commented on AIRFLOW-3997: -- Commit

[jira] [Work started] (AIRFLOW-3768) XSS Vulnerability in Search Query Parameter

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-3768 started by Ash Berlin-Taylor. -- > XSS Vulnerability in Search Query Parameter >

[jira] [Commented] (AIRFLOW-3997) Add accessor for optional variables

2019-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791849#comment-16791849 ] ASF GitHub Bot commented on AIRFLOW-3997: - ashb commented on pull request #4819: [AIRFLOW-3997]

[jira] [Resolved] (AIRFLOW-3997) Add accessor for optional variables

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3997. Resolution: Done Fix Version/s: 1.10.3 > Add accessor for optional

[GitHub] [airflow] ashb merged pull request #4819: [AIRFLOW-3997] Add getter to Variable that returns None instead of throwing

2019-03-13 Thread GitBox
ashb merged pull request #4819: [AIRFLOW-3997] Add getter to Variable that returns None instead of throwing URL: https://github.com/apache/airflow/pull/4819 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] ashb commented on issue #4901: [AIRFLOW-4058] Rename models tests

2019-03-13 Thread GitBox
ashb commented on issue #4901: [AIRFLOW-4058] Rename models tests URL: https://github.com/apache/airflow/pull/4901#issuecomment-472488432 @ffinfo It seems that since we merged this commit something has happened to our logging config in tests, and we now see everything at debug level in the

[GitHub] [airflow] vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow

2019-03-13 Thread GitBox
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846#issuecomment-472450355 Resolved conflict - another module was added in setup.py on the same line as singularity, I combined into one line.

[GitHub] [airflow] vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow

2019-03-13 Thread GitBox
vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846#issuecomment-472449465 is this a real fail or a travis blip?

[GitHub] [airflow] codecov-io edited a comment on issue #4819: [AIRFLOW-3997] Add getter to Variable that returns None instead of throwing

2019-03-13 Thread GitBox
codecov-io edited a comment on issue #4819: [AIRFLOW-3997] Add getter to Variable that returns None instead of throwing URL: https://github.com/apache/airflow/pull/4819#issuecomment-471312929 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4819?src=pr=h1) Report > Merging

[jira] [Closed] (AIRFLOW-4075) minikube enviroment lack of init airflow db step

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-4075. -- Resolution: Not A Bug the deploy script you mention is under the CI tree and is not

[jira] [Updated] (AIRFLOW-4064) Edit DAG in FAB UI

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4064: --- Fix Version/s: 1.10.3 > Edit DAG in FAB UI > -- > >

[jira] [Resolved] (AIRFLOW-4015) GET dag_runs endpoint of experimental API only in RBAC UI

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4015. Resolution: Fixed > GET dag_runs endpoint of experimental API only in RBAC UI >

[jira] [Resolved] (AIRFLOW-4071) Not able query via rest API

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-4071. Resolution: Duplicate > Not able query via rest API >

[jira] [Commented] (AIRFLOW-4065) misc security fixes

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791737#comment-16791737 ] Ash Berlin-Taylor commented on AIRFLOW-4065: 4 isn't a security issue. 5. Not on by

[jira] [Updated] (AIRFLOW-4045) BASE_URL not working when RBAC enabled

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4045: --- Fix Version/s: 1.10.3 It's a hard-coded URL in the redirect "/" (or /airflow in

[jira] [Assigned] (AIRFLOW-4045) BASE_URL not working when RBAC enabled

2019-03-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reassigned AIRFLOW-4045: -- Assignee: Ash Berlin-Taylor > BASE_URL not working when RBAC enabled >

[jira] [Created] (AIRFLOW-4082) Pool capacity is not surfaced in the UI

2019-03-13 Thread James Meickle (JIRA)
James Meickle created AIRFLOW-4082: -- Summary: Pool capacity is not surfaced in the UI Key: AIRFLOW-4082 URL: https://issues.apache.org/jira/browse/AIRFLOW-4082 Project: Apache Airflow Issue

[jira] [Commented] (AIRFLOW-2190) base_url with a subpath generates TypeError

2019-03-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791720#comment-16791720 ] ASF GitHub Bot commented on AIRFLOW-2190: - ashb commented on pull request #4910: [AIRFLOW-2190]

[GitHub] [airflow] ashb opened a new pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
ashb opened a new pull request #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910 Make sure you have checked _all_ steps below. ### Jira - https://issues.apache.org/jira/browse/AIRFLOW-2190 ###

[GitHub] [airflow] ashb commented on issue #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found

2019-03-13 Thread GitBox
ashb commented on issue #4910: [AIRFLOW-2190] Send correct HTTP status for base_url not found URL: https://github.com/apache/airflow/pull/4910#issuecomment-472429776 cc @feng-tao @astahlman This is an automated message from

[jira] [Created] (AIRFLOW-4081) Task failures with "Task instance's dagrun did not exist: Unknown reason."

2019-03-13 Thread Tylar Murray (JIRA)
Tylar Murray created AIRFLOW-4081: - Summary: Task failures with "Task instance's dagrun did not exist: Unknown reason." Key: AIRFLOW-4081 URL: https://issues.apache.org/jira/browse/AIRFLOW-4081

  1   2   >