[GitHub] [airflow] milton0825 commented on a change in pull request #5917: [AIRFLOW-5316] Skip running check-apache-license without --all-files

2019-08-26 Thread GitBox
milton0825 commented on a change in pull request #5917: [AIRFLOW-5316] Skip running check-apache-license without --all-files URL: https://github.com/apache/airflow/pull/5917#discussion_r317903809 ## File path: CONTRIBUTING.md ## @@ -712,6 +713,13 @@ pylint

[jira] [Commented] (AIRFLOW-5304) Fix extra links in BigQueryOperator with multiple queries

2019-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916386#comment-16916386 ] ASF GitHub Bot commented on AIRFLOW-5304: - mik-laj commented on pull request #5906:

[jira] [Commented] (AIRFLOW-5304) Fix extra links in BigQueryOperator with multiple queries

2019-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916387#comment-16916387 ] ASF subversion and git services commented on AIRFLOW-5304: -- Commit

[GitHub] [airflow] mik-laj merged pull request #5906: [AIRFLOW-5304] Fix extra links in BigQueryOperator with multiple queries

2019-08-26 Thread GitBox
mik-laj merged pull request #5906: [AIRFLOW-5304] Fix extra links in BigQueryOperator with multiple queries URL: https://github.com/apache/airflow/pull/5906 This is an automated message from the Apache Git Service. To

[jira] [Updated] (AIRFLOW-5304) Fix extra links in BigQueryOperator with multiple queries

2019-08-26 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula updated AIRFLOW-5304: --- Summary: Fix extra links in BigQueryOperator with multiple queries (was: Fix extra links

[jira] [Commented] (AIRFLOW-5306) Fix the display of links when they contain special characters

2019-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916384#comment-16916384 ] ASF GitHub Bot commented on AIRFLOW-5306: - mik-laj commented on pull request #5904:

[jira] [Resolved] (AIRFLOW-5306) Fix the display of links when they contain special characters

2019-08-26 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula resolved AIRFLOW-5306. Fix Version/s: 1.10.5 Resolution: Fixed > Fix the display of links when they

[jira] [Commented] (AIRFLOW-5306) Fix the display of links when they contain special characters

2019-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916385#comment-16916385 ] ASF subversion and git services commented on AIRFLOW-5306: -- Commit

[GitHub] [airflow] mik-laj merged pull request #5904: [AIRFLOW-5306] Fix display of links when they contain special characters

2019-08-26 Thread GitBox
mik-laj merged pull request #5904: [AIRFLOW-5306] Fix display of links when they contain special characters URL: https://github.com/apache/airflow/pull/5904 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dstandish edited a comment on issue #5787: [AIRFLOW-5172] Add choice of interval edge scheduling

2019-08-26 Thread GitBox
dstandish edited a comment on issue #5787: [AIRFLOW-5172] Add choice of interval edge scheduling URL: https://github.com/apache/airflow/pull/5787#issuecomment-525131312 @ashb is it blasphemy to think of making this non-configurable / 2.0 only?

[GitHub] [airflow] dstandish edited a comment on issue #5787: [AIRFLOW-5172] Add choice of interval edge scheduling

2019-08-26 Thread GitBox
dstandish edited a comment on issue #5787: [AIRFLOW-5172] Add choice of interval edge scheduling URL: https://github.com/apache/airflow/pull/5787#issuecomment-525131312 @ashb is it blasphemy to think of making this non-configurable / 2.0 only? Or perhaps we think of this as a bridge

[GitHub] [airflow] dstandish edited a comment on issue #5787: [AIRFLOW-5172] Add choice of interval edge scheduling

2019-08-26 Thread GitBox
dstandish edited a comment on issue #5787: [AIRFLOW-5172] Add choice of interval edge scheduling URL: https://github.com/apache/airflow/pull/5787#issuecomment-525131312 @ashb is it blasphemy to think of making this non-configurable / 2.0 only?

[GitHub] [airflow] feng-tao merged pull request #5918: Bump eslint-utils from 1.3.1 to 1.4.2 in /airflow/www

2019-08-26 Thread GitBox
feng-tao merged pull request #5918: Bump eslint-utils from 1.3.1 to 1.4.2 in /airflow/www URL: https://github.com/apache/airflow/pull/5918 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mik-laj edited a comment on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
mik-laj edited a comment on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524862605 I think, Airflow operators should be synchronous so that Airflow retrieves information about the success of the operation. The

[jira] [Commented] (AIRFLOW-5262) Update timeout exception to include dag name

2019-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916178#comment-16916178 ] ASF GitHub Bot commented on AIRFLOW-5262: - curiousjazz77 commented on pull request #5919:

[GitHub] [airflow] curiousjazz77 opened a new pull request #5919: [AIRFLOW-5262] Update timeout exception to include dag

2019-08-26 Thread GitBox
curiousjazz77 opened a new pull request #5919: [AIRFLOW-5262] Update timeout exception to include dag URL: https://github.com/apache/airflow/pull/5919 This change will help expedite log investigation in third party logging services, making the dag's name visible in the top-level exception

[GitHub] [airflow] KevinYang21 commented on issue #5908: [WIP]Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de…

2019-08-26 Thread GitBox
KevinYang21 commented on issue #5908: [WIP]Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de… URL: https://github.com/apache/airflow/pull/5908#issuecomment-525049854 @tooptoop4 I don't have perm to edit the JIRA but if the state of it needs to happen I think it should

[GitHub] [airflow] potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

2019-08-26 Thread GitBox
potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#issuecomment-525022210 I'd love to merge this one after it builds

[GitHub] [airflow] potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r317787133 ## File path: airflow/contrib/hooks/qubole_hook.py ## @@

[jira] [Closed] (AIRFLOW-5274) dag.loading-duration metric name too long

2019-08-26 Thread Tao Feng (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Feng closed AIRFLOW-5274. - Resolution: Fixed > dag.loading-duration metric name too long >

[jira] [Commented] (AIRFLOW-5274) dag.loading-duration metric name too long

2019-08-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916123#comment-16916123 ] ASF subversion and git services commented on AIRFLOW-5274: -- Commit

[jira] [Commented] (AIRFLOW-5274) dag.loading-duration metric name too long

2019-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916122#comment-16916122 ] ASF GitHub Bot commented on AIRFLOW-5274: - feng-tao commented on pull request #5890:

[GitHub] [airflow] feng-tao merged pull request #5890: [AIRFLOW-5274] dag loading duration metric name too long

2019-08-26 Thread GitBox
feng-tao merged pull request #5890: [AIRFLOW-5274] dag loading duration metric name too long URL: https://github.com/apache/airflow/pull/5890 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r317780821 ## File path:

[GitHub] [airflow] jrowen commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
jrowen commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317779449 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -94,6 +97,7 @@ def

[GitHub] [airflow] hagope commented on issue #5845: [AIRFLOW-5158] adds google sheets hook

2019-08-26 Thread GitBox
hagope commented on issue #5845: [AIRFLOW-5158] adds google sheets hook URL: https://github.com/apache/airflow/pull/5845#issuecomment-525012303 > Why can't you do this while merging? Merging with squash makes work much easier because you can also correct an incorrect title e.g. it should

[GitHub] [airflow] ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317772443 ## File path: airflow/contrib/utils/log/task_handler_with_custom_formatter.py ## @@ -25,10

[GitHub] [airflow] ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317771885 ## File path: airflow/contrib/utils/log/task_handler_with_custom_formatter.py ## @@ -25,10

[jira] [Updated] (AIRFLOW-5279) Should use links instead of buttons for Airflow modals

2019-08-26 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Davydov updated AIRFLOW-5279: - Affects Version/s: (was: 1.10.4) 1.10.0 > Should use links instead

[jira] [Commented] (AIRFLOW-5279) Should use links instead of buttons for Airflow modals

2019-08-26 Thread Dan Davydov (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916073#comment-16916073 ] Dan Davydov commented on AIRFLOW-5279: -- Oh I didn't know this was worked on, 1.10.0 doesn't have

[GitHub] [airflow] dependabot[bot] opened a new pull request #5918: Bump eslint-utils from 1.3.1 to 1.4.2 in /airflow/www

2019-08-26 Thread GitBox
dependabot[bot] opened a new pull request #5918: Bump eslint-utils from 1.3.1 to 1.4.2 in /airflow/www URL: https://github.com/apache/airflow/pull/5918 Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2. Commits -

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317748048 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[jira] [Work started] (AIRFLOW-5316) Checklicence with Apache RAT tool takes long time on Mac

2019-08-26 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-5316 started by Jarek Potiuk. - > Checklicence with Apache RAT tool takes long time on Mac >

[jira] [Assigned] (AIRFLOW-5316) Checklicence with Apache RAT tool takes long time on Mac

2019-08-26 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk reassigned AIRFLOW-5316: - Assignee: Jarek Potiuk > Checklicence with Apache RAT tool takes long time on Mac >

[jira] [Commented] (AIRFLOW-5316) Checklicence with Apache RAT tool takes long time on Mac

2019-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916055#comment-16916055 ] ASF GitHub Bot commented on AIRFLOW-5316: - potiuk commented on pull request #5917:

[GitHub] [airflow] potiuk opened a new pull request #5917: [AIRFLOW-5316] Skip running check-apache-license without --all-files

2019-08-26 Thread GitBox
potiuk opened a new pull request #5917: [AIRFLOW-5316] Skip running check-apache-license without --all-files URL: https://github.com/apache/airflow/pull/5917 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] mik-laj edited a comment on issue #5845: [AIRFLOW-5158] adds google sheets hook

2019-08-26 Thread GitBox
mik-laj edited a comment on issue #5845: [AIRFLOW-5158] adds google sheets hook URL: https://github.com/apache/airflow/pull/5845#issuecomment-524976457 Why can't you do this while merging? Merging with squash makes work much easier because you can also correct an incorrect title e.g. it

[jira] [Updated] (AIRFLOW-5316) Checklicence with Apache RAT tool takes long time on Mac

2019-08-26 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-5316: -- Description: It takes long time because you cannot make it run selectively only on changed

[GitHub] [airflow] mik-laj commented on issue #5845: [AIRFLOW-5158] adds google sheets hook

2019-08-26 Thread GitBox
mik-laj commented on issue #5845: [AIRFLOW-5158] adds google sheets hook URL: https://github.com/apache/airflow/pull/5845#issuecomment-524976457 Why can't you do this while merging? Merging with squash makes work much easier because you can also correct an incorrect title e.g. it should be

[GitHub] [airflow] milton0825 commented on issue #5845: [AIRFLOW-5158] adds google sheets hook

2019-08-26 Thread GitBox
milton0825 commented on issue #5845: [AIRFLOW-5158] adds google sheets hook URL: https://github.com/apache/airflow/pull/5845#issuecomment-524969320 Can you squash all your commits? This is an automated message from the Apache

[GitHub] [airflow] galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-08-26 Thread GitBox
galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#discussion_r317727720 ## File path: tests/operators/test_python_operator.py ## @@ -242,6 +249,510 @@ def

[GitHub] [airflow] galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-08-26 Thread GitBox
galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#discussion_r317727656 ## File path: tests/operators/test_python_operator.py ## @@ -242,6 +249,510 @@ def

[GitHub] [airflow] galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-08-26 Thread GitBox
galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#discussion_r317723428 ## File path: tests/operators/test_python_operator.py ## @@ -242,6 +249,510 @@ def

[GitHub] [airflow] galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-08-26 Thread GitBox
galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#issuecomment-524959443 Back from summer break! I'm working on it this week

[GitHub] [airflow] galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively

2019-08-26 Thread GitBox
galak75 commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#discussion_r317719732 ## File path: tests/operators/test_python_operator.py ## @@ -242,6 +249,510 @@ def

[GitHub] [airflow] swiftomkar commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
swiftomkar commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317715576 ## File path: airflow/contrib/utils/log/task_handler_with_custom_formatter.py ## @@

[GitHub] [airflow] swiftomkar commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
swiftomkar commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317713282 ## File path: airflow/contrib/utils/sendgrid.py ## @@ -30,8 +33,8 @@ from

[jira] [Updated] (AIRFLOW-5315) TaskInstance not updating from DB when user changes executor_config

2019-08-26 Thread Daniel Imberman (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Imberman updated AIRFLOW-5315: - Affects Version/s: 1.10.3 > TaskInstance not updating from DB when user changes

[jira] [Updated] (AIRFLOW-5316) Checklicence with Apache RAT tool takes long time on Mac

2019-08-26 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-5316: -- Affects Version/s: 1.10.4 > Checklicence with Apache RAT tool takes long time on Mac >

[jira] [Created] (AIRFLOW-5316) Checklicence with Apache RAT tool takes long time on Mac

2019-08-26 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-5316: - Summary: Checklicence with Apache RAT tool takes long time on Mac Key: AIRFLOW-5316 URL: https://issues.apache.org/jira/browse/AIRFLOW-5316 Project: Apache Airflow

[jira] [Created] (AIRFLOW-5315) TaskInstance not updating from DB when user changes executor_config

2019-08-26 Thread Daniel Imberman (Jira)
Daniel Imberman created AIRFLOW-5315: Summary: TaskInstance not updating from DB when user changes executor_config Key: AIRFLOW-5315 URL: https://issues.apache.org/jira/browse/AIRFLOW-5315

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317697137 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317697137 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317694266 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317694118 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317693695 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317693534 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317693337 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317693048 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317690424 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317690192 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317689894 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317689608 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze

2019-08-26 Thread GitBox
potiuk commented on a change in pull request #4932: [AIRFLOW-3611] Breeze URL: https://github.com/apache/airflow/pull/4932#discussion_r317689652 ## File path: BREEZE.rst ## @@ -0,0 +1,753 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] potiuk edited a comment on issue #5828: [AIRFLOW-5226] Consistent licences for all jinja templates

2019-08-26 Thread GitBox
potiuk edited a comment on issue #5828: [AIRFLOW-5226] Consistent licences for all jinja templates URL: https://github.com/apache/airflow/pull/5828#issuecomment-524927016 Are you OK to merge @mik-laj @ashb. I solved the problem of duplicate licences now - the modified version of the

[GitHub] [airflow] potiuk commented on issue #5828: [AIRFLOW-5226] Consistent licences for all jinja templates

2019-08-26 Thread GitBox
potiuk commented on issue #5828: [AIRFLOW-5226] Consistent licences for all jinja templates URL: https://github.com/apache/airflow/pull/5828#issuecomment-524927016 Are you OK to merge @mik-laj @ashb. I solved the problem of duplicate licences now - the modified version of the

[jira] [Created] (AIRFLOW-5314) Create test for new import paths

2019-08-26 Thread Tomasz Urbaszek (Jira)
Tomasz Urbaszek created AIRFLOW-5314: Summary: Create test for new import paths Key: AIRFLOW-5314 URL: https://issues.apache.org/jira/browse/AIRFLOW-5314 Project: Apache Airflow Issue

[GitHub] [airflow] nuclearpinguin commented on issue #5795: [AIRFLOW-5186] Move GCP Translate to core

2019-08-26 Thread GitBox
nuclearpinguin commented on issue #5795: [AIRFLOW-5186] Move GCP Translate to core URL: https://github.com/apache/airflow/pull/5795#issuecomment-524918637 Very good catch! I am already working on tests for new imports and found this file missing.

[GitHub] [airflow] ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317665386 ## File path: airflow/contrib/utils/log/task_handler_with_custom_formatter.py ## @@ -25,10

[GitHub] [airflow] ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317664413 ## File path: airflow/contrib/utils/log/task_handler_with_custom_formatter.py ## @@ -37,8

[GitHub] [airflow] ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5916: [Airflow-4668] Make airflow/contrib/utils Pylint compatible URL: https://github.com/apache/airflow/pull/5916#discussion_r317663980 ## File path: airflow/contrib/utils/sendgrid.py ## @@ -30,8 +33,8 @@ from

[GitHub] [airflow] ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option URL: https://github.com/apache/airflow/pull/5358#discussion_r317653652 ## File path: tests/contrib/sensors/test_file_sensor.py ## @@ -134,6 +135,56 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option URL: https://github.com/apache/airflow/pull/5358#discussion_r317655704 ## File path: UPDATING.md ## @@ -23,6 +23,9 @@ assists users migrating to a new version. ##

[GitHub] [airflow] ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option URL: https://github.com/apache/airflow/pull/5358#discussion_r317654039 ## File path: tests/contrib/sensors/test_file_sensor.py ## @@ -134,6 +135,56 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option URL: https://github.com/apache/airflow/pull/5358#discussion_r317654351 ## File path: tests/contrib/sensors/test_file_sensor.py ## @@ -134,6 +135,56 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option

2019-08-26 Thread GitBox
ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - adding wildcard option URL: https://github.com/apache/airflow/pull/5358#discussion_r317654633 ## File path: tests/contrib/sensors/test_file_sensor.py ## @@ -134,6 +135,56 @@ def

[GitHub] [airflow] darrenleeweber commented on issue #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on issue #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#issuecomment-524899773 Please squash commits into one feature-commit This is

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317649011 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -94,6 +97,7 @@

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317649011 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -94,6 +97,7 @@

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317647592 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -94,6 +97,7 @@

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317646895 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -94,6 +97,7 @@

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317646895 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -94,6 +97,7 @@

[GitHub] [airflow] michalbrys commented on a change in pull request #5877: [AIRFLOW-5275] Add support for template parameters in DataprocWorkflowTemplateInstantiateOperator

2019-08-26 Thread GitBox
michalbrys commented on a change in pull request #5877: [AIRFLOW-5275] Add support for template parameters in DataprocWorkflowTemplateInstantiateOperator URL: https://github.com/apache/airflow/pull/5877#discussion_r317646788 ## File path:

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317646111 ## File path: tests/contrib/operators/test_awsbatch_operator.py ## @@ -59,7 +61,7 @@

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317644976 ## File path: airflow/contrib/operators/awsbatch_operator.py ## @@ -77,10 +81,10 @@

[GitHub] [airflow] darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator

2019-08-26 Thread GitBox
darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add params support for awsbatch_operator URL: https://github.com/apache/airflow/pull/5900#discussion_r317643828 ## File path: airflow/contrib/operators/awsbatch_operator.py ## @@ -110,10 +115,17 @@

[GitHub] [airflow] nuclearpinguin commented on issue #5335: [AIRFLOW-4588] Add GoogleDiscoveryApiHook and GoogleApiToS3Transfer

2019-08-26 Thread GitBox
nuclearpinguin commented on issue #5335: [AIRFLOW-4588] Add GoogleDiscoveryApiHook and GoogleApiToS3Transfer URL: https://github.com/apache/airflow/pull/5335#issuecomment-524891738 I like this approach because it's really generic. On the other hand, I also like service-specific hooks

[GitHub] [airflow] swiftomkar opened a new pull request #5916: Airflow 4668

2019-08-26 Thread GitBox
swiftomkar opened a new pull request #5916: Airflow 4668 URL: https://github.com/apache/airflow/pull/5916 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524862605 I think, Airflow operators should be synchronous so that Airflow retrieves information about the success of the operation. The operator

[GitHub] [airflow] hagope commented on issue #5845: [AIRFLOW-5158] adds google sheets hook

2019-08-26 Thread GitBox
hagope commented on issue #5845: [AIRFLOW-5158] adds google sheets hook URL: https://github.com/apache/airflow/pull/5845#issuecomment-524861047 Hi @mik-laj thanks again for the review, I've updated and committed please take a look when you have a chance.

[jira] [Created] (AIRFLOW-5313) Add params support for awsbatch_operator

2019-08-26 Thread Jonathan R Owen (Jira)
Jonathan R Owen created AIRFLOW-5313: Summary: Add params support for awsbatch_operator Key: AIRFLOW-5313 URL: https://issues.apache.org/jira/browse/AIRFLOW-5313 Project: Apache Airflow

[jira] [Commented] (AIRFLOW-5312) KubernetesPodOperator hangs when kubernetes API times out

2019-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915756#comment-16915756 ] ASF GitHub Bot commented on AIRFLOW-5312: - rolanddb commented on pull request #5915:

[GitHub] [airflow] rolanddb opened a new pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator

2019-08-26 Thread GitBox
rolanddb opened a new pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator URL: https://github.com/apache/airflow/pull/5915 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Assigned] (AIRFLOW-5312) KubernetesPodOperator hangs when kubernetes API times out

2019-08-26 Thread Roland de Boo (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roland de Boo reassigned AIRFLOW-5312: -- Assignee: Roland de Boo > KubernetesPodOperator hangs when kubernetes API times out

[GitHub] [airflow] iainjames88 commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
iainjames88 commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524823685 So, looking at the code again I don't think this will handle asynchronous calls to Lambda very well, if at all. See that

[jira] [Created] (AIRFLOW-5312) KubernetesPodOperator hangs when kubernetes API times out

2019-08-26 Thread Roland de Boo (Jira)
Roland de Boo created AIRFLOW-5312: -- Summary: KubernetesPodOperator hangs when kubernetes API times out Key: AIRFLOW-5312 URL: https://issues.apache.org/jira/browse/AIRFLOW-5312 Project: Apache

[GitHub] [airflow] iainjames88 commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
iainjames88 commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524813486 No problem This is an automated message from the Apache Git Service. To

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524808769 One more small change. ``AWSLambdaInvokeFunctionOperator`` > ``AwsLambdaInvokeFunctionOperator`` This will allow easier name reading.

[GitHub] [airflow] iainjames88 commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
iainjames88 commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524808092 Thanks :) I had a look around in the repo and picked up on the pattern and I've already updated it to `AWSLambdaInvokeFunctionOperator`

[GitHub] [airflow] mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator

2019-08-26 Thread GitBox
mik-laj commented on issue #5914: [AIRFLOW-5311] Add an AWS Lambda Operator URL: https://github.com/apache/airflow/pull/5914#issuecomment-524807101 Operator suffix is required: The service name should be a prefix.We expect operator names to be in the form of

  1   2   >