[GitHub] [airflow] klsnreddy opened a new pull request #8983: 8876 Provide option to time delta on upstream tasks in TimeDeltaSensor

2020-05-22 Thread GitBox
klsnreddy opened a new pull request #8983: URL: https://github.com/apache/airflow/pull/8983 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] tanjinP commented on issue #8970: Improve guide for KubernetesPodOperator

2020-05-22 Thread GitBox
tanjinP commented on issue #8970: URL: https://github.com/apache/airflow/issues/8970#issuecomment-632979988 I can take this on as it relates to #8883 This is an automated message from the Apache Git Service. To respond to

[airflow] tag nightly-master updated (94a7673 -> f107338)

2020-05-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 94a7673 (commit) to f107338 (commit) from

[GitHub] [airflow] kaxil commented on a change in pull request #8974: Vault has now VaultHook not only SecretBackend

2020-05-22 Thread GitBox
kaxil commented on a change in pull request #8974: URL: https://github.com/apache/airflow/pull/8974#discussion_r429505660 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -72,98 +68,90 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin): :type

[GitHub] [airflow] kaxil opened a new pull request #8982: Remove defunct code from setup.py

2020-05-22 Thread GitBox
kaxil opened a new pull request #8982: URL: https://github.com/apache/airflow/pull/8982 Remove defunct code from setup.py --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for

[GitHub] [airflow] Acehaidrey edited a comment on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
Acehaidrey edited a comment on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632969149 hey @jhtimmins thanks for the update! That is okay with me. I just don't know how to make this test pass otherwise and @dimberman has asked for it. do you think we

[GitHub] [airflow] Acehaidrey commented on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
Acehaidrey commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632969149 hey @jhtimmins thanks for the update! That is okay with me. I just don't know how to make this test pass otherwise and @dimberman has asked for it

[GitHub] [airflow] kaxil opened a new pull request #8981: Remove duplicate line from CONTRIBUTING.rst

2020-05-22 Thread GitBox
kaxil opened a new pull request #8981: URL: https://github.com/apache/airflow/pull/8981 Remove duplicate line from CONTRIBUTING.rst --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests

[GitHub] [airflow] jhtimmins commented on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
jhtimmins commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632960556 @Acehaidrey Not sure about increasing the memory, but several of us are actively working to reduce the image size to solve that issue. Hard to give an exact timeline, but can

[GitHub] [airflow] Acehaidrey commented on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
Acehaidrey commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632944238 hey @dimberman @ashb I am getting some exit code 137 meaning oom issues. that is why tests are failing. but wondering if you knew where to touch those containers to request

[GitHub] [airflow] Acehaidrey commented on a change in pull request #8598: Make hive macros py3 compatible with decoded string return type

2020-05-22 Thread GitBox
Acehaidrey commented on a change in pull request #8598: URL: https://github.com/apache/airflow/pull/8598#discussion_r429486073 ## File path: airflow/providers/apache/hive/hooks/hive.py ## @@ -708,7 +708,11 @@ def _get_max_partition_from_part_specs(part_specs, partition_key,

[GitHub] [airflow] Acehaidrey commented on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
Acehaidrey commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632927893 @dimberman yes I can rebase and try again, it seems the tests are failing to some connection issue with hive which are not related to this. I'm thinking its intermittent ?

[GitHub] [airflow] dimberman commented on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
dimberman commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632926745 @Acehaidrey can you please fix the tests? Will merge when passing. This is an automated message from the

[GitHub] [airflow] Acehaidrey commented on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
Acehaidrey commented on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632915369 not a problem @jhtimmins I know you are all busy! please let me know if I can help ever! would love to be closer to community :) but regarding this PR was there anything

[jira] [Commented] (AIRFLOW-6569) Broken sentry integration

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114413#comment-17114413 ] ASF GitHub Bot commented on AIRFLOW-6569: - mikeclarke commented on pull request #7232: URL:

[GitHub] [airflow] mikeclarke commented on pull request #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process

2020-05-22 Thread GitBox
mikeclarke commented on pull request #7232: URL: https://github.com/apache/airflow/pull/7232#issuecomment-632915407 > Can you do rebase to the latest master? I would like to accept these changes, but I need green tests (excluding quarantine) Rebased again, thanks.

[GitHub] [airflow] Acehaidrey edited a comment on pull request #8680: Add metric for start/end task run

2020-05-22 Thread GitBox
Acehaidrey edited a comment on pull request #8680: URL: https://github.com/apache/airflow/pull/8680#issuecomment-632915369 not a problem @jhtimmins I know you are all busy! please let me know if I can help ever! would love to be closer to community :) but regarding this PR was there

[GitHub] [airflow] Acehaidrey commented on pull request #8702: Add context to execution_date_fn in ExternalTaskSensor

2020-05-22 Thread GitBox
Acehaidrey commented on pull request #8702: URL: https://github.com/apache/airflow/pull/8702#issuecomment-632912320 No problem thank you @dimberman ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] mikaeld opened a new issue #8980: Add a SlackAPIFileOperator to send files on Slack

2020-05-22 Thread GitBox
mikaeld opened a new issue #8980: URL: https://github.com/apache/airflow/issues/8980 **Description** airflow.operators.slack_operator only has the SlackAPIPostOperator implementing 'chat.postMessage' Slack API method. I created an Operator for the 'files.upload' API method for a

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8980: Add a SlackAPIFileOperator to send files on Slack

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on issue #8980: URL: https://github.com/apache/airflow/issues/8980#issuecomment-632892218 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] mik-laj opened a new pull request #8979: Add secrets to test_deprecated_packages

2020-05-22 Thread GitBox
mik-laj opened a new pull request #8979: URL: https://github.com/apache/airflow/pull/8979 --- Make sure to mark the boxes below before creating PR: [x] - [X] Description above provides context of the change - [X] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] mik-laj opened a new pull request #8978: Fix typo in test_project_structure

2020-05-22 Thread GitBox
mik-laj opened a new pull request #8978: URL: https://github.com/apache/airflow/pull/8978 --- Make sure to mark the boxes below before creating PR: [x] - [X] Description above provides context of the change - [X] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] mik-laj edited a comment on issue #8977: Secrets and Protocols are note checked if they are tested

2020-05-22 Thread GitBox
mik-laj edited a comment on issue #8977: URL: https://github.com/apache/airflow/issues/8977#issuecomment-632886031 It seems to me that all files are checked. https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L84

[GitHub] [airflow] mik-laj edited a comment on issue #8977: Secrets and Protocols are note checked if they are tested

2020-05-22 Thread GitBox
mik-laj edited a comment on issue #8977: URL: https://github.com/apache/airflow/issues/8977#issuecomment-632886031 It seems to me that all files are checked. https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L84

[GitHub] [airflow] mik-laj commented on issue #8977: Secrets and Protocols are note checked if they are tested

2020-05-22 Thread GitBox
mik-laj commented on issue #8977: URL: https://github.com/apache/airflow/issues/8977#issuecomment-632886031 It seems to me that all files are checked. https://github.com/apache/airflow/blob/f1073381ed764a218b2502d15ca28a5b326f9f2d/tests/test_project_structure.py#L84 However, I

[GitHub] [airflow] ashb commented on pull request #8973: Bust pre-commit cache on v1-10-test branch

2020-05-22 Thread GitBox
ashb commented on pull request #8973: URL: https://github.com/apache/airflow/pull/8973#issuecomment-632872285 Updated to just bust cache. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk opened a new issue #8977: Secrets and Protocols are note checked if they are tested

2020-05-22 Thread GitBox
potiuk opened a new issue #8977: URL: https://github.com/apache/airflow/issues/8977 **Description** The test_project_structure does not check for files that are protocols or secrets. Only operators/hooks/sensors are checked. **Use case / motivation** If there are

[GitHub] [airflow] potiuk commented on issue #8977: Secrets and Protocols are note checked if they are tested

2020-05-22 Thread GitBox
potiuk commented on issue #8977: URL: https://github.com/apache/airflow/issues/8977#issuecomment-632866996 cc @mik-laj This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk opened a new pull request #8976: You can push with Breeze as separate command and to cache

2020-05-22 Thread GitBox
potiuk opened a new pull request #8976: URL: https://github.com/apache/airflow/pull/8976 Breeze had --push-images switch to also push images to repo but it was often needed to build and push images separately. We have now a possibility to push an already built image with

[GitHub] [airflow] dimberman commented on a change in pull request #8777: Add Production Helm chart support

2020-05-22 Thread GitBox
dimberman commented on a change in pull request #8777: URL: https://github.com/apache/airflow/pull/8777#discussion_r429407770 ## File path: chart/values.yaml ## @@ -0,0 +1,438 @@ +# Default values for airflow. +# This is a YAML-formatted file. +# Declare variables to be passed

[GitHub] [airflow] sarahmaas commented on issue #8119: REST API Reference

2020-05-22 Thread GitBox
sarahmaas commented on issue #8119: URL: https://github.com/apache/airflow/issues/8119#issuecomment-632843330 I'd like to work on adding swagger UI for this. This is an automated message from the Apache Git Service. To

[GitHub] [airflow] schnie commented on a change in pull request #8777: Add Production Helm chart support

2020-05-22 Thread GitBox
schnie commented on a change in pull request #8777: URL: https://github.com/apache/airflow/pull/8777#discussion_r429394334 ## File path: chart/values.yaml ## @@ -0,0 +1,438 @@ +# Default values for airflow. +# This is a YAML-formatted file. +# Declare variables to be passed

[GitHub] [airflow] schnie commented on a change in pull request #8777: Add Production Helm chart support

2020-05-22 Thread GitBox
schnie commented on a change in pull request #8777: URL: https://github.com/apache/airflow/pull/8777#discussion_r429393752 ## File path: chart/templates/configmap.yaml ## @@ -0,0 +1,108 @@ + +## Airflow ConfigMap

[jira] [Commented] (AIRFLOW-6569) Broken sentry integration

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114288#comment-17114288 ] ASF GitHub Bot commented on AIRFLOW-6569: - mik-laj commented on pull request #7232: URL:

[GitHub] [airflow] mik-laj commented on pull request #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process

2020-05-22 Thread GitBox
mik-laj commented on pull request #7232: URL: https://github.com/apache/airflow/pull/7232#issuecomment-632828928 Can you do rebase to the latest master? I would like to accept these changes, but I need green tests (excluding quarantine)

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8846: Adding support for databricks spark python and submit tasks.

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on pull request #8846: URL: https://github.com/apache/airflow/pull/8846#issuecomment-632825269 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] mik-laj merged pull request #8846: Adding support for databricks spark python and submit tasks.

2020-05-22 Thread GitBox
mik-laj merged pull request #8846: URL: https://github.com/apache/airflow/pull/8846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (b055151 -> f107338)

2020-05-22 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from b055151 Add context to execution_date_fn in ExternalTaskSensor (#8702) add f107338 Add support for

[GitHub] [airflow] casassg commented on pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
casassg commented on pull request #8962: URL: https://github.com/apache/airflow/pull/8962#issuecomment-632819478 I prefer to avoid doing that. Seems to add quite a bit of code complexity and I doubt it will impact significantly the user experience. I think it should be fine from users to

[GitHub] [airflow] jaketf commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-22 Thread GitBox
jaketf commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r429358908 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ## @@ -435,20 +435,52 @@ def _get_pipeline( "workflows",

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r429363622 ## File path: docs/concepts.rst ## @@ -116,6 +116,47 @@ DAGs can be used as context managers to automatically assign new operators to th op.dag

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r429362120 ## File path: airflow/operators/python.py ## @@ -145,6 +148,142 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r429339659 ## File path: airflow/operators/python.py ## @@ -145,6 +148,142 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[GitHub] [airflow] ashb commented on pull request #8973: Run static checks on Python3.6 for v1-10 branches

2020-05-22 Thread GitBox
ashb commented on pull request #8973: URL: https://github.com/apache/airflow/pull/8973#issuecomment-632802828 yeah, I thought this might be deliberate, bit wondered if it was a pre-commit 1 vs 2 problem. This is an

[GitHub] [airflow] aoen commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
aoen commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r429349413 ## File path: airflow/operators/python.py ## @@ -145,6 +147,141 @@ def execute_callable(self): return self.python_callable(*self.op_args,

[GitHub] [airflow] jaketf commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-22 Thread GitBox
jaketf commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r429345281 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ## @@ -386,15 +480,29 @@ def start_pipeline( pipeline_name,

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on pull request #8975: URL: https://github.com/apache/airflow/pull/8975#issuecomment-632788174 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] crazzysun opened a new pull request #8975: [AIRFLOW-8969] Atlas Backend module improvements

2020-05-22 Thread GitBox
crazzysun opened a new pull request #8975: URL: https://github.com/apache/airflow/pull/8975 Issue #8969 - Create an Airflow operator atlas entity don't use execution date as part of the qualified name anymore. - Add config property for enabled/disabled creating missing inlets,

[GitHub] [airflow] samuelkhtu commented on issue #8525: SQLBranchOperator

2020-05-22 Thread GitBox
samuelkhtu commented on issue #8525: URL: https://github.com/apache/airflow/issues/8525#issuecomment-632786479 Quick update. The PR is under review. This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on pull request #8973: Run static checks on Python3.6

2020-05-22 Thread GitBox
ashb commented on pull request #8973: URL: https://github.com/apache/airflow/pull/8973#issuecomment-632774494 https://github.com/apache/airflow/runs/699984569?check_suite_focus=true is the problem I was dealing with This is

[GitHub] [airflow] potiuk commented on pull request #8974: Vault has now VaultHook not only SecretBackend

2020-05-22 Thread GitBox
potiuk commented on pull request #8974: URL: https://github.com/apache/airflow/pull/8974#issuecomment-632766569 Hey @ashb @kaxil -> here is the first of the Hooks. This one is implemented for Vault. I extracted the client out of the Backend and added all the missing authentication

[GitHub] [airflow] potiuk opened a new pull request #8974: Vault has now VaultHook not only SecretBackend

2020-05-22 Thread GitBox
potiuk opened a new pull request #8974: URL: https://github.com/apache/airflow/pull/8974 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] ashb commented on pull request #8973: Run static checks on Python3.6

2020-05-22 Thread GitBox
ashb commented on pull request #8973: URL: https://github.com/apache/airflow/pull/8973#issuecomment-632759670 (I'm not sure at all if this is the right fix or not, but thought I'd try it) This is an automated message from

[GitHub] [airflow] ashb opened a new pull request #8973: Run static checks on Python3.6

2020-05-22 Thread GitBox
ashb opened a new pull request #8973: URL: https://github.com/apache/airflow/pull/8973 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8972: Duplicate logging

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on issue #8972: URL: https://github.com/apache/airflow/issues/8972#issuecomment-632754220 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] MichaelJDrK opened a new issue #8972: Duplicate logging

2020-05-22 Thread GitBox
MichaelJDrK opened a new issue #8972: URL: https://github.com/apache/airflow/issues/8972 **Apache Airflow version**: 1.10.10 **What happened**: Use airflow out of the box, create any DAG, run the DAG. Log will contain nested log messages like this (one line):

[jira] [Commented] (AIRFLOW-3819) k8s executor - Allow the configuration of a global default for pod resource request/limits

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114144#comment-17114144 ] ASF GitHub Bot commented on AIRFLOW-3819: - tylux commented on pull request #4660: URL:

[GitHub] [airflow] tylux commented on pull request #4660: [AIRFLOW-3819] - Allow the configuration of a global default for work…

2020-05-22 Thread GitBox
tylux commented on pull request #4660: URL: https://github.com/apache/airflow/pull/4660#issuecomment-632749722 Can this get revisited? This goes against Kubernetes best practices to rely on a different mechanism i.e dag code to set the resource limits instead of standard pod limits.

[GitHub] [airflow] turbaszek commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-22 Thread GitBox
turbaszek commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r429307560 ## File path: airflow/providers/google/cloud/operators/datafusion.py ## @@ -674,14 +676,23 @@ def execute(self, context: Dict):

[airflow] branch v1-10-test updated: Pin Version of Azure Cosmos to <4 (#8956)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new 17150ae Pin Version of Azure Cosmos to

[GitHub] [airflow] turbaszek commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-22 Thread GitBox
turbaszek commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r429292921 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ## @@ -386,15 +480,29 @@ def start_pipeline( pipeline_name,

[jira] [Commented] (AIRFLOW-6569) Broken sentry integration

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114118#comment-17114118 ] ASF GitHub Bot commented on AIRFLOW-6569: - maxcountryman commented on pull request #7232: URL:

[GitHub] [airflow] turbaszek commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-22 Thread GitBox
turbaszek commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r429236013 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ## @@ -357,12 +418,45 @@ def list_pipelines( ) return

[GitHub] [airflow] maxcountryman commented on pull request #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process

2020-05-22 Thread GitBox
maxcountryman commented on pull request #7232: URL: https://github.com/apache/airflow/pull/7232#issuecomment-632730483 It seems like the tests that are failing are unrelated to this patch and seem to be the same tests that are also failing on master. What's blocking merging this in

[GitHub] [airflow] dimberman closed pull request #8958: Add caching

2020-05-22 Thread GitBox
dimberman closed pull request #8958: URL: https://github.com/apache/airflow/pull/8958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dimberman commented on pull request #8702: Add context to execution_date_fn in ExternalTaskSensor

2020-05-22 Thread GitBox
dimberman commented on pull request #8702: URL: https://github.com/apache/airflow/pull/8702#issuecomment-632705967 Hi @Acehaidrey apologies for the delay. I've merged the PR and will work to backport it on 1.10.11 :) This

[airflow] branch master updated (9a4a2d1 -> b055151)

2020-05-22 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9a4a2d1 [AIRFLOW-5262] Update timeout exception to include dag (#8466) add b055151 Add context to

[GitHub] [airflow] dimberman merged pull request #8702: Add context to execution_date_fn in ExternalTaskSensor

2020-05-22 Thread GitBox
dimberman merged pull request #8702: URL: https://github.com/apache/airflow/pull/8702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] yerrysherry opened a new issue #8971: Problem when rotating the fernet keys

2020-05-22 Thread GitBox
yerrysherry opened a new issue #8971: URL: https://github.com/apache/airflow/issues/8971 $ airflow version 1.10.10 Database: CentOS Linux release 7.6.1810 (Core), Webserver - scheduler: lsb_release -a No LSB modules are available. Distributor ID: Ubuntu

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8971: Problem when rotating the fernet keys

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on issue #8971: URL: https://github.com/apache/airflow/issues/8971#issuecomment-632701306 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] mik-laj opened a new issue #8970: Improve guide for Kubernetes Pod Operators

2020-05-22 Thread GitBox
mik-laj opened a new issue #8970: URL: https://github.com/apache/airflow/issues/8970 Hello, A better guide that describes how to use KubernetesPodOperator would be useful. This is one of the most frequently used Airflow operators, so many users have problems with this operator.

[GitHub] [airflow] turbaszek commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

2020-05-22 Thread GitBox
turbaszek commented on a change in pull request #8954: URL: https://github.com/apache/airflow/pull/8954#discussion_r429236013 ## File path: airflow/providers/google/cloud/hooks/datafusion.py ## @@ -357,12 +418,45 @@ def list_pipelines( ) return

[GitHub] [airflow] nodyke opened a new issue #8969: Atlas Backend module improvements

2020-05-22 Thread GitBox
nodyke opened a new issue #8969: URL: https://github.com/apache/airflow/issues/8969 **Description** As part of data lineage implementation, there is requirement to sending lineage data from airflow to Apache Atlas. Current module, what represented in 1.10 stable version,

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8969: Atlas Backend module improvements

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on issue #8969: URL: https://github.com/apache/airflow/issues/8969#issuecomment-632671185 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] U-Ozdemir commented on issue #8207: Create guide for Machine Learning Engine operators

2020-05-22 Thread GitBox
U-Ozdemir commented on issue #8207: URL: https://github.com/apache/airflow/issues/8207#issuecomment-632669193 Hello, I have submitted a part of the guide. It can be used by others here working on it aswell. Any feedback is always welcome. Best regards, Ozdemir

[GitHub] [airflow] U-Ozdemir opened a new pull request #8968: Create guide for Machine Learning Engine operators #8207

2020-05-22 Thread GitBox
U-Ozdemir opened a new pull request #8968: URL: https://github.com/apache/airflow/pull/8968 This my first time working with an open source project and I posting here the first attempt for an ML operator guide. It is still in progress now, but some feedback is always welcome. #

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8968: Create guide for Machine Learning Engine operators #8207

2020-05-22 Thread GitBox
boring-cyborg[bot] commented on pull request #8968: URL: https://github.com/apache/airflow/pull/8968#issuecomment-632661432 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] ashb edited a comment on pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
ashb edited a comment on pull request #8962: URL: https://github.com/apache/airflow/pull/8962#issuecomment-632646688 > The main question is: do we want to support that? Is this "hack" worth it, and do IDEs get massively confused by this? I think if IDEs support it, and we add tests

[GitHub] [airflow] ashb commented on pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-05-22 Thread GitBox
ashb commented on pull request #8962: URL: https://github.com/apache/airflow/pull/8962#issuecomment-632646688 > The main question is: do we want to support that? Is this "hack" worth it, and do IDEs get massively confused by this? I think if IDEs support it, and we add tests for it

[jira] [Updated] (AIRFLOW-3367) Test celery with redis broker

2020-05-22 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3367: --- Fix Version/s: (was: 2.0.0) 1.10.11 > Test celery with

[jira] [Commented] (AIRFLOW-3367) Test celery with redis broker

2020-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113951#comment-17113951 ] ASF subversion and git services commented on AIRFLOW-3367: -- Commit

[airflow] 01/02: [AIRFLOW-3367] Run celery integration test with redis broker. (#4207)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 229f631f2dafa7a698e634a614c8fa4102f68b38 Author: Joshua Carp AuthorDate: Mon Dec 3 04:19:25 2018 -0500

[airflow] 02/02: Fix race in Celery tests by pre-creating result tables (#8909)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 3f3a4b5e2a0fb256c023d6087026608697f40a2f Author: Ash Berlin-Taylor AuthorDate: Tue May 19 13:21:44 2020 +0100

[airflow] branch v1-10-test updated (24b7416 -> 3f3a4b5)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 24b7416 Fix race in Celery tests by pre-creating result tables (#8909) discard d13c681 [AIRFLOW-3367] Run

[GitHub] [airflow] ashb closed issue #8967: 2.0.0 - db upgrade fails on missing dag_stats

2020-05-22 Thread GitBox
ashb closed issue #8967: URL: https://github.com/apache/airflow/issues/8967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] ashb commented on issue #8967: 2.0.0 - db upgrade fails on missing dag_stats

2020-05-22 Thread GitBox
ashb commented on issue #8967: URL: https://github.com/apache/airflow/issues/8967#issuecomment-632642806 migrations are recorded when they are performed, and are only run once. It should be impossible for the table to be dropped without also recording that the migration was deleted.

[jira] [Commented] (AIRFLOW-3367) Test celery with redis broker

2020-05-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113950#comment-17113950 ] ASF subversion and git services commented on AIRFLOW-3367: -- Commit

[airflow] branch v1-10-test updated (179fbb6 -> 24b7416)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from 179fbb6 Cache 1 10 ci images (#8955) (#8959) new d13c681 [AIRFLOW-3367] Run celery integration test with

[airflow] 02/02: Fix race in Celery tests by pre-creating result tables (#8909)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 24b74168afe26500abaf82fd388eccee18611c4e Author: Ash Berlin-Taylor AuthorDate: Tue May 19 13:21:44 2020 +0100

[airflow] 01/02: [AIRFLOW-3367] Run celery integration test with redis broker. (#4207)

2020-05-22 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit d13c6810674dae4abbc572116852e6b331c9f40e Author: Joshua Carp AuthorDate: Mon Dec 3 04:19:25 2018 -0500

[GitHub] [airflow] ashb commented on pull request #8901: Getting the connections correctly in AWS Secrets Manager backend

2020-05-22 Thread GitBox
ashb commented on pull request #8901: URL: https://github.com/apache/airflow/pull/8901#issuecomment-632634642 Ahha, cool. yes. `git rebase` can be tricky the first thousand times you run it - I've been there! Don't worry to much about closed PRs, do what is easiest for you to not

[GitHub] [airflow] JavierLopezT commented on pull request #8901: Getting the connections correctly in AWS Secrets Manager backend

2020-05-22 Thread GitBox
JavierLopezT commented on pull request #8901: URL: https://github.com/apache/airflow/pull/8901#issuecomment-632633845 Hi @ashb, thank you. The only reason is that there is a huge mess with git and I was thinking about a fresh start. It is explained a little deeper here

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-22 Thread GitBox
j-y-matsubara edited a comment on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632606590 @yuqian90 Thank you for your advise. I have corrected the document that you pointed out. And... The continuous-integration/travis-ci/pr failure

[GitHub] [airflow] ashb commented on pull request #8701: Adding ElastiCache Hook for creating, describing and deleting replication groups

2020-05-22 Thread GitBox
ashb commented on pull request #8701: URL: https://github.com/apache/airflow/pull/8701#issuecomment-632633027 @VijayantSoni Probably just using `unittest.mock` is enough here, yes please -- we've done that in a few other places I think

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-22 Thread GitBox
j-y-matsubara edited a comment on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632606590 @yuqian90 Thank you for your advise. I have corrected the document that you pointed out. And.. The continuous-integration/travis-ci/pr failure

[GitHub] [airflow] j-y-matsubara edited a comment on pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

2020-05-22 Thread GitBox
j-y-matsubara edited a comment on pull request #8867: URL: https://github.com/apache/airflow/pull/8867#issuecomment-632606590 @yuqian90 Thank you for your advise. I have corrected the document that you pointed out. And.. The continuous-integration/travis-ci/pr failure

[GitHub] [airflow] ashb commented on pull request #8901: Getting the connections correctly in AWS Secrets Manager backend

2020-05-22 Thread GitBox
ashb commented on pull request #8901: URL: https://github.com/apache/airflow/pull/8901#issuecomment-632632193 Hi @JavierLopezT The screenshot you posted looks like a nice feature -- is there a reason you closed this PR?

[GitHub] [airflow] ashb commented on pull request #7335: [AIRFLOW-6711] Drop plugin support for stat_name_handler

2020-05-22 Thread GitBox
ashb commented on pull request #7335: URL: https://github.com/apache/airflow/pull/7335#issuecomment-632631751 Ohhh, yeah, you may be right. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (AIRFLOW-6711) Drop plugin support for stat_name_handler

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113943#comment-17113943 ] ASF GitHub Bot commented on AIRFLOW-6711: - ashb commented on pull request #7335: URL:

[jira] [Commented] (AIRFLOW-4512) New trigger rule for tasks - At least one successful

2020-05-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113932#comment-17113932 ] ASF GitHub Bot commented on AIRFLOW-4512: - psuanm5030 commented on pull request #5288: URL:

  1   2   >